DOC: Edited 51Degrees section of README.

2015-12-03 Thread Ben Shillito
Hi, Attached is a patch with an edit to the information in the README regarding 51Degrees installation and configuration. Ben. This email and any attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender immediately and do not

51Degrees Trie Update Patch

2016-07-06 Thread Ben Shillito
Attached is a patch submission which makes changes to the 51Degrees Trie implementation to work with recent changes to github.com/51Degrees/Device-Detection/src/trie/51Degrees.c. Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +44 1183 287152 E: b...@51degrees.com<

RE: 51Degrees Trie Update Patch

2016-08-08 Thread Ben Shillito
Hi Willy, Yes I agree, this is a problem. I have attached a patch with a change to the readme which explains that that the correct version must be pulled if using <=1.6. Regards, Ben. Ben Shillito Developer E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarr

[PATCH] 51Degrees Docs

2016-12-02 Thread Ben Shillito
I have attached a patch which adds definitions for the 51Degrees converter and fetch functions to docs/configuration.txt so the they will appear in the online documentation. This should also be backported. Thanks, Ben. Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +4

RE: Build error with 51degrees library

2017-07-19 Thread Ben Shillito
the URL which is referenced in the instructions, and 1.7/dev now reference the 3.2.10 stable branch. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 19 July 2017 10:59 To: Ben Shillito

RE: Build error with 51degrees library

2017-07-19 Thread Ben Shillito
way forward if we’ve made an innocent mistake? Thanks, Ben Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Florian Tham [mailto:fgt...@gmail.com] Sent: 19 July 2017 09:20 To: Willy Tarreau <w...@1wt.eu> Cc: James Rosewe

RE: Build error with 51degrees library

2017-07-19 Thread Ben Shillito
Hi Willy, Thanks for the additional change. And that's quite alright, if there is a problem with our API that is affecting users live builds like this, then it will always be our top priority. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees

RE: [PATCHES] 51d: fix warning when building with 51Degrees release version 3.2.12.12

2017-10-05 Thread Ben Shillito
. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy TARREAU [mailto:wtarr...@haproxy.com] Sent: 05 October 2017 16:40 To: Ben Shillito <b...@51degrees.com> Cc: Dragan Dosen <ddo...@haproxy.com>; haproxy@formilux.org

RE: [PATCHES] 51d: fix warning when building with 51Degrees release version 3.2.12.12

2017-10-05 Thread Ben Shillito
Hi Willy, Yes of course. I have attached a patch which has the correct branch and updated instructions about where to get the free Hash Trie file now that it is no longer part of the git repository. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees

RE: [PATCHES] 51d: fix warning when building with 51Degrees release version 3.2.12.12

2017-10-05 Thread Ben Shillito
ttps://51degrees.com/products/store/on-premise-device-detection. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Dragan Dosen [mailto:ddo...@haproxy.com] Sent: 02 October 2017 10:14 To: haproxy@formilux.org Cc: Willy Tarreau &

RE: [PATCHES] 51d: fix warning when building with 51Degrees release version 3.2.12.12

2017-10-06 Thread Ben Shillito
hould be used for the new Hash Trie source. Apologies for any confusion. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy TARREAU [mailto:wtarr...@haproxy.com] Sent: 05 October 2017 17:39 To: Ben Shillito <b...@51d

[PATCH] Buffer API changes for 51d.c

2019-01-16 Thread Ben Shillito
Hi Willy, It appears that 51.d still uses some elements of the the now deprecated buffer API, so I have attached a patch which updates the usage to the new buffer API. This can also be backported to 1.9 where the new API was introduced. Thanks, Ben Shillito Developer [51Degrees]<ht

RE: [PATCH] Buffer API changes for 51d.c

2019-01-16 Thread Ben Shillito
Hi Willy, Great, thanks for the quick turnaround. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 16 January 2019 16:27 To: Ben Shillito Cc: haproxy@formilux.org Subject: Re

RE: Does anyone *really* use 51d or WURFL ?

2019-01-21 Thread Ben Shillito
to the 51Degrees default, and give the option to disable threading for those who require that. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 21 January 2019 14:36 To: haproxy@formilux.org Subject

RE: Does anyone *really* use 51d or WURFL ?

2019-01-21 Thread Ben Shillito
Hi Willy, I agree, setting the flag from the HAProxy USE_THREADS is probably the neatest solution. I will get a patch over to you later on today. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w

RE: Does anyone *really* use 51d or WURFL ?

2019-01-21 Thread Ben Shillito
Hi Willy, Ah yes, thanks, I missed the S first time reading it. There are actually a couple of things I'd like to check over a bit more thoroughly like the caching used in 51d.c, so it will probably be more like tomorrow. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b

RE: Does anyone *really* use 51d or WURFL ?

2019-02-05 Thread Ben Shillito
the Hash Trie API. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 21 January 2019 16:48 To: Ben Shillito Cc: haproxy@formilux.org Subject: Re: Does anyone *really* use 51d or WURFL

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
if this gets you up and running. Regards, Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +44 1183 287152 E: b...@51degrees.com<mailto:b...@51degrees.com?subject=Your%20Email> [https://51degrees.com/portals/0/images/twitterbird.png] @51Degrees<http://twitter.co

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
://51degrees.com/Support/Documentation/APIs/C-V32/Benchmarks If you need any more information, or help setting up, do let me know. Regards, Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +44 1183 287152 E: b...@51degrees.com<mailto:b...@51degrees.com?subject=Your%20Emai

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
Hi Willy, Great, thanks. Yeah that makes total sense. Don't want warnings that can't be solved. Regards, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 13 June 2019 17:06 To: Ben Shillito

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
dummy library)" to the output of REGISTER_BUILD_OPTS macro. I thought about pushing a warning when the dummy library is used just to be super obvious. Don't know what you think of that? Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
in order to make use of the efficiency of Trie. Regards, Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +44 1183 287152 E: b...@51degrees.com<mailto:b...@51degrees.com?subject=Your%20Email> [https://51degrees.com/portals/0/images/twitterbird.png] @51Degrees<htt

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
Hi Willy, Yes, I agree the paths in the dummy library should match that of the actual library. And yes, that patch is good with me. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-13 Thread Ben Shillito
Thanks both, Ilya, I will take a look at that now. Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +44 1183 287152 E: b...@51degrees.com<mailto:b...@51degrees.com?subject=Your%20Email> [https://51degrees.com/portals/0/images/twitterbird.png] @51Degrees<htt

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Ben Shillito
Hi Willy, Great, thanks for those changes, and good spot. I agree that this is a significant step forward, and having the entire codebase testable in CI will certainly make everything that bit smoother. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Ben Shillito
Hi Willy, This unfortunately fell down our list of priorities in the last few weeks. However, as this is a bit more urgent now with your weekend release, I will get the change for HTX awareness to you either today or tomorrow if that is ok with you? Thanks, Ben Shillito Developer O: +44 1183

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-06-12 Thread Ben Shillito
to make sure you have everything you need for a weekend release. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 12 June 2019 10:12 To: Ben Shillito Cc: Christopher Faulet ; HAProxy

RE: [PATCH] wurfl device detection build fixes and dummy library

2019-04-24 Thread Ben Shillito
Hi Willy, Thanks for the update. We will take a look and get a patch over to you. Thanks, Ben Shillito Developer O: +44 1183 287152 E: b...@51degrees.com T: @51Degrees -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: 23 April 2019 10:11 To: Paul Stephen Borile Cc

RE: Possible optimization to 51d in multithread

2019-10-24 Thread Ben Shillito
to the other change. Thanks, Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +44 1183 287152 E: b...@51degrees.com<mailto:b...@51degrees.com?subject=Your%20Email> [https://51degrees.com/portals/0/images/twitterbird.png] @51Degrees<http://twitter.com/51Degreesmobi> [htt

51d.c HTX patch

2020-01-20 Thread Ben Shillito
the fix out there as soon as we can. Thanks, Ben Shillito Developer [51Degrees]<https://51degrees.com/> O: +44 1183 287152 E: b...@51degrees.com<mailto:b...@51degrees.com?subject=Your%20Email> [https://51degrees.com/portals/0/images/twitterbird.png] @51Degrees<http://twitter.co