Re: SPOE and modsecurity contrib

2018-05-20 Thread Daniel Corbett
Hello Joao, While I haven't been able to get 'tcp-request content reject' to work with this configuration -- I am able to get 'http-request deny' to work: http-request deny if { var(txn.modsec.code) -m int gt 0 } Regarding txn.modsec.code -- I have been able to reproduce the

Re: warnings during loading load-server-state, expected?

2018-05-19 Thread Daniel Corbett
his should be backported to 1.8 Thanks, -- Daniel >From 24f8a74f490435969c04e2bb5387d396b62850c0 Mon Sep 17 00:00:00 2001 From: Daniel Corbett <dcorb...@haproxy.com> Date: Sat, 19 May 2018 19:43:24 -0400 Subject: [PATCH] BUG/MEDIUM: servers state: Add srv_addr default placeholder When creating

[PATCH] BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters

2018-05-17 Thread Daniel Corbett
. Added stktable_release() to the end of each sample_conv_table_* function. This should be backported to 1.8. Thanks, -- Daniel >From 28530921746e62bb229880774a311bfebfcf7579 Mon Sep 17 00:00:00 2001 From: Daniel Corbett <dcorb...@haproxy.com> Date: Thu, 17 May 2018 13:17:54 -0400 Subjec

Re: gRPC protocol

2018-05-24 Thread Daniel Corbett
Hello Aleks, gRPC is on our road map.  We're currently working on implementing a new native internal HTTP representation and that will bring us end to end HTTP/2, which is the requirement for us to add gRPC. In regards to the gRPC lua script -- thanks for sharing.  It's the first time I

Re: [PATCH] BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters

2018-05-27 Thread Daniel Corbett
bf Mon Sep 17 00:00:00 2001 From: Daniel Corbett <dcorb...@haproxy.com> Date: Sun, 27 May 2018 09:47:12 -0400 Subject: [PATCH] BUG/MEDIUM: stick-tables: Decrement ref_cnt in table_* converters When using table_* converters ref_cnt was incremented and never decremented causing entries t

Re: Use acl on spoe events

2018-05-27 Thread Daniel Corbett
Hello Joao, On 05/26/2018 05:54 PM, Joao Morais wrote: There is no difference if I use acl like the example above, or use the `if {...}` syntax or remove the acl at all, my modsecurity agent always receive a new connection despite of the host I’m using. Is there a way to use a spoe filter

Re: how to run vtc files?

2018-06-20 Thread Daniel Corbett
Hello, On 06/20/2018 03:34 PM, Илья Шипицин wrote: hi [ilia@localhost haproxy]$ HAPROXY_PROGRAM=./haproxy varnishtest reg-tests/ssl/h0.vtc top   0.0 extmacro def pwd=/home/ilia/xxx/haproxy top   0.0 extmacro def localhost=127.0.0.1 top   0.0 extmacro def

[PATCH] REGTEST: stick-tables: Test expiration when used with table_*

2018-06-20 Thread Daniel Corbett
rom 386ed3ca039ea2b5dec7397ba9934576217a421e Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Wed, 20 Jun 2018 10:16:16 -0400 Subject: [PATCH] REGTEST: stick-tables: Test expiration when used with table_* New regression test to check for stick-tables expiration when they are used with table_* converters as noted in commit

Re: HAProxy listed as Ingress controllers

2018-09-25 Thread Daniel Corbett
Hello Aleks, On 09/25/2018 03:25 AM, Aleksandar Lazic wrote: Hi. Today was the PR to the website approved which add the haproxy ingress controller to the list of Ingress controllers ;-) https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-controllers Is there any plan to

Re: [PATCH] BUG/MEDIUM: init: Initialize idle_orphan_conns for first server in server-template

2019-01-09 Thread Daniel Corbett
patches using aliases only for the author. Thanks! Willy Sure -- attached you will find the new patch with the updated details. Thanks, -- Daniel >From 13b37d5366be36535b3c67242ae0ac328e3aaaf8 Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Wed, 9 Jan 2019 08:13:29 -0500 Subject: [PATCH]

[PATCH] BUG/MEDIUM: contrib/spoa_server: Set FIN flag on agent frames

2019-05-29 Thread Daniel Corbett
Hello, When communicating over SPOP the AGENT-HELLO, AGENT-DISCONNECT, and ACK frames must have the FIN flag set. This patch also upgrades the SPOP_VERSION to 2.0 and adds the "ip_score" transaction variable to the python & lua scripts. Thanks to Christopher for giving me the answer on how to

Re: [PATCH] BUG/MEDIUM: contrib/spoa_server: Set FIN flag on agent frames

2019-06-11 Thread Daniel Corbett
Hello Willy, Apologies for the delay. Thank you for taking the time to review. > On Jun 2, 2019, at 10:11 PM, Willy Tarreau wrote: > > Hi Daniel, > > On Thu, May 30, 2019 at 12:57:10AM -0400, Daniel Corbett wrote: >> Hello, >> >> >> When communi

[PATCH] [MEDIUM] dns: Add resolve-opts "ignore-weight"

2019-11-17 Thread Daniel Corbett
syslog. Thanks, -- Daniel >From 59381396c68d776d220e76ccc6b80e4a2f7ff068 Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Sun, 17 Nov 2019 09:48:56 -0500 Subject: [PATCH] [MEDIUM] dns: Add resolve-opts "ignore-weight" It was noted in #48 that there are times when a configur

Re: [PATCH] [MEDIUM] dns: Add resolve-opts "ignore-weight"

2019-11-18 Thread Daniel Corbett
Hello, On 11/18/19 7:05 AM, Willy Tarreau wrote: On Mon, Nov 18, 2019 at 12:06:08PM +0100, Baptiste wrote: When we first designed this feature, we did it with this in mind "if admins can update a SRV record in a DNS server, they can adjust the weight accordingly". I understand the need, but

Re: stable-bot for 2.1

2019-12-08 Thread Daniel Corbett
Hey Julien, On 12/8/19 2:49 PM, Julien Pivotto wrote: Hi, I have the impression that stable-bot has not been configured for the 2.1 branch yet. Regards, Thanks for the reminder!  I've gone ahead and added it. Thanks, -- Daniel

Re: stable-bot for 2.1

2019-12-09 Thread Daniel Corbett
Hey William, On 12/9/19 1:34 AM, William Lallemand wrote: On Sun, Dec 08, 2019 at 07:37:46PM -0500, Daniel Corbett wrote: Hey Julien, On 12/8/19 2:49 PM, Julien Pivotto wrote: Hi, I have the impression that stable-bot has not been configured for the 2.1 branch yet. Regards, Thanks

Re: [PATCH] BUG/MEDIUM: dns: Correctly use weight specified in SRV record

2019-10-16 Thread Daniel Corbett
Hello, On 10/16/19 11:32 PM, Daniel Corbett wrote: This patch should be backported to 1.8 and 1.9 Sorry, I forgot to indicate that this should be backported to 2.0 also. Thanks, -- Daniel

[PATCH] BUG/MEDIUM: dns: Correctly use weight specified in SRV record

2019-10-16 Thread Daniel Corbett
ended up forcing "1" in all situations.  This was due to an improper equation: ( x / 256 ) + 1 This patch should be backported to 1.8 and 1.9 Thanks, -- Daniel >From b9c2d037b0b3cf06a7908bcaa4949a29245574ca Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Wed, 16 Oct 2019 23

Re: [PATCH] BUG/MEDIUM: dns: Correctly use weight specified in SRV record

2019-10-17 Thread Daniel Corbett
Hello, On 10/17/19 1:47 AM, Baptiste wrote: Hi Daniel, Thanks for the patch, but I don't think it's accurate. What this part of the code aims to do is to "map" a DNS weight into an HAProxy weight. There is a ratio of 256 between both: DNS being in range "0-65535" and HAProxy in range

Re: Haproxy only tracking at maximum 3 keys for api-key based tracking

2019-11-01 Thread Daniel Corbett
Hello On 11/1/19 2:03 AM, Victor Jonathon Calel wrote: backend sec_table          stick-table type string len 64 size 500k expire 5s store gpc0,gpt0,http_req_rate(1s) backend min_table           stick-table type string len 64 size 500k expire 5s store http_req_rate(60s) As you can see

Re: stable-bot: Bugfixes waiting for a release 2.1 (7), 2.0 (5)

2020-02-25 Thread Daniel Corbett
Hey Tim & Willy, On 2/25/20 10:45 PM, Willy Tarreau wrote: On Wed, Feb 26, 2020 at 01:23:24AM +0100, Tim Düsterhus wrote: Daniel, I already told you in IRC, but as I now have an email to reply to: This new email format is much better than the old one. FWIW I agree, it's more synthetic and

Re: stable-bot: WARNING: 54 bug fixes in queue for next release - 2.1

2020-02-12 Thread Daniel Corbett
Hello, On 2/12/20 12:55 PM, Tim Düsterhus wrote: Threading would solve most of the pain points for me, because the emails will nicely be merged on both my computer and my phone. For the remaining points I don't really care that much. I'll leave this up to the people that actually read the

[PATCH] BUG/MINOR: stats: Fix color of draining servers on stats page

2020-03-28 Thread Daniel Corbett
when they are draining. Should be backported as far as 1.7. Thanks, -- Daniel >From ab59ade862665e8235d889d398e63d1b67aff243 Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Sat, 28 Mar 2020 12:35:50 -0400 Subject: [PATCH] BUG/MINOR: stats: Fix color of draining servers on stats page This pa

Re: stable-bot: Bugfixes waiting for a release 2.2 (18), 2.1 (13), 2.0 (8), 1.8 (6)

2020-08-19 Thread Daniel Corbett
Hello Tim, On 8/19/20 5:09 AM, Tim Düsterhus wrote: Daniel, The indentation is messed up here. Is this caused by the removal of 1.9? Yea, quite likely. I also have another proposal for readability of this list: Can the versions be ordered in descending order and possibly aligned within

Re: [PATCH] CONTRIB: release-estimator: Add release estimating tool

2020-10-24 Thread Daniel Corbett
Hey Willy, On 10/24/20 6:29 AM, Willy Tarreau wrote: On Thu, Oct 22, 2020 at 03:55:14PM -0400, Daniel Corbett wrote: Attached is a patch that adds the release estimating tool (stable-bot) to the contrib directory. Ah, great, thank you Daniel! I've merged it now. If we find that it starts

Re: [PATCH] DOC: typo fixes for configuration.txt

2020-07-07 Thread Daniel Corbett
Hello, On 7/7/20 7:19 AM, Илья Шипицин wrote: Daniel, can you please tell what spellchecker do you use ? (codespell does not see those typos) I used aspell. Thanks, -- Daniel

Re: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-20 Thread Daniel Corbett
Hello, On 6/19/20 3:22 PM, Willy Tarreau wrote: Hi Daniel, ... Thanks for the fix and the detailed report, that's very useful! However the problem is somewhere else, and I suspect is slightly harder to solve. It's normally not possible to have a null sink on a log server if its type is a

[PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-17 Thread Daniel Corbett
efc622 in main (argc=4, argv=0x7ffcd94960a8) at src/haproxy.c:3758 Thanks, -- Daniel >From c5793a0ab7372329b7bc69e823b4bb960311a58a Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Thu, 18 Jun 2020 00:10:17 -0400 Subject: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in

Re: [PATCH] BUG/MEDIUM: sink: fix crash when null sink is used in __do_send_log

2020-06-17 Thread Daniel Corbett
Hello, On 6/18/20 12:35 AM, Daniel Corbett wrote: Hello, When using a ring log in combination with proto fcgi, it was possible to cause a crash by sending a request for a non-existent fastcgi file to php-fpm, causing it to produce the error "Primary script unknown". When php-fp

[PATCH] DOC: typo fixes for configuration.txt

2020-07-06 Thread Daniel Corbett
Hello, Here's a quick round of typo corrections for configuration.txt Thanks, -- Daniel 0001-DOC-configuration-various-typo-fixes.patch Description: Binary data

[PATCH] DOC: Add dns as an available domain to show stat

2020-11-01 Thread Daniel Corbett
may think this field accepts dynamic options when it actually requires a specific keyword. Thanks, -- Daniel >From 2107724812463093fbcee23d669dd86d3949aa28 Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Sun, 1 Nov 2020 10:54:17 -0500 Subject: [PATCH] DOC: Add dns as an available doma

[PATCH] CONTRIB: release-estimator: Add release estimating tool

2020-10-22 Thread Daniel Corbett
to run weekly as it has been but it will allow others to contribute to it and also run it locally. Thanks, -- Daniel >From b3ad15e87b70ed741b8cafc2830491c9d1b7e01a Mon Sep 17 00:00:00 2001 From: Daniel Corbett Date: Thu, 22 Oct 2020 11:19:55 -0400 Subject: [PATCH] CONTRIB: release-estima

[PATCH] DOC: config: Fix configuration example for mqtt

2021-05-13 Thread Daniel Corbett
Hello, This patch fixes the example for mqtt_is_valid(), which was missing curly braces within the ACL. Thanks, -- Daniel 0001-DOC-config-Fix-configuration-example-for-mqtt.patch Description: Binary data

[PATCH] CLEANUP: cli/activity: Remove double spacing in set profiling

2021-05-10 Thread Daniel Corbett
Hello, It was found that when viewing the help output from the CLI that "set profiling" had 2 spaces in it, which was pushing it out from the rest of similar commands. i.e. it looked like this: prepare acl prepare map set profiling{auto|on|off} set

[PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

2021-05-08 Thread Daniel Corbett
Hello, This patch fixes a few grammar and spelling issues in configuration.txt. It was also noted that there was a wide range of case usage (i.e. haproxy, HAproxy, HAProxy, etc... ). This patch updates them all to be consistently "HAProxy" except where a binary is mentioned.

RE: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

2021-05-08 Thread Daniel Corbett
Sorry, I forgot to add the area the patch touches to the commit title. New patch attached to add that. Thanks, -- Daniel 0001-DOC-config-Fix-a-few-grammar-spelling-issues-and-cas.patch Description: Binary data

RE: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

2021-05-09 Thread Daniel Corbett
Hey Willy, > -Original Message- > From: Willy Tarreau > Sent: Sunday, May 9, 2021 12:07 AM > To: Daniel Corbett > Cc: haproxy@formilux.org > Subject: Re: [PATCH] DOC: Fix a few grammar/spelling issues and casing of > HAProxy > > Hi Daniel, > ...

RE: adding Coverity badge to some visible place

2021-05-14 Thread Daniel Corbett
Hello Ilya, > From: Илья Шипицин > Sent: Friday, May 14, 2021 11:10 AM > To: HAProxy > Subject: adding Coverity badge to some visible place > Hello, > > I would like to improve code quality visibility. > what if we convert README --> README.md and put Coverity badge there ? > Funny, I had a

[PATCH] BUG/MINOR: sample: Rename SenderComID/TargetComID to SenderCompID/TargetCompID

2021-03-09 Thread Daniel Corbett
Hello, The recently introduced Financial Information eXchange (FIX) converters have some hard coded tags based on the specification that were misspelled. Specifically, SenderComID and TargetComID should be SenderCompID and TargetCompID according to the specification [1][2]. This