Request for feedback: Add fetcher for getting all cookie names

2023-10-13 Thread Ruei-Bang Chen
Hi team, This is related to my previous email regarding adding a fetcher for all headers excluding cookies, but I think it might be helpful to open a separate thread to discuss this alone as cookie is a special header. We have a use-case where we need only cookie names but not their values.

Re: Request for feedback: Add fetcher for all headers excluding cookies

2023-10-13 Thread Ruei-Bang Chen
implementation, but we observed there would be a lot more malloc/free that impacted performance and took a lot of CPUs when QPS was high (100k+). Ruei-Bang From: Willy Tarreau Sent: Thursday, October 12, 2023 8:56 PM To: Ruei-Bang Chen Cc: haproxy@formilux.org Subject: Re

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-26 Thread Ruei-Bang Chen
a single patch for everything. Thanks! Ruei-Bang From: Willy Tarreau Sent: Monday, October 23, 2023 2:57 AM To: Ruei-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Ruei-Bang, On Sat, Oct 21, 2023

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-02 Thread Ruei-Bang Chen
From: Ruei-Bang Chen Sent: Friday, October 27, 2023 2:16 PM To: Willy Tarreau Cc: haproxy@formilux.org Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Willy, Thanks for pointing that out. I have merged them into a single patch

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-11-03 Thread Ruei-Bang Chen
Hi Willy, The simplification makes sense! I don't mind you changing it at all. I really appreciate the feedback from you. Ruei-Bang From: Willy Tarreau Sent: Friday, November 3, 2023 1:50 AM To: Ruei-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH

Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-27 Thread Ruei-Bang Chen
-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH] MINOR: sample: Add fetcher for getting all cookie names Hi Ruei-Bang, On Fri, Oct 27, 2023 at 01:44:30AM +, Ruei-Bang Chen wrote: > Hi Willy, > > Thanks for the feedback! > > I have attached the 2 patches (with one bei

Request for feedback: Add fetcher for all headers excluding cookies

2023-10-12 Thread Ruei-Bang Chen
Hi team, I am writing to gather feedback on an idea before doing the implementation. We have a use-case where we need all headers except for cookies. Currently, the fetcher "req.hdrs" / "res.hdrs" returns all headers including cookie / set-cookie headers. However, the cookie header itself

[PATCH] MINOR: sample: Add fetcher for getting all cookie names

2023-10-20 Thread Ruei-Bang Chen
Hi team, As discussed in https://www.mail-archive.com/haproxy@formilux.org/msg44161.html, I have attached a patch for adding a new fetcher for getting all the cookie names for request / response. I did check some relevant docs (like CONTRIBUTING, coding-style.txt etc.) for the guidelines

[PATCH] MEDIUM: sample: Modify fetchers for req.hdrs and res.hdrs to selectively include / exclude headers

2023-11-09 Thread Ruei-Bang Chen
Hi team, Based on the feedback from https://www.mail-archive.com/haproxy@formilux.org/msg44153.html, I have attached a patch for modifying fetchers for req.hdrs and res.hdrs to selectively include / exclude headers. I have the following 3 questions while I was doing this change: 1. Should

Re: [PATCH] MEDIUM: sample: Modify fetchers for req.hdrs and res.hdrs to selectively include / exclude headers

2024-01-22 Thread Ruei-Bang Chen
before getting back to you. Thanks, Ruei-Bang From: Willy Tarreau Sent: Friday, January 19, 2024 6:28 AM To: Ruei-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH] MEDIUM: sample: Modify fetchers for req.hdrs and res.hdrs to selectively include / exclude

Re: [PATCH] MEDIUM: sample: Modify fetchers for req.hdrs and res.hdrs to selectively include / exclude headers

2023-12-12 Thread Ruei-Bang Chen
ot;res.hdrs", wondering what are your thoughts on this? Thanks, Ruei-Bang ________ From: Willy Tarreau Sent: Thursday, November 9, 2023 9:22 PM To: Ruei-Bang Chen Cc: haproxy@formilux.org Subject: Re: [PATCH] MEDIUM: sample: Modify fetchers for req.hdrs and res.hdrs to selectively include / exclude

Re: [PATCH] MEDIUM: sample: Modify fetchers for req.hdrs and res.hdrs to selectively include / exclude headers

2024-01-09 Thread Ruei-Bang Chen
-Bang From: Ruei-Bang Chen Sent: Tuesday, December 12, 2023 5:32 PM To: Willy Tarreau Cc: haproxy@formilux.org Subject: Re: [PATCH] MEDIUM: sample: Modify fetchers for req.hdrs and res.hdrs to selectively include / exclude headers Hi Willy, Sorry for the late