RFC uuid for log-format

2019-09-03 Thread Schimweg, Luca
Hey, for one use case I have, I would need a variable like %uuid in log-formats, which just generates a random UUID. The use-case would be, to be able to set the unique-id-format to this uuid, so that we can have a random uuid set as request-id for any incoming request. Right now, it’s quite

Re: RFC uuid for log-format

2019-09-03 Thread Schimweg, Luca
I would be open to implement this feature, as it is currently not possible to implement this behavior (at least afaik). Would there be interest in such a feature from the community? From: "Schimweg, Luca" Date: Tuesday, 3. September 2019 at 09:19 To: "haproxy@formilux.org"

Re: RFC uuid for log-format

2019-09-03 Thread Schimweg, Luca
ot;li...@ltri.eu on behalf of Lukas Tribus" wrote: Hello Luca, On Tue, 3 Sep 2019 at 09:18, Schimweg, Luca wrote: > > Hey, > > > > for one use case I have, I would need a variable like %uuid in log-formats, > which just generates a

Re: RFC uuid for log-format

2019-09-03 Thread Schimweg, Luca
Hey, we are using a similar procedure right now, but we got the requirement to use the format of, or similar to, a uuid. Best regards, Luca From: Conrad Hoffmann Sent: Tuesday, September 3, 2019 4:45:57 PM To: Schimweg, Luca ; Lukas Tribus Cc: haproxy

Re: RFC uuid for log-format

2019-09-05 Thread Schimweg, Luca
ri.eu on behalf of Lukas Tribus" wrote: Hello Luca, On Tue, 3 Sep 2019 at 09:18, Schimweg, Luca wrote: > > Hey, > > > > for one use case I have, I would need a variable like %uuid in log-formats, > which just generates a

Re: RFC uuid for log-format

2019-09-05 Thread Schimweg, Luca
format to, but UUIDs are a standardized format, so I cannot imagine why it is that hard using it, because there are probably many people that want to use it. Best regards Luca On 05.09.19, 17:38, "Geoff Simmons" wrote: On 9/5/19 16:58, Schimweg, Luca wrote: > >

Re: RFC uuid for log-format

2019-09-05 Thread Schimweg, Luca
not require too much effort. @Willy, whats your opinion on this? Best regards Luca On 05.09.19, 17:32, "li...@ltri.eu on behalf of Lukas Tribus" wrote: Hello, On Thu, Sep 5, 2019 at 4:58 PM Schimweg, Luca wrote: > > Hey again, > > I tried

Re: RFC uuid for log-format

2019-09-05 Thread Schimweg, Luca
, Willy has to decide whether we want a feature like this. Best regards, Luca On 05.09.19, 19:00, "li...@ltri.eu on behalf of Lukas Tribus" wrote: Hello Luca, On Thu, Sep 5, 2019 at 5:38 PM Schimweg, Luca wrote: > > Hey, > > i would

Re: RFC uuid for log-format

2019-09-06 Thread Schimweg, Luca
11PM +, Schimweg, Luca wrote: > Hey, > > just for you to get an impression, a quick draft of what a change could look like: > > https://github.com/lucaschimweg/haproxy/commit/5306395c062ac20b6d030d48c48290d5f08db5cc ( pasted here for discussion)

Re: RFC uuid for log-format

2019-09-11 Thread Schimweg, Luca
Hey, thanks for the feedback. I included the changes in the updated patch. Best regards Luca On 11.09.19, 08:52, "Willy Tarreau" wrote: On Tue, Sep 10, 2019 at 03:56:43PM +0200, Tim Düsterhus wrote: > Luca, > > Am 10.09.19 um 15:48 schrieb Schimweg,

Re: RFC uuid for log-format

2019-09-10 Thread Schimweg, Luca
Hey, I just integrated your change requests into my fork and created a PR: https://github.com/haproxy/haproxy/pull/271, would be happy if anyone could give me some feedback! Best regards, Luca On 06.09.19, 11:41, "Willy Tarreau" wrote: On Fri, Sep 06, 2019 at 11:33:32AM +0200, Geoff

Re: RFC uuid for log-format

2019-09-10 Thread Schimweg, Luca
Hey, sorry, didn't know about these guidelines. I packed all changes into one commit in the patch file in the attachments. I included your changes, you are right, the code looks much better now. I'm open for any feedback. Best regards, Luca On 10.09.19, 14:25, "Tim Düsterhus" wrote:

Re: RFC uuid for log-format

2019-09-11 Thread Schimweg, Luca
Luca, Am 11.09.19 um 09:40 schrieb Schimweg, Luca: > thanks for the feedback. I included the changes in the updated patch. > Something went wrong with the commit message: > Subject: [PATCH] MINOR: sample: Add UUID-fetch Adds the fetch uuid(int). New &g

Re: RFC uuid for log-format

2019-09-12 Thread Schimweg, Luca
Hey Willy, thanks so much! Best regards Luca On 13.09.19, 04:48, "Willy Tarreau" wrote: Hi Luca, On Wed, Sep 11, 2019 at 10:31:27AM +, Schimweg, Luca wrote: > Hey Tim, > > Thanks, I missed the empty line. Fixed it > Yeah