Re: [PATCH] BUG/MEDIUM: kqueue/poll: only use EV_SET when actually needing to add or remove event filters

2018-04-15 Thread Willy Tarreau
Hi Pieter, On Mon, Apr 16, 2018 at 02:22:48AM +0200, PiBa-NL wrote: >     EVFILT_READ, EV_ADD (8) >     EVFILT_WRITE, EV_DELETE (8) >     EVFILT_READ, EV_ADD (7) >     Events changed:3 result:-1 err:2 <<< ERROR while deleting a non > existing event > > After this the KernelEvent for FD 7

Re: [PATCH] BUG/MEDIUM: kqueue/poll: only use EV_SET when actually needing to add or remove event filters

2018-04-15 Thread PiBa-NL
Hi Willy, Op 15-4-2018 om 23:08 schreef Willy Tarreau: Well to be clear, I'm pretty sure we're hiding the dust under the carpet here, even if it fixes the problem in your case. What I need to do is to actually understand why we end up in this situation. Okay added a little more code/error

Re: [PATCH] BUG/MEDIUM: kqueue/poll: only use EV_SET when actually needing to add or remove event filters

2018-04-15 Thread Willy Tarreau
Hi Pieter, On Sun, Apr 15, 2018 at 10:55:34PM +0200, PiBa-NL wrote: > Hi Willy, > > Sending a patch proposal after like 40 hours of looking through what happens > and what event we might be missing, im now changing +-40 lines of code.. And > actually not 'really' changing the events requested..

[PATCH] BUG/MEDIUM: kqueue/poll: only use EV_SET when actually needing to add or remove event filters

2018-04-15 Thread PiBa-NL
17 00:00:00 2001 From: PiBa-NL <piba.nl@gmail.com> Date: Sun, 15 Apr 2018 22:20:22 +0200 Subject: [PATCH] BUG/MEDIUM: kqueue/poll: only use EV_SET when actually needing to add or remove event filters Avoid event filters being added twice or deleted while not present causing hanging re