Re: [PATCH] BUG/MEDIUM: tools: fix build with static only toolchains

2020-07-24 Thread Willy Tarreau
Hi Baruch, On Fri, Jul 24, 2020 at 01:05:54PM +0300, Baruch Siach wrote: > I can confirm that the patch below also fixes the same build issue. Great, thank you! I've updated your first patch to use this one instead, adjusted the commit message accordingly, and marked it for backport to 2.1.

Re: [PATCH] BUG/MEDIUM: tools: fix build with static only toolchains

2020-07-24 Thread Baruch Siach
Hi Willy, On Fri, Jul 24 2020, Willy Tarreau wrote: > On Fri, Jul 24, 2020 at 07:40:01AM +0200, Willy Tarreau wrote: >> On Fri, Jul 24, 2020 at 07:52:20AM +0300, Baruch Siach wrote: >> > uClibc toolchains built with no dynamic library support don't provide >> > the dlfcn.h header. That leads to

Re: [PATCH] BUG/MEDIUM: tools: fix build with static only toolchains

2020-07-24 Thread Willy Tarreau
On Fri, Jul 24, 2020 at 07:40:01AM +0200, Willy Tarreau wrote: > On Fri, Jul 24, 2020 at 07:52:20AM +0300, Baruch Siach wrote: > > uClibc toolchains built with no dynamic library support don't provide > > the dlfcn.h header. That leads to build failure: > > > > CC src/tools.o > >

Re: [PATCH] BUG/MEDIUM: tools: fix build with static only toolchains

2020-07-23 Thread Willy Tarreau
On Fri, Jul 24, 2020 at 07:52:20AM +0300, Baruch Siach wrote: > uClibc toolchains built with no dynamic library support don't provide > the dlfcn.h header. That leads to build failure: > > CC src/tools.o > src/tools.c:15:10: fatal error: dlfcn.h: No such file or directory > #include >

[PATCH] BUG/MEDIUM: tools: fix build with static only toolchains

2020-07-23 Thread Baruch Siach
uClibc toolchains built with no dynamic library support don't provide the dlfcn.h header. That leads to build failure: CC src/tools.o src/tools.c:15:10: fatal error: dlfcn.h: No such file or directory #include ^ Enable dladdr only when USE_DL is defined. --- Please Cc