Re: [PATCH] BUG/MINOR: checks: Include UNIX server paths in arguments

2019-06-12 Thread linuxdaemon Snoonet
Hi Willy, Do you think we should abstract the formatting of the address to a function and use the same format for the proxy address for external checks? Currently my changes just mimic the proxy address logic for server address, so if we want to add the ability to easily distinguish the socket

Re: [PATCH] BUG/MINOR: checks: Include UNIX server paths in arguments

2019-06-11 Thread Willy Tarreau
Hi, I think we could take this one, however I'm having some comments : On Mon, Jun 10, 2019 at 04:13:19PM -0500, linuxdaemon wrote: > --- a/src/checks.c > +++ b/src/checks.c > @@ -1891,8 +1891,23 @@ static int prepare_external_check(struct check *check) > goto err; > } > >

[PATCH] BUG/MINOR: checks: Include UNIX server paths in arguments

2019-06-10 Thread linuxdaemon
The path of UNIX server connections should be sent as an argument to the external-check command, to mimic how it behaves with IPv4 and v6 server connections, and UNIX proxy listeners. The port is set to an empty string (existing behavior) instead of "NOT_USED" (to mimic the proxy_port argument) to