Re: [PATCH] CLEANUP: slz: Mark `reset_refs` as static
Willy, On 11/5/21 4:43 PM, Willy Tarreau wrote: Yes, sorry, but I will really deal with that stuff *after* we're done with haproxy's release. Yes, absolutely. I just came across this point on my list while I was double-checking whether I had anything important / any loose ends for 2.5 and thought I'd sent an email so that I don't forget about this myself :-) Best regards Tim Düsterhus
Re: [PATCH] CLEANUP: slz: Mark `reset_refs` as static
On Fri, Nov 05, 2021 at 02:17:51PM +0100, Tim Düsterhus wrote: > Willy, > > On 10/11/21 5:15 PM, Tim Düsterhus wrote: > > > > > > please also apply to https://github.com/wtarreau/libslz/. > > > > > > [...] > > > > > > > > > > Now applied, thanks! > > > > > > > > Not seeing anything in the libslz repository yet. Did you forget to > > > > push? > > > > :-) > > > > > > No, I've applied to the haproxy copy only for now, will do slz later, > > > and after double-checking that no legacy code still uses the function > > > (becaure in the very first incarnation it had to be called from the > > > main code, which was not very handy). But I guess that any such code > > > I could find would just be test code. > > > > Reminder in case you forgot about this and did not just get not around > > to it. > > > > Another reminder, because you did not reply to my previous. Yes, sorry, but I will really deal with that stuff *after* we're done with haproxy's release. Thanks, Willy
Re: [PATCH] CLEANUP: slz: Mark `reset_refs` as static
Willy, On 10/11/21 5:15 PM, Tim Düsterhus wrote: please also apply to https://github.com/wtarreau/libslz/. [...] Now applied, thanks! Not seeing anything in the libslz repository yet. Did you forget to push? :-) No, I've applied to the haproxy copy only for now, will do slz later, and after double-checking that no legacy code still uses the function (becaure in the very first incarnation it had to be called from the main code, which was not very handy). But I guess that any such code I could find would just be test code. Reminder in case you forgot about this and did not just get not around to it. Another reminder, because you did not reply to my previous. Best regards Tim Düsterhus
Re: [PATCH] CLEANUP: slz: Mark `reset_refs` as static
Willy, On 9/24/21 3:36 PM, Willy Tarreau wrote: On Fri, Sep 24, 2021 at 03:33:14PM +0200, Tim Düsterhus wrote: Willy, On 9/24/21 3:09 PM, Willy Tarreau wrote: please also apply to https://github.com/wtarreau/libslz/. [...] Now applied, thanks! Not seeing anything in the libslz repository yet. Did you forget to push? :-) No, I've applied to the haproxy copy only for now, will do slz later, and after double-checking that no legacy code still uses the function (becaure in the very first incarnation it had to be called from the main code, which was not very handy). But I guess that any such code I could find would just be test code. Reminder in case you forgot about this and did not just get not around to it. Best regards Tim Düsterhus
Re: [PATCH] CLEANUP: slz: Mark `reset_refs` as static
On Fri, Sep 24, 2021 at 03:33:14PM +0200, Tim Düsterhus wrote: > Willy, > > On 9/24/21 3:09 PM, Willy Tarreau wrote: > > > please also apply to https://github.com/wtarreau/libslz/. > > > [...] > > > > Now applied, thanks! > > Not seeing anything in the libslz repository yet. Did you forget to push? > :-) No, I've applied to the haproxy copy only for now, will do slz later, and after double-checking that no legacy code still uses the function (becaure in the very first incarnation it had to be called from the main code, which was not very handy). But I guess that any such code I could find would just be test code. Cheers, Willy
Re: [PATCH] CLEANUP: slz: Mark `reset_refs` as static
Willy, On 9/24/21 3:09 PM, Willy Tarreau wrote: please also apply to https://github.com/wtarreau/libslz/. [...] Now applied, thanks! Not seeing anything in the libslz repository yet. Did you forget to push? :-) Best regards Tim Düsterhus
Re: [PATCH] CLEANUP: slz: Mark `reset_refs` as static
Hi Tim, On Mon, Sep 20, 2021 at 07:59:42PM +0200, Tim Duesterhus wrote: > Willy, > > please also apply to https://github.com/wtarreau/libslz/. > Best regards > Tim Düsterhus > > Apply with `git am --scissors` to automatically cut the commit message. > > -- >8 -- > This function has no prototype and is not used outside of slz.c. Now applied, thanks! Willy
[PATCH] CLEANUP: slz: Mark `reset_refs` as static
Willy,
please also apply to https://github.com/wtarreau/libslz/.
Best regards
Tim Düsterhus
Apply with `git am --scissors` to automatically cut the commit message.
-- >8 --
This function has no prototype and is not used outside of slz.c.
---
src/slz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/slz.c b/src/slz.c
index 9aacb9b7a..23912da6a 100644
--- a/src/slz.c
+++ b/src/slz.c
@@ -466,7 +466,7 @@ static inline long memmatch(const unsigned char *a, const
unsigned char *b, long
* be applied to 64-bit aligned data exclusively, which makes it slightly
* faster than the regular memset() since no alignment check is performed.
*/
-void reset_refs(union ref *refs, long count)
+static void reset_refs(union ref *refs, long count)
{
/* avoid a shift/mask by casting to void* */
union ref *end = (void *)refs + count;
--
2.33.0
