Re: [PATCH] DOC: config: retry-on list is space-delimited
Hello, On Wed, 8 Dec 2021 at 17:50, Tim Düsterhus wrote: > > Lukas, > > On 12/8/21 11:33 AM, Lukas Tribus wrote: > > We are using comma-delimited list for init-addr for example, let's > > document that this is space-delimited to avoid the guessing game. > > Shouldn't this rather be fixed by unifying the delimiter instead of > updating the docs? e.g. add support for the comma as the delimiter and > then deprecate the use of spaces with a warning? I agree, but I'm also not able to contribute more than a doc change here. Also there is more than just those 2 uses of lists, here just a few, certainly incomplete, some space delimited, some comma delimited, some undocumented: user/group ssl-engine [algo] wurfl-information-list []* 51degrees-property-name-list [ ...] So first of all we would have to find all existing lists users in the haproxy configuration and then make a determination about what to do (and which parts to touch). That requires more work than a single line doc patch, which is all I can contribute at the moment. Lukas
Re: [PATCH] DOC: config: retry-on list is space-delimited
On Wed, Dec 08, 2021 at 05:50:50PM +0100, Tim Düsterhus wrote: > Lukas, > > On 12/8/21 11:33 AM, Lukas Tribus wrote: > > We are using comma-delimited list for init-addr for example, let's > > document that this is space-delimited to avoid the guessing game. > > Shouldn't this rather be fixed by unifying the delimiter instead of updating > the docs? e.g. add support for the comma as the delimiter and then deprecate > the use of spaces with a warning? This would indeed be an improvement but at the very least we need to merge Lukas' patch so that the doc reflects how to deal with current deployments. Willy
Re: [PATCH] DOC: config: retry-on list is space-delimited
Lukas, On 12/8/21 11:33 AM, Lukas Tribus wrote: We are using comma-delimited list for init-addr for example, let's document that this is space-delimited to avoid the guessing game. Shouldn't this rather be fixed by unifying the delimiter instead of updating the docs? e.g. add support for the comma as the delimiter and then deprecate the use of spaces with a warning? Best regards Tim DÜsterhus
[PATCH] DOC: config: retry-on list is space-delimited
We are using comma-delimited list for init-addr for example, let's document that this is space-delimited to avoid the guessing game. --- doc/configuration.txt | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/doc/configuration.txt b/doc/configuration.txt index 1e049012b..c810fa918 100644 --- a/doc/configuration.txt +++ b/doc/configuration.txt @@ -10124,17 +10124,18 @@ retries See also : "option redispatch" -retry-on [list of keywords] +retry-on [space-delimited list of keywords] Specify when to attempt to automatically retry a failed request. This setting is only valid when "mode" is set to http and is silently ignored otherwise. May be used in sections:defaults | frontend | listen | backend yes |no| yes | yes Arguments : - is a list of keywords or HTTP status codes, each representing a -type of failure event on which an attempt to retry the request -is desired. Please read the notes at the bottom before changing -this setting. The following keywords are supported : + is a space-delimited list of keywords or HTTP status codes, each +representing a type of failure event on which an attempt to +retry the request is desired. Please read the notes at the +bottom before changing this setting. The following keywords are +supported : none never retry @@ -10207,6 +10208,9 @@ retry-on [list of keywords] The default is "conn-failure". + Example: +retry-on 503 504 + See also: "retries", "option redispatch", "tune.bufsize" server [:[port]] [param*] -- 2.17.1
