Re: [PATCH 0/1] compression: Set Vary: Accept-Encoding

2019-06-17 Thread Willy Tarreau
On Mon, Jun 17, 2019 at 02:33:05PM +0200, Tim Düsterhus wrote: > > So in my opinion we should only emit "Vary: accept-encoding" when > > adding Content-Encoding. Am I missing something ? > > I believe you are correct that only sending the 'Vary' when actually > compressing is fine according to

Re: [PATCH 0/1] compression: Set Vary: Accept-Encoding

2019-06-17 Thread Tim Düsterhus
Willy, Am 17.06.19 um 14:17 schrieb Willy Tarreau: > Hi Tim, > > I'm back to this one : > > On Wed, Jun 12, 2019 at 10:36:51PM +0200, Tim Duesterhus wrote: >> This thread contains two "competing" patches to fix the BUG that HAProxy >> does not set the `Vary` response header when the compression

Re: [PATCH 0/1] compression: Set Vary: Accept-Encoding

2019-06-17 Thread Willy Tarreau
Hi Tim, I'm back to this one : On Wed, Jun 12, 2019 at 10:36:51PM +0200, Tim Duesterhus wrote: > This thread contains two "competing" patches to fix the BUG that HAProxy > does not set the `Vary` response header when the compression filter is > applied. When not setting the `Vary` header the

Re: [PATCH 0/1] compression: Set Vary: Accept-Encoding

2019-06-13 Thread Tim Düsterhus
Willy, Am 13.06.19 um 17:26 schrieb Willy Tarreau: > On Wed, Jun 12, 2019 at 10:36:51PM +0200, Tim Duesterhus wrote: >> Willy, >> >> First things first: >> >> Yes, I'm aware that this is shortly before 2.0. Either put this into 2.0 >> or put this into `next` if you consider it too risky (or just

Re: [PATCH 0/1] compression: Set Vary: Accept-Encoding

2019-06-13 Thread Willy Tarreau
Hi Tim, On Wed, Jun 12, 2019 at 10:36:51PM +0200, Tim Duesterhus wrote: > Willy, > > First things first: > > Yes, I'm aware that this is shortly before 2.0. Either put this into 2.0 > or put this into `next` if you consider it too risky (or just wait until > 2.0 release before merging). I had

[PATCH 0/1] compression: Set Vary: Accept-Encoding

2019-06-12 Thread Tim Duesterhus
Willy, First things first: Yes, I'm aware that this is shortly before 2.0. Either put this into 2.0 or put this into `next` if you consider it too risky (or just wait until 2.0 release before merging). Also *add backporting instructions*, please. I recommend to backport it to 2.0 at the least.