Re: [PATCH v2] BUG/MINOR: contrib/prometheus-exporter: decode parameter and value only

2019-11-27 Thread William Dauchy
On Wed, Nov 27, 2019 at 02:30:31PM +0100, Christopher Faulet wrote: > It was merged. I amended your patch to fix 2 issues. The fixes were minor, > so I preferred to not bother you with that. First, when the scope value is > tested, we must first be sure it is defined to not dereference a null >

Re: [PATCH v2] BUG/MINOR: contrib/prometheus-exporter: decode parameter and value only

2019-11-27 Thread Christopher Faulet
Le 26/11/2019 à 12:56, William Dauchy a écrit : we were decoding all substring and then parsing; this could lead to consider & and = in decoding result as delimiters where it should not. this patch reverses the order by first parsing and then decoding each key and value separately. we also stop

[PATCH v2] BUG/MINOR: contrib/prometheus-exporter: decode parameter and value only

2019-11-26 Thread William Dauchy
we were decoding all substring and then parsing; this could lead to consider & and = in decoding result as delimiters where it should not. this patch reverses the order by first parsing and then decoding each key and value separately. we also stop parsing after number sign (#). This patch should