Re: [PATCH] BUG/MEDIUM: pollers/kqueue: use incremented position in event list
On Fri, May 11, 2018 at 02:09:43PM +0200, Willy Tarreau wrote: > Hi guys, > > On Fri, May 11, 2018 at 01:57:10PM +0200, Olivier Houchard wrote: > > Hi Pieter, > > > > On Thu, May 10, 2018 at 01:12:40AM +0200, PiBa-NL wrote: > > > Hi Olivier, > > > > > > Please take a look at attached patch. When adding 2 fd's the second > > > overwrote the first one. > > > Tagged it medium as haproxy just didn't work at all. (with kqueue.). > > > Though > > > it could perhaps also be minor, as the commit has only been done > > > recently.?. > > > Anyhow.. This seems to fix it :). Tried to go with a 'int reference > > > pointer' > > > but couldn't find the best syntax to do it that way, and this seems clean > > > enough as well.. Though if you think a different approach (thread local > > > int > > > ?) or any other way is better please change it or advice :) > > > > > > > Oops you're right, I'm an idiot, > > Why did you think you where hired ? :-) > I thought it was because I was good looking, but that may actually prove your point. > > I think your patch is fine, Willy can you please commit it ? > > Sure, now done. Thanks! Thanks ! Olivier
Re: [PATCH] BUG/MEDIUM: pollers/kqueue: use incremented position in event list
Hi guys, On Fri, May 11, 2018 at 01:57:10PM +0200, Olivier Houchard wrote: > Hi Pieter, > > On Thu, May 10, 2018 at 01:12:40AM +0200, PiBa-NL wrote: > > Hi Olivier, > > > > Please take a look at attached patch. When adding 2 fd's the second > > overwrote the first one. > > Tagged it medium as haproxy just didn't work at all. (with kqueue.). Though > > it could perhaps also be minor, as the commit has only been done recently.?. > > Anyhow.. This seems to fix it :). Tried to go with a 'int reference pointer' > > but couldn't find the best syntax to do it that way, and this seems clean > > enough as well.. Though if you think a different approach (thread local int > > ?) or any other way is better please change it or advice :) > > > > Oops you're right, I'm an idiot, Why did you think you where hired ? :-) > I think your patch is fine, Willy can you please commit it ? Sure, now done. Thanks! Willy
Re: [PATCH] BUG/MEDIUM: pollers/kqueue: use incremented position in event list
Hi Pieter, On Thu, May 10, 2018 at 01:12:40AM +0200, PiBa-NL wrote: > Hi Olivier, > > Please take a look at attached patch. When adding 2 fd's the second > overwrote the first one. > Tagged it medium as haproxy just didn't work at all. (with kqueue.). Though > it could perhaps also be minor, as the commit has only been done recently.?. > Anyhow.. This seems to fix it :). Tried to go with a 'int reference pointer' > but couldn't find the best syntax to do it that way, and this seems clean > enough as well.. Though if you think a different approach (thread local int > ?) or any other way is better please change it or advice :) > Oops you're right, I'm an idiot, I think your patch is fine, Willy can you please commit it ? Thanks ! Olivier
