Re: [PATCH] BUG/MINOR: when master-worker is in daemon mode, detach from tty

2017-12-02 Thread Willy Tarreau
On Sat, Dec 02, 2017 at 01:53:14PM +0100, William Lallemand wrote: > I made a few comments inside the patch. thanks for the review, I've applied it according to your comments. Willy

Re: [PATCH] BUG/MINOR: when master-worker is in daemon mode, detach from tty

2017-12-02 Thread William Lallemand
On Wed, Nov 29, 2017 at 10:26:06PM +0100, PiBa-NL wrote: > Hi William, > Hi, > FDs for the master-worker pipe can still be 0 and 1 if running in quiet > mode as the stdin/stdout/stderr are still closed before creating the > pipe then. Should the pipe be created earlier? Well, thinking about

Re: [PATCH] BUG/MINOR: when master-worker is in daemon mode, detach from tty

2017-11-29 Thread PiBa-NL
Hi William, When you have time, please take a look below & attached :) . Op 29-11-2017 om 1:28 schreef William Lallemand: Hi Pieter, diff --git a/src/haproxy.c b/src/haproxy.c index c3c8281..a811577 100644 --- a/src/haproxy.c +++ b/src/haproxy.c @@ -2648,6 +2648,13 @@ int main(int argc, char

Re: [PATCH] BUG/MINOR: when master-worker is in daemon mode, detach from tty

2017-11-28 Thread William Lallemand
On Wed, Nov 29, 2017 at 12:05:43AM +0100, PiBa-NL wrote: > Hi List, > Hi Pieter, > Made a patch that makes the master-worker detach from tty when it is > also combined with daemon mode to allow a script to start haproxy with > daemon mode, closing stdout so the calling process knows when to