Re: [PATCH] BUILD: common: Add __ha_cas_dw fallback for single threaded builds

2019-05-12 Thread Chris Packham
On 12/05/19 5:29 AM, Willy Tarreau wrote: > On Fri, May 10, 2019 at 11:52:31AM +0200, Willy Tarreau wrote: >>> Actually I think there's an additional change needed in my patch. By >>> passing the parameters to HA_ATOMIC_CAS we end up attempting to >>> dereference a void *. So this should needs to

Re: [PATCH] BUILD: common: Add __ha_cas_dw fallback for single threaded builds

2019-05-11 Thread Willy Tarreau
On Fri, May 10, 2019 at 11:52:31AM +0200, Willy Tarreau wrote: > > Actually I think there's an additional change needed in my patch. By > > passing the parameters to HA_ATOMIC_CAS we end up attempting to > > dereference a void *. So this should needs to cast to a proper type. For > > what it's

Re: [PATCH] BUILD: common: Add __ha_cas_dw fallback for single threaded builds

2019-05-10 Thread Willy Tarreau
On Fri, May 10, 2019 at 09:38:08AM +, Chris Packham wrote: > On 10/05/19 8:57 PM, Willy Tarreau wrote: > > On Thu, May 09, 2019 at 05:07:40PM +1200, Chris Packham wrote: > >> __ha_cas_dw() is used in fd_rm_from_fd_list() and when built without > >> USE_THREADS=1 the linker fails to find

Re: [PATCH] BUILD: common: Add __ha_cas_dw fallback for single threaded builds

2019-05-10 Thread Chris Packham
On 10/05/19 8:57 PM, Willy Tarreau wrote: > On Thu, May 09, 2019 at 05:07:40PM +1200, Chris Packham wrote: >> __ha_cas_dw() is used in fd_rm_from_fd_list() and when built without >> USE_THREADS=1 the linker fails to find __ha_cas_dw(). Add a definition >> of __ha_cas_dw() for the #ifndef

Re: [PATCH] BUILD: common: Add __ha_cas_dw fallback for single threaded builds

2019-05-10 Thread Willy Tarreau
On Thu, May 09, 2019 at 05:07:40PM +1200, Chris Packham wrote: > __ha_cas_dw() is used in fd_rm_from_fd_list() and when built without > USE_THREADS=1 the linker fails to find __ha_cas_dw(). Add a definition > of __ha_cas_dw() for the #ifndef USE_THREADS case. Just found your patch, I think it's