Re: [PATCH] MINOR: Add the fc_pp_authority fetch -- authority TLV, from PROXYv2
On 8/28/19 17:19, Willy Tarreau wrote: > > Thank you Geoff. The code is pretty clean and straightforward, I've > now merged it. I'm pretty sure it will be very useful! Now you and Nils > have everything you need to finish your onloader project ;-) Great news, thanks for your help. It feels good to have contributed a modest few lines to haproxy, will sip some fine French wine to celebrate. Thanks, Geoff -- ** * * UPLEX - Nils Goroll Systemoptimierung Scheffelstraße 32 22301 Hamburg Tel +49 40 2880 5731 Mob +49 176 636 90917 Fax +49 40 42949753 http://uplex.de signature.asc Description: OpenPGP digital signature
Re: [PATCH] MINOR: Add the fc_pp_authority fetch -- authority TLV, from PROXYv2
On Tue, Aug 27, 2019 at 06:31:16PM +0200, Geoff Simmons wrote: > Save the authority TLV in a PROXYv2 header from the client connection, > if present, and make it available as fc_pp_authority. > > The fetch can be used, for example, to set the SNI for a backend TLS > connection. Thank you Geoff. The code is pretty clean and straightforward, I've now merged it. I'm pretty sure it will be very useful! Now you and Nils have everything you need to finish your onloader project ;-) Cheers, Willy
Re: [PATCH] MINOR: Add the fc_pp_authority fetch -- authority TLV, from PROXYv2
This is with the fix for the misplaced #endif spotted by Emmanuel, thx again. Geoff -- ** * * UPLEX - Nils Goroll Systemoptimierung Scheffelstraße 32 22301 Hamburg Tel +49 40 2880 5731 Mob +49 176 636 90917 Fax +49 40 42949753 http://uplex.de signature.asc Description: OpenPGP digital signature
Re: [PATCH] MINOR: Add the fc_pp_authority fetch -- authority TLV from PROXYv2
On 8/27/19 18:15, Emmanuel Hocdet wrote:
>
>> @@ -630,6 +631,17 @@ int conn_recv_proxy(struct connection *conn, int flag)
>> conn->proxy_netns = ns;
>> break;
>> }
>> +
>> +case PP2_TYPE_AUTHORITY: {
>
> Is inside #ifdef USE_NS
Oh, now I see it. Will fix.
Thx,
Geoff
--
** * * UPLEX - Nils Goroll Systemoptimierung
Scheffelstraße 32
22301 Hamburg
Tel +49 40 2880 5731
Mob +49 176 636 90917
Fax +49 40 42949753
http://uplex.de
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] MINOR: Add the fc_pp_authority fetch -- authority TLV from PROXYv2
Hi Geoff,
For:
>
> @@ -630,6 +631,17 @@ int conn_recv_proxy(struct connection *conn, int flag)
> conn->proxy_netns = ns;
> break;
> }
> +
> + case PP2_TYPE_AUTHORITY: {
Is inside #ifdef USE_NS
It work for me, with the #ifdef fix.
Thanks
Manu
