On Tue, Apr 21, 2020 at 04:36:55PM +0200, Tim Düsterhus wrote:
> Olivier,
>
> Am 21.04.20 um 16:34 schrieb Olivier D:
> > ;)
> > Patch updated attached.
> >
>
> Now LGTM.
>
> Reviewed-by: Tim Duesterhus
Thanks guys, now applied.
Olivier, I noticed something strange, your patch was produced
On Tue, Apr 21, 2020 at 12:56:51PM +0200, Tim Düsterhus wrote:
> PS: Personal opinion, but I prefer quotes in replies to be shortened as
> much as possible, while still providing context. I don't want to scroll
> through kilobytes of stuff I've already seen :-)
Rest assured it's a shared opinion,
Hi,
Le mar. 21 avr. 2020 à 12:56, Tim Düsterhus a écrit :
> Olivier,
>
> PS: Personal opinion, but I prefer quotes in replies to be shortened as
> much as possible, while still providing context. I don't want to scroll
> through kilobytes of stuff I've already seen :-)
>
;)
Patch updated
Olivier,
Am 21.04.20 um 09:37 schrieb Olivier D:
> Thank you for your valuable feedback. Find attached a new patch will all
> your comments taken into account.
>
I've missed two more little things during my initial review:
1. The Subject of the patch should start with "DOC:" instead of
Hello,
Le lun. 20 avr. 2020 à 20:37, Tim Düsterhus a écrit :
> Olivier,
>
> Am 20.04.20 um 20:03 schrieb Olivier D:
> > I'm using gmail so I add to attach patches and was not able to send them
> > directly. If format is wrong, tell me :)
> >
>
> Format looks good to me. Your commit message
Olivier,
Am 20.04.20 um 20:03 schrieb Olivier D:
> I'm using gmail so I add to attach patches and was not able to send them
> directly. If format is wrong, tell me :)
>
Format looks good to me. Your commit message however does not (fully)
follow the instructions within the CONTRIBUTING file
6 matches
Mail list logo
