Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

[Frederic Lecaille]

On 07/13/2018 10:17 AM, Илья Шипицин wrote:



пт, 13 июл. 2018 г. в 13:08, Frederic Lecaille >:


On 07/13/2018 09:53 AM, Илья Шипицин wrote:
 > sorry, I did not test it on centos 7
 >
 > https://gitlab.com/chipitsine/haproxy/-/jobs/81501288
 >
 >
 > (I could not find out what's that, error message is strange, I'll
try to
 > investigate on separate vm)
 >
 > чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille
mailto:flecai...@haproxy.com>
 > >>:
 >
 >     This is a patch to fix the issue reported by Ilya Shipitsin
in this
 >     thread.
 >
 >     Fred.
 >

This is becoming boring. This is why we should not use external
programs
like curl. We will perhaps have to disable this vtc file.



once CI is up and running it will not be boring anymore.


Try one of these patches with a preference for reg-tests.2.diff.


I confirm test is green now



Thank you for your good job Ilya.

Regards.

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

[Илья Шипицин]

пт, 13 июл. 2018 г. в 13:08, Frederic Lecaille :

> On 07/13/2018 09:53 AM, Илья Шипицин wrote:
> > sorry, I did not test it on centos 7
> >
> > https://gitlab.com/chipitsine/haproxy/-/jobs/81501288
> >
> >
> > (I could not find out what's that, error message is strange, I'll try to
> > investigate on separate vm)
> >
> > чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille  > >:
> >
> > This is a patch to fix the issue reported by Ilya Shipitsin in this
> > thread.
> >
> > Fred.
> >
>
> This is becoming boring. This is why we should not use external programs
> like curl. We will perhaps have to disable this vtc file.
>


once CI is up and running it will not be boring anymore.


>
> Try one of these patches with a preference for reg-tests.2.diff.
>

I confirm test is green now


>
> They both work on my linux host with curl 7.38.0.
>
>

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

[Frederic Lecaille]

On 07/13/2018 09:53 AM, Илья Шипицин wrote:

sorry, I did not test it on centos 7

https://gitlab.com/chipitsine/haproxy/-/jobs/81501288


(I could not find out what's that, error message is strange, I'll try to 
investigate on separate vm)


чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille >:


This is a patch to fix the issue reported by Ilya Shipitsin in this
thread.

Fred.



This is becoming boring. This is why we should not use external programs 
like curl. We will perhaps have to disable this vtc file.


Try one of these patches with a preference for reg-tests.2.diff.

They both work on my linux host with curl 7.38.0.

diff --git a/reg-tests/ssl/h0.vtc b/reg-tests/ssl/h0.vtc
index 819f385..d1b48fb 100644
--- a/reg-tests/ssl/h0.vtc
+++ b/reg-tests/ssl/h0.vtc
@@ -34,7 +34,7 @@ haproxy h1 -conf {
 shell {
 HOST=${h1_frt_addr}
 if [ "${h1_frt_addr}" = "::1" ] ; then
-HOST="[::1]"
+HOST="\[::1\]"
 fi
 for i in 1 2 3 4 5; do
 curl -i -k https://$HOST:${h1_frt_port} & pids="$pids $!"
diff --git a/reg-tests/ssl/h0.vtc b/reg-tests/ssl/h0.vtc
index 819f385..5239c53 100644
--- a/reg-tests/ssl/h0.vtc
+++ b/reg-tests/ssl/h0.vtc
@@ -37,7 +37,7 @@ shell {
 HOST="[::1]"
 fi
 for i in 1 2 3 4 5; do
-curl -i -k https://$HOST:${h1_frt_port} & pids="$pids $!"
+curl -gi -k https://$HOST:${h1_frt_port} & pids="$pids $!"
 done
 wait $pids
 }

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

[Илья Шипицин]

sorry, I did not test it on centos 7

https://gitlab.com/chipitsine/haproxy/-/jobs/81501288


(I could not find out what's that, error message is strange, I'll try to
investigate on separate vm)

чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille :

> This is a patch to fix the issue reported by Ilya Shipitsin in this thread.
>
> Fred.
>

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

[Willy Tarreau]

On Thu, Jul 12, 2018 at 11:05:30AM +0200, Frederic Lecaille wrote:
> This is a patch to fix the issue reported by Ilya Shipitsin in this thread.

Applied, thank you Fred.

Willy