Re: [PATCH 4/5] [MEDIUM] default-server support
On 2010-01-07 00:37, Willy Tarreau wrote: Hi Krzysztof, On Wed, Jan 06, 2010 at 10:26:05AM +0100, Krzysztof Ol?dzki wrote: How about adding Supported in default-server: Yes/No into each keyword? It's OK for me. I've merged your 3 patches, including the one which did this change. This should show up in this night's snapshot. Thanks. Best regards, Krzysztof Olędzki
Re: [PATCH 4/5] [MEDIUM] default-server support
On 2010-01-06 00:44, Willy Tarreau wrote: Hi Krzysztof, Hi Willy, I've merged all of your patches. Thanks. However I have a minor concern about something in this one : -The currently supported settings are the following ones. +The currently supported settings are the following ones, the ones marked with +[D] are also upported for default-server. (...) -error-limit count +[D] error-limit count (...) -fall count +[D] fall count etc... While I understand the reason you have added this tag, it breaks the ability to search a keyword at the beginning of line using ^error-limit. Maybe we should put the tag at the end of the line (77th to 79th chars) or maybe we should simply suggest that everything is supported in defaults except those explicitly stated otherwise, and just add a one line comment for those keywords not supported in default-server ? How about adding Supported in default-server: Yes/No into each keyword? If you get a nice idea on this subject, feel free to send a patch for it. If you do so, please also add the following hunk that I wanted to fix but forgot at the last minute : diff --git a/doc/configuration.txt b/doc/configuration.txt index eaec73b..c6cfa98 100644 --- a/doc/configuration.txt +++ b/doc/configuration.txt @@ -724,7 +724,7 @@ capture response header - X X - clitimeout X X X - (deprecated) contimeout X - X X (deprecated) cookie X - X X -default-server X - X - +default-server X - X X default_backend - X X - description - X X X disabledX X X X Sure. I have no idea why I did it wrong. :| Best regards, Krzysztof Olędzki
Re: [PATCH 4/5] [MEDIUM] default-server support
Hi Krzysztof, I've merged all of your patches. However I have a minor concern about something in this one : -The currently supported settings are the following ones. +The currently supported settings are the following ones, the ones marked with +[D] are also upported for default-server. (...) -error-limit count +[D] error-limit count (...) -fall count +[D] fall count etc... While I understand the reason you have added this tag, it breaks the ability to search a keyword at the beginning of line using ^error-limit. Maybe we should put the tag at the end of the line (77th to 79th chars) or maybe we should simply suggest that everything is supported in defaults except those explicitly stated otherwise, and just add a one line comment for those keywords not supported in default-server ? If you get a nice idea on this subject, feel free to send a patch for it. If you do so, please also add the following hunk that I wanted to fix but forgot at the last minute : diff --git a/doc/configuration.txt b/doc/configuration.txt index eaec73b..c6cfa98 100644 --- a/doc/configuration.txt +++ b/doc/configuration.txt @@ -724,7 +724,7 @@ capture response header - X X - clitimeout X X X - (deprecated) contimeout X - X X (deprecated) cookie X - X X -default-server X - X - +default-server X - X X default_backend - X X - description - X X X disabledX X X X Thanks ! Willy
