Re: [PATCH v2 2/3] MINOR: config: allow no set-dumpable config option

2019-10-29 Thread Willy Tarreau
On Tue, Oct 29, 2019 at 09:36:56AM +, William Dauchy wrote: > On Tue, Oct 29, 2019 at 06:57:44AM +0100, Willy Tarreau wrote: > > Here are the adjustments I'm proposing (only 2 and 3 were slightly > > touched). I'm not committing them without your consent since they > > were signed-off :-) Just

Re: [PATCH v2 2/3] MINOR: config: allow no set-dumpable config option

2019-10-29 Thread William Dauchy
On Tue, Oct 29, 2019 at 06:57:44AM +0100, Willy Tarreau wrote: > Here are the adjustments I'm proposing (only 2 and 3 were slightly > touched). I'm not committing them without your consent since they > were signed-off :-) Just let me know. :-) the new diff looks good to me Thanks, -- William

Re: [PATCH v2 2/3] MINOR: config: allow no set-dumpable config option

2019-10-29 Thread William Dauchy
On Tue, Oct 29, 2019 at 06:40:23AM +0100, Willy Tarreau wrote: > I'm taking the patchset. However I'll apply some small changes : > > On Sun, Oct 27, 2019 at 08:08:10PM +0100, William Dauchy wrote: > > in global config parsing, we currently expect to have a possible no > > keyword (KWN_NO), but

Re: [PATCH v2 2/3] MINOR: config: allow no set-dumpable config option

2019-10-28 Thread Willy Tarreau
Here are the adjustments I'm proposing (only 2 and 3 were slightly touched). I'm not committing them without your consent since they were signed-off :-) Just let me know. Thanks, Willy >From 7f36164b38965c4c8a8df8d5aadbc31cafd39986 Mon Sep 17 00:00:00 2001 From: William Dauchy Date: Sun, 27 Oct

Re: [PATCH v2 2/3] MINOR: config: allow no set-dumpable config option

2019-10-28 Thread Willy Tarreau
Hi William, I'm taking the patchset. However I'll apply some small changes : On Sun, Oct 27, 2019 at 08:08:10PM +0100, William Dauchy wrote: > in global config parsing, we currently expect to have a possible no > keyword (KWN_NO), but we never allow it in config parsing. > another patch could