RE: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch
Thank you William. Appreciate you taking the time to fix all the discrepancies in my patch. Have a good rest of your day. Regards, Mariam. From: William Lallemand Date: Tuesday, January 9, 2024 at 5:05 AM To: Mariam John , Willy Tarreau Cc: Mariam John , haproxy@formilux.org , eb...@haproxy.com Subject: [EXTERNAL] Re: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch On 2024-01-08 21:01, Mariam John wrote: > > Thank you Willy for the update. Appreciate it. Please take your time. > I totally understand. Just wanted to make sure it wasn’t lost or > forgotten about. > > Thank you once again. > > Regards, > > Mariam. > Hello Mariam, Thank you for your contribution, I merged your patch with some small changes: - aligned the git commit message to 80 columns - removed the "BUG" tag in the subject since this is not a bug - moved back the nid variable because in C90 you can't mix declaration and code, but added __maybe_unused to avoid the warning. This will be backported in 2.8. I missed the alignment and indentation in your first contribution, in HAProxy we are using tabs for indentation and spaces for alignment, so I made a cleanup patch to switch to tabs. Regards, -- William Lallemand
Re: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch
On 2024-01-08 21:01, Mariam John wrote: Thank you Willy for the update. Appreciate it. Please take your time. I totally understand. Just wanted to make sure it wasn’t lost or forgotten about. Thank you once again. Regards, Mariam. Hello Mariam, Thank you for your contribution, I merged your patch with some small changes: - aligned the git commit message to 80 columns - removed the "BUG" tag in the subject since this is not a bug - moved back the nid variable because in C90 you can't mix declaration and code, but added __maybe_unused to avoid the warning. This will be backported in 2.8. I missed the alignment and indentation in your first contribution, in HAProxy we are using tabs for indentation and spaces for alignment, so I made a cleanup patch to switch to tabs. Regards, -- William Lallemand
Re: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch
On Mon, Jan 08, 2024 at 08:01:07PM +, Mariam John wrote: > Thank you Willy for the update. Appreciate it. Please take your time. I > totally understand. Just wanted to make sure it wasn't lost or forgotten > about. I knew you would naturally start to worry about it, I even mentioned it in the 3.0-dev1 announce in the pending stuff section :-) But yeah, not lost! Cheers, Willy
RE: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch
Thank you Willy for the update. Appreciate it. Please take your time. I totally understand. Just wanted to make sure it wasn’t lost or forgotten about. Thank you once again. Regards, Mariam. From: Willy Tarreau Date: Monday, January 8, 2024 at 1:25 PM To: Mariam John Cc: Mariam John , haproxy@formilux.org , eb...@haproxy.com , wlallem...@haproxy.com Subject: [EXTERNAL] Re: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch Hi Mariam, On Mon, Jan 08, 2024 at 02:40:22PM +, Mariam John wrote: > Happy new year!! Just wanted to see if this patch could move forward. I have > made the changes recommended by William. Yeah, we spoke about it this morning with William, he's still unpiling his mailbox :-) Rest assured it's not lost nor forgotten, I'm just unable to validate it and need to rely on his expertise for this. Thanks for your patience! Willy
Re: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch
Hi Mariam, On Mon, Jan 08, 2024 at 02:40:22PM +, Mariam John wrote: > Happy new year!! Just wanted to see if this patch could move forward. I have > made the changes recommended by William. Yeah, we spoke about it this morning with William, he's still unpiling his mailbox :-) Rest assured it's not lost nor forgotten, I'm just unable to validate it and need to rely on his expertise for this. Thanks for your patience! Willy
Re: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch
Happy new year!! Just wanted to see if this patch could move forward. I have made the changes recommended by William. Thank you for your time. Regards, Mariam. From: Mariam John Date: Friday, December 29, 2023 at 11:20 AM To: haproxy@formilux.org Cc: eb...@haproxy.com , wlallem...@haproxy.com , Mariam John Subject: [EXTERNAL] [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch Update ssl_fc_curve/ssl_fc_curve to use `SSL_get0_group_name` function (available from the OpenSSL v3.2 release onwards) to get the curve name. For OpenSSL versions >=3.0 and <3.2, we will continue to use `SSL_get_negotiated_group` to get the curve name. Mariam John (1): BUG/MINOR: ssl: Update ssl_fc_curve/ssl_bc_curve to use SSL_get0_group_name src/ssl_sample.c | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) -- 2.39.2 (Apple Git-143)
Re: [PATCH 0/1] Update ssl_fc_curve/ssl_bc_curve sample fetch
On 2023-12-20 06:21, Mariam John wrote: Update ssl_fc_curve/ssl_fc_curve to use `SSL_get0_group_name` function (available from the OpenSSL v3.2 release onwards) to get the curve name. For OpenSSL versions >=3.0 and <3.2, we will continue to use `SSL_get_negotiated_group` to get the curve name. Mariam John (1): BUG/MINOR: ssl: Update ssl_fc_curve/ssl_bc_curve to use SSL_get0_group_name reg-tests/ssl/ssl_curve_name.vtc | 4 ++-- src/ssl_sample.c | 33 +++- 2 files changed, 30 insertions(+), 7 deletions(-) Hello Mariam, I'm fine with the SSL_get0_group_name() change, however if it introduces a change of behavior I can't get this backported in stable branches. It's probably better if you do it the other way, keeping the format from SSL_get_negotiated_group() while using SSL_get0_group_name() so people don't have surprises when upgrading their OpenSSL. Regards, -- William Lallemand
