Re: BUG/MAJOR: dns: overflowed dns name start position causing invalid dns error

2018-12-21 Thread Willy Tarreau
On Fri, Dec 21, 2018 at 04:17:20PM +0530, Nikhil Agrawal wrote: > Great, Thanks . > > May you backport the fix to 1.7 too? Sure, that's why I added the info at the end of the commit message. Willy

Re: BUG/MAJOR: dns: overflowed dns name start position causing invalid dns error

2018-12-21 Thread Nikhil Agrawal
Great, Thanks . May you backport the fix to 1.7 too? On Fri, Dec 21, 2018 at 4:07 PM Willy Tarreau wrote: > On Fri, Dec 21, 2018 at 03:40:53PM +0530, Nikhil Agrawal wrote: > > Hi Willy, > > > > Thanks for response and correcting the mistake. > > > > Its OK for you to fix this. > > marking this

Re: BUG/MAJOR: dns: overflowed dns name start position causing invalid dns error

2018-12-21 Thread Willy Tarreau
On Fri, Dec 21, 2018 at 03:40:53PM +0530, Nikhil Agrawal wrote: > Hi Willy, > > Thanks for response and correcting the mistake. > > Its OK for you to fix this. > marking this as MEDIUM is also fine :). OK thanks, now merged. It will be included into next 1.8 ASAP. Willy

Re: BUG/MAJOR: dns: overflowed dns name start position causing invalid dns error

2018-12-21 Thread Nikhil Agrawal
Hi Willy, Thanks for response and correcting the mistake. Its OK for you to fix this. marking this as MEDIUM is also fine :). Regards, Nikhil Agrawal On Fri, Dec 21, 2018 at 2:58 PM Willy Tarreau wrote: > Hi, > > On Fri, Dec 21, 2018 at 11:02:24AM +0530, Nikhil Agrawal wrote: > > Dear

Re: BUG/MAJOR: dns: overflowed dns name start position causing invalid dns error

2018-12-21 Thread Willy Tarreau
Hi, On Fri, Dec 21, 2018 at 11:02:24AM +0530, Nikhil Agrawal wrote: > Dear Haproxy Maintainers, > > In dns_read_name() when dns name is used with name compression and start > position of name is greater than 255, name is read from incorrect position > ( actual position%256). This causes "Invalid