Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Willy Tarreau
On Sat, Dec 21, 2019 at 01:19:30AM +0100, Lukas Tribus wrote: > You can merge the patch I posted today, as there is consensus for this > particular fix: > https://www.mail-archive.com/haproxy@formilux.org/msg35760.html > > It should be backported to 2.0 (or even 1.9 - I forgot to mention that >

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Lukas Tribus
Hello, > Guys, I must confess I'm completely lost in your discussions. I intend > to produce another round of 2.1 and 2.0 tomorrow as time permits, so if > you want me to get anything merged into it, please let me know. Lukas, > I'll count on you to summarize and suggest what's expected from me

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Willy Tarreau
Guys, I must confess I'm completely lost in your discussions. I intend to produce another round of 2.1 and 2.0 tomorrow as time permits, so if you want me to get anything merged into it, please let me know. Lukas, I'll count on you to summarize and suggest what's expected from me to do at this

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Илья Шипицин
сб, 21 дек. 2019 г. в 01:44, Rosen Penev : > On Fri, Dec 20, 2019 at 10:54 AM Илья Шипицин > wrote: > > > > > > > > пт, 20 дек. 2019 г. в 22:39, Lukas Tribus : > >> > >> Hello Ilya, > >> > >> > >> > >> sorry about the delay ... > >> > >> > >> On Wed, 27 Nov 2019 at 07:11, Илья Шипицин > wrote:

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Rosen Penev
On Fri, Dec 20, 2019 at 10:54 AM Илья Шипицин wrote: > > > > пт, 20 дек. 2019 г. в 22:39, Lukas Tribus : >> >> Hello Ilya, >> >> >> >> sorry about the delay ... >> >> >> On Wed, 27 Nov 2019 at 07:11, Илья Шипицин wrote: >> > >> > -#if (HA_OPENSSL_VERSION_NUMBER >= 0x101fL) >> > +#if

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Илья Шипицин
пт, 20 дек. 2019 г. в 22:39, Lukas Tribus : > Hello Ilya, > > > > sorry about the delay ... > > > On Wed, 27 Nov 2019 at 07:11, Илья Шипицин wrote: > > > > -#if (HA_OPENSSL_VERSION_NUMBER >= 0x101fL) > > +#if (HA_OPENSSL_VERSION_NUMBER >= 0x101fL) || > defined(OPENSSL_NO_DEPRECATED) > >

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-12-20 Thread Lukas Tribus
Hello Ilya, sorry about the delay ... On Wed, 27 Nov 2019 at 07:11, Илья Шипицин wrote: > > -#if (HA_OPENSSL_VERSION_NUMBER >= 0x101fL) > +#if (HA_OPENSSL_VERSION_NUMBER >= 0x101fL) || > defined(OPENSSL_NO_DEPRECATED) > [...] > -#if defined(USE_THREAD) && (HA_OPENSSL_VERSION_NUMBER

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-27 Thread Emmanuel Hocdet
Hi, > Le 27 nov. 2019 à 03:46, Willy Tarreau a écrit : > >> @@ -5046,7 +5046,9 @@ int ssl_sock_prepare_ctx(struct bind_conf *bind_conf, >> struct ssl_bind_conf *ssl_ >> NULL); >> >> if (ecdhe == NULL) { >> +#if defined(SSL_CTX_set_ecdh_auto) >>

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-26 Thread Илья Шипицин
ср, 27 нояб. 2019 г. в 05:02, Lukas Tribus : > Hello, > > On Tue, Nov 26, 2019 at 10:50 PM Илья Шипицин > wrote: > > > > Hello, > > > > I resolved `CRYPTO_set_id_callback', `ERR_remove_state', > `SSL_CTX_set_ecdh_auto' issues. > > > > > > the following two will be addressed later:

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-26 Thread Willy Tarreau
On Wed, Nov 27, 2019 at 01:02:25AM +0100, Lukas Tribus wrote: > Hello, > > On Tue, Nov 26, 2019 at 10:50 PM ??? wrote: > > > > Hello, > > > > I resolved `CRYPTO_set_id_callback', `ERR_remove_state', > > `SSL_CTX_set_ecdh_auto' issues. > > > > > > the following two will be addressed

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-26 Thread Willy Tarreau
Hi Ilya, On Wed, Nov 27, 2019 at 02:50:18AM +0500, ??? wrote: > Hello, > > I resolved `CRYPTO_set_id_callback', `ERR_remove_state', > `SSL_CTX_set_ecdh_auto' issues. Great, thanks! I'm seeing some minor cosmetic details: > @@ -5046,7 +5046,9 @@ int ssl_sock_prepare_ctx(struct

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-26 Thread Lukas Tribus
Hello, On Tue, Nov 26, 2019 at 10:50 PM Илья Шипицин wrote: > > Hello, > > I resolved `CRYPTO_set_id_callback', `ERR_remove_state', > `SSL_CTX_set_ecdh_auto' issues. > > > the following two will be addressed later: `X509_get_notBefore', > `X509_get_notAfter' I'm not sure if matching

Re: PATCH: partially fix build if OpenSSL is built with no-deprecated option

2019-11-26 Thread Tim Düsterhus
Ilya, I can't comment about the patch itself, but wanted to comment about the commit message. Am 26.11.19 um 22:50 schrieb Илья Шипицин: > Subject: [PATCH] CLEANUP: partially resolve #367 I believe this should be the 'BUILD' tag instead of CLEANUP. And I also recommend to give a more