Hi Cyril,
On Mon, Nov 30, 2009 at 12:53:34AM +0100, Cyril Bonté wrote:
Could you please check on your side and confirm/infirm my doubts ?
Basically I want to ensure we never dereference the buffer past its
end, so begin+len bust always be below the buffer size. If you think
a control is
On Tue, Nov 17, 2009 at 11:25:56PM +0100, Aleksandar Lazic wrote:
And for now, I see 2 modes :
- path-parameters (the default)
- query-string (the one that made me look at the code :-) )
(and if needed weblogic)
Looks ok for me.
What I'am not sure now is how we can prevent that
On Mon 16.11.2009 08:52, Willy Tarreau wrote:
Hi,
On Sun, Nov 15, 2009 at 10:28:21PM +0100, Aleksandar Lazic wrote:
Hi Cyril,
On Fre 13.11.2009 22:50, Cyril Bonté wrote:
Hello Willy,
[snipp]
First I added it as I did for request-learn but shouldn't it be
better to define these options
On Mon, Nov 16, 2009 at 10:08:56AM +0100, Aleksandar Lazic wrote:
What you can do however is to create a new prefix keyword like we have
for timeout or tcp-request and put the flags somewhere
else. appsession would have been fine but it's already used. Maybe
you can use appcookie ? Something
On Mon, Nov 16, 2009 at 01:04:17PM +0100, Aleksandar Lazic wrote:
(...)
app* delimiterstart (default ;)
app* delimiterstop (defautl =)
I'm sorry, I don't understand what you mean. Could you give an example
of configuration using this ?
For example:
if in the url the delimiter changes
Hi Cyril,
On Fre 13.11.2009 22:50, Cyril Bonté wrote:
Hello Willy,
sorry, I didn't have time to work on the patch as I wanted.
Le jeudi 5 novembre 2009 06:19:41, Willy Tarreau a écrit :
Sorry but I can't see in the haproxy sources how the cookie prefix can be
used for appsession.
capture
Hi,
On Sun, Nov 15, 2009 at 10:28:21PM +0100, Aleksandar Lazic wrote:
Hi Cyril,
On Fre 13.11.2009 22:50, Cyril Bonté wrote:
Hello Willy,
sorry, I didn't have time to work on the patch as I wanted.
Le jeudi 5 novembre 2009 06:19:41, Willy Tarreau a écrit :
Sorry but I can't see in the
Hello Willy,
sorry, I didn't have time to work on the patch as I wanted.
Le jeudi 5 novembre 2009 06:19:41, Willy Tarreau a écrit :
Sorry but I can't see in the haproxy sources how the cookie prefix can be
used for appsession.
capture cookie allows to find this cookie prefix but it seems
Hi Cyril,
On Sun, Nov 01, 2009 at 12:19:05AM +0100, Cyril Bonté wrote:
Hello Willy and Aleksandar,
If you agree, I would like to apply this new patch to add some more integrity
checking on appsession.
* the session value (provided by the URL or by the request/response cookie)
is now well
Le lundi 2 novembre 2009 12:09:43, Willy Tarreau a écrit :
* it adds a verification on the '=' char :
currently (with appsession JSESSIONID for example), an URL like
http://haproxy/path;jsessionidfake=0123... matches the session id
ake=0123...
= with the patch, jsessionidfake won't be
Hello Willy and Aleksandar,
If you agree, I would like to apply this new patch to add some more integrity
checking on appsession.
* the session value (provided by the URL or by the request/response cookie) is
now well delimited :
currently, setting len 52 on a 32 chars value has a bad effect on
Le dimanche 1 novembre 2009 00:19:05, Cyril Bonté a écrit :
Hello Willy and Aleksandar,
If you agree, I would like to apply this new patch to add some more integrity
checking on appsession.
Forget the previous patch file, this new one also prevents forcing the load
balancing to one server
On Thu, Oct 15, 2009 at 12:15:40AM +0200, Cyril Bonté wrote:
OK, here comes the 2 patch files for haproxy-1.3.21 and haproxy-1.4-dev4.
Please note 3 minor changes in those versions (proto_http.c / proto_http.h) :
Cyril, I have merged your two patches. I applied a very minor change,
I removed
Le dimanche 18 octobre 2009 12:05:55, Willy Tarreau a écrit :
Cyril, I have merged your two patches.
Thanks ! I'm thinking of working on a second patch.
The documentation says that appsession looks for the session in the query
string but this is not really the case. Currently, it parses the
On Tue, Oct 13, 2009 at 10:41:59PM +0200, Aleksandar Lazic wrote:
On Die 13.10.2009 21:34, Cyril Bonté wrote:
Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
Yes, you're right, I missed it after several tests on different
snapshots.
Here comes a second patch to reintroduce
On Mit 14.10.2009 21:40, Willy Tarreau wrote:
On Tue, Oct 13, 2009 at 10:41:59PM +0200, Aleksandar Lazic wrote:
On Die 13.10.2009 21:34, Cyril Bonté wrote:
Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
Yes, you're right, I missed it after several tests on different
snapshots.
On Wed, Oct 14, 2009 at 10:20:04PM +0200, Aleksandar Lazic wrote:
On Mit 14.10.2009 21:40, Willy Tarreau wrote:
On Tue, Oct 13, 2009 at 10:41:59PM +0200, Aleksandar Lazic wrote:
On Die 13.10.2009 21:34, Cyril Bonté wrote:
Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
Yes,
Le mercredi 14 octobre 2009 22:23:54, Willy Tarreau a écrit :
Cyril, care to send an updated patch with the latest changes ?
OK !
Do it for either 1.3 or 1.4, I'll do the back/forward port. If you
prefer to proceed on both, of course feel free to do so :-)
I can do both, this will let you
On Wed, Oct 14, 2009 at 10:36:49PM +0200, Cyril Bonté wrote:
Le mercredi 14 octobre 2009 22:23:54, Willy Tarreau a écrit :
Cyril, care to send an updated patch with the latest changes ?
OK !
Do it for either 1.3 or 1.4, I'll do the back/forward port. If you
prefer to proceed on both,
Le mercredi 14 octobre 2009 22:39:39, Willy Tarreau a écrit :
Do it for either 1.3 or 1.4, I'll do the back/forward port. If you
prefer to proceed on both, of course feel free to do so :-)
I can do both, this will let you work on something else ;)
Nice, I appreciate it.
OK, here
Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
Hi Cyril,
good catch.
+}
+
+/*
-#if defined(DEBUG_HASH)
-Alert(manage_client_side_cookies\n);
-
appsession_hash_dump((t-be-htbl_proxy));
-#endif
On Die 13.10.2009 21:34, Cyril Bonté wrote:
Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
Yes, you're right, I missed it after several tests on different
snapshots.
Here comes a second patch to reintroduce these debug lines :
Thanks.
22 matches
Mail list logo
