Re: enaling cache in github actions

[Tim Düsterhus]

Ilya,

On 6/8/21 3:49 PM, Илья Шипицин wrote:

Tim, maybe you have an idea how to make it work.
I gave up


Ack. I'll add it to my ToDo and I'll try to look into in in the next days.

Best regards
Tim Düsterhus

Re: enaling cache in github actions

[Илья Шипицин]

Tim, maybe you have an idea how to make it work.
I gave up

(the idea was to cache "opt" and "download-cache" folders)

enabling cache
https://github.com/chipitsine/haproxy/commit/fcb5f130c44f1efb50c2aaf1842a86c7f37f0cca

initially cache
https://github.com/chipitsine/haproxy/runs/2773929840


dumb commit to test cache (all SSL variants should be taken from cache)
https://github.com/chipitsine/haproxy/runs/2774363928

but ...

+ cat /home/runner/opt/.libressl-version
cat: /home/runner/opt/.libressl-version: No such file or directory
+ [  != 2.9.2 ]

вс, 16 мая 2021 г. в 16:59, Tim Düsterhus :

> Ilya,
>
> On 5/15/21 5:30 PM, Илья Шипицин wrote:
> > I've found that we do not cache "download-cache" and "opt" folders,
> > thus we build BoringSSL on every build (no cache).
> >
> > I tried to enable cache
> >
> >
> https://github.com/chipitsine/haproxy/blob/master/.github/workflows/vtest.yml#L46-L53
> >
> > github does not like such caching keys:
> >
> > Error: Key Validation Error: Linux-Ubuntu, gcc, no features cannot
> contain
> > commas.
> >
> >
> > Tim, do you have an idea how to fix this ?
> >
>
> I suggest the following:
>
> - Cache based off the matrix.ssl value, because that determines what
> type of SSL lib we download and build.
> - If we want to cache something else in the future, then we use a
> separate cache head for that specifically.
> - And then use `steps.XXX.outputs.cache-hit != 'true'` to check whether
> you need to build anything or not.
>
> See also: https://github.com/actions/cache#example-workflow
>
> Best regards
> Tim Düsterhus
>

Re: enaling cache in github actions

[Tim Düsterhus]

Ilya,

On 5/15/21 5:30 PM, Илья Шипицин wrote:

I've found that we do not cache "download-cache" and "opt" folders,
thus we build BoringSSL on every build (no cache).

I tried to enable cache

https://github.com/chipitsine/haproxy/blob/master/.github/workflows/vtest.yml#L46-L53

github does not like such caching keys:

Error: Key Validation Error: Linux-Ubuntu, gcc, no features cannot contain
commas.


Tim, do you have an idea how to fix this ?



I suggest the following:

- Cache based off the matrix.ssl value, because that determines what 
type of SSL lib we download and build.
- If we want to cache something else in the future, then we use a 
separate cache head for that specifically.
- And then use `steps.XXX.outputs.cache-hit != 'true'` to check whether 
you need to build anything or not.


See also: https://github.com/actions/cache#example-workflow

Best regards
Tim Düsterhus