Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-26 Thread Andrey Galkin
Hi guys, Sorry for late response. I've just tested current git master. It seems the issue is gone now. Wily, thank you for looking into the issue so close. Anticipating latest 1.6.x in official Debian/Ubuntu packages soon. Thanks, Andrey On Tue, Jun 21, 2016 at 7:50 PM, Willy Tarreau

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-22 Thread Lukas Erlacher
Yes I noticed there were more issues with the FD's. Thanks for all of your work, I will test 1.6.6 as soon as it hits vbernat's PPA. Best, Luke smime.p7s Description: S/MIME Cryptographic Signature

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-21 Thread Willy Tarreau
Hi guys, I'm replying to this thread and adding Andrey and Veiko in Cc to keep everyone up to date. On Wed, Jun 08, 2016 at 10:17:19AM +0900, Simon Horman wrote: > Lukas, could you try this? > > diff --git a/src/checks.c b/src/checks.c > index c4ac947b6051..e65d28f7c3c6 100644 > ---

[BUMP] Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-14 Thread Lukas Erlacher
BUMP The patch looks good to me and should be merged. Best, Luke On 08.06.2016 03:17, Simon Horman wrote: > On Tue, Jun 07, 2016 at 08:18:21PM +0200, Willy Tarreau wrote: >> On Tue, Jun 07, 2016 at 12:01:31PM +0200, Benoit Garnier wrote: >>> You can always open /dev/null before chrooting and

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-09 Thread Lukas Erlacher
Ah, this is fun :D Running this haproxy built from git: > erlacher@vmrbg81:~/haproxy$ sudo ./haproxy -vv > HA-Proxy version 1.7-dev3-4b788f-35 2016/06/08 > Copyright 2000-2016 Willy Tarreau > > Build options : > TARGET = linux2628 > CPU = generic > CC = gcc >

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-07 Thread Simon Horman
On Tue, Jun 07, 2016 at 08:18:21PM +0200, Willy Tarreau wrote: > On Tue, Jun 07, 2016 at 12:01:31PM +0200, Benoit Garnier wrote: > > You can always open /dev/null before chrooting and dup() it into FD 0 and 1 > > after chroot() has been called. > > I'd be more tempted to simply close those FDs

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-07 Thread Willy Tarreau
On Tue, Jun 07, 2016 at 12:01:31PM +0200, Benoit Garnier wrote: > You can always open /dev/null before chrooting and dup() it into FD 0 and 1 > after chroot() has been called. I'd be more tempted to simply close those FDs after the fork(). That may improve the ability to detect faulty scripts

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-07 Thread Benoit Garnier
You can always open /dev/null before chrooting and dup() it into FD 0 and 1 after chroot() has been called. Le 7 juin 2016 06:23:04 GMT+02:00, Simon Horman a écrit : >Hi Cyril, Hi Lukas, > >On Mon, Jun 06, 2016 at 08:21:46PM +0200, Cyril Bonté wrote: >> Hi Lukas, >> >> I

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-06 Thread Simon Horman
Hi Cyril, Hi Lukas, On Mon, Jun 06, 2016 at 08:21:46PM +0200, Cyril Bonté wrote: > Hi Lukas, > > I add Malcolm and Simon to the thread. > > Le 06/06/2016 à 08:36, Lukas Erlacher a écrit : > >Additional info: The output only ends up in the *first* client connection. > > > >Talking about this

Re: external-check stdout ends up in load-balanced traffic, destroying tcp sessions

2016-06-06 Thread Cyril Bonté
Hi Lukas, I add Malcolm and Simon to the thread. Le 06/06/2016 à 08:36, Lukas Erlacher a écrit : Additional info: The output only ends up in the *first* client connection. Talking about this with some colleagues we're now theorizing that stdout goes to fd 1 and fd 1 is also the first client