Re: Request for feedback: Add fetcher for getting all cookie names

2023-10-13 Thread Willy Tarreau
Hi Ruei-Bang,

On Fri, Oct 13, 2023 at 08:59:24PM +, Ruei-Bang Chen wrote:
> Hi team,
> 
> 
> This is related to my previous email regarding adding a fetcher for all
> headers excluding cookies, but I think it might be helpful to open a separate
> thread to discuss this alone as cookie is a special header.
> 
> We have a use-case where we need only cookie names but not their values.
> Currently, we have similar fetchers "req.hdr_names" / "res.hdr_names" for
> returning all headers, but no such fetchers for cookies.
> 
> Since we are only interested in cookie names and the cookie values can be
> pretty long sometimes, we can avoid unnecessary overhead when we want to
> store / send / parse the string variable if such fetchers are available for
> cookies.
> 
> The proposal is to add a new fetcher for extracting cookie names to reduce
> overhead in high QPS.
> 
> Let me know what you think.

I don't have any particular opinion on this one. I agree that avoiding to
retrieve the values can be useful. However, please keep in mind that the
request and response code might differ due to the different syntax in both
directions.

Anyway, as long as you think you'll be having use cases for that and
you're careful about performance and making it generic enough, I don't
see any reason for objecting to this ;-)

Thanks,
Willy



Request for feedback: Add fetcher for getting all cookie names

2023-10-13 Thread Ruei-Bang Chen
Hi team,


This is related to my previous email regarding adding a fetcher for all headers 
excluding cookies, but I think it might be helpful to open a separate thread to 
discuss this alone as cookie is a special header.

We have a use-case where we need only cookie names but not their values. 
Currently, we have similar fetchers "req.hdr_names" / "res.hdr_names" for 
returning all headers, but no such fetchers for cookies.

Since we are only interested in cookie names and the cookie values can be 
pretty long sometimes, we can avoid unnecessary overhead when we want to store 
/ send / parse the string variable if such fetchers are available for cookies.

The proposal is to add a new fetcher for extracting cookie names to reduce 
overhead in high QPS.

Let me know what you think.

Thanks,
Ruei-Bang