Re: [HarfBuzz] A problem in thai shaper

2012-04-17 Thread Jonathan Kew
On 18/4/12 02:22, Behdad Esfahbod wrote: On 04/17/2012 06:47 PM, Khaled Hosny wrote: On Tue, Apr 17, 2012 at 05:10:37AM +0200, Khaled Hosny wrote: On Mon, Apr 16, 2012 at 09:08:49PM -0400, Behdad Esfahbod wrote: Problem 2: When there is no consonant exist, the dotted circle should be inserted

Re: [HarfBuzz] harfbuzz-ng: Branch 'master' - 6 commits

2012-04-17 Thread John Daggett
> commit a5f1834f57ea3fb254f5c7d372747de316fcc8f1 > Author: Behdad Esfahbod > Date: Mon Apr 16 15:55:13 2012 -0400 > > Apply 'liga' for vertical writing mode too > > Apparently that's what Kazuraki uses to form vertical ligatures, > which suggests that it's what Adobe does. >

Re: [HarfBuzz] A problem in thai shaper

2012-04-17 Thread Martin Hosken
Dear Behdad, > >> I don't know about Thai, but the handling of "invalid" Arabic combining > >> marks in Uniscribe is completely brain dead and a real PITA and I'd > >> really like not to see HarfBuzz going there, a shaping engine is not a > >> spell checker and should not enforce any input pattern

Re: [HarfBuzz] On hb_shape_plan() and other API for 1.0

2012-04-17 Thread Behdad Esfahbod
On 04/12/2012 07:55 AM, Jonathan Kew wrote: > On 12/4/12 02:47, Behdad Esfahbod wrote: >> As a crude test, I profiled the Indic shaping, and am conjecturing that about >> 10 to 20 percent of the time can be saved pre-planning the shaping process. >> My testing showed no measurable saving for skippi

Re: [HarfBuzz] A problem in thai shaper

2012-04-17 Thread Behdad Esfahbod
On 04/17/2012 06:47 PM, Khaled Hosny wrote: > On Tue, Apr 17, 2012 at 05:10:37AM +0200, Khaled Hosny wrote: >> On Mon, Apr 16, 2012 at 09:08:49PM -0400, Behdad Esfahbod wrote: Problem 2: When there is no consonant exist, the dotted circle should be inserted as base charact

Re: [HarfBuzz] A problem in thai shaper

2012-04-17 Thread Khaled Hosny
On Tue, Apr 17, 2012 at 05:10:37AM +0200, Khaled Hosny wrote: > On Mon, Apr 16, 2012 at 09:08:49PM -0400, Behdad Esfahbod wrote: > > > Problem 2: > > > > > > When there is no consonant exist, the dotted circle should be inserted as > > > base > > > character. The logic should be the first step f

Re: [HarfBuzz] A problem in thai shaper

2012-04-17 Thread Behdad Esfahbod
Your HarfBuzz build probably doesn't have glib, and you are not providing any Unicode functions, so cluster formation fails. I shall make HB warn boldly if that happens. behdad On 04/17/2012 01:27 PM, datao zhang wrote: > Hi behdad: > > Thanks your comments. > > I have recheck the cluster va

[HarfBuzz] harfbuzz-ng: Branch 'master'

2012-04-17 Thread Behdad Esfahbod
src/hb-graphite2.cc |3 +++ 1 file changed, 3 insertions(+) New commits: commit 3cde23664fbbe9cd2ac1b8fd5eb2ea288309cc9c Author: Behdad Esfahbod Date: Tue Apr 17 11:44:49 2012 -0400 Minor note re Graphite diff --git a/src/hb-graphite2.cc b/src/hb-graphite2.cc index cdf55f1..fa07ae9 1

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2012-04-17 Thread Behdad Esfahbod
src/hb-graphite2.cc |1 + test/shaping/texts/in-tree/shaper-thai/misc/misc.txt |1 + 2 files changed, 2 insertions(+) New commits: commit 4dc2449d92308f8dd366142831c0b85bd30ea5a9 Author: Behdad Esfahbod Date: Tue Apr 17 11:39:48 2012 -0400 Fix leak