[HarfBuzz] [PATCH] hb-old: the allocated scratch memory contains non-zero values that end up interpolated with real offset values

2012-09-06 Thread Harshula
On Thu, 2012-07-26 at 15:10 -0400, Behdad Esfahbod wrote: On 07/26/2012 09:17 AM, Harshula wrote: [hb-old] Fix clusters Unlike its documentation, hb-old's log_clusters are, well, indeed logical, not visual. Fixup. Adapted / copied from hb-uniscribe. This commit

Re: [HarfBuzz] harfbuzz-ng: Branch 'master'

2012-09-06 Thread Harshula
On Wed, 2012-07-25 at 16:21 -0700, Behdad Esfahbod wrote: src/hb-old.cc| 51 +-- src/hb-old/harfbuzz-shaper.h |1 src/hb-uniscribe.cc |5 ++-- 3 files changed, 44 insertions(+), 13 deletions(-) New commits:

Re: [HarfBuzz] harfbuzz-ng: Branch 'master'

2012-09-06 Thread Behdad Esfahbod
On 09/06/2012 02:47 PM, Harshula wrote: ALLOCATE_ARRAY (const HB_UChar16, item.string, chars_len); + ALLOCATE_ARRAY (unsigned short, item.log_clusters, chars_len + 2); Why is the length chars_len + 2? 1. I *think* old harfbuzz also adds a final entry to that array, 2. It's widely

Re: [HarfBuzz] [PATCH] hb-old: the allocated scratch memory contains non-zero values that end up interpolated with real offset values

2012-09-06 Thread Behdad Esfahbod
On 09/06/2012 02:26 PM, Harshula wrote: char *scratch = (char *) buffer-get_scratch_buffer (scratch_size); + memset(scratch, 0, scratch_size); Ah, right. The offset array needs clearing. I saw the Android people discover this a while ago, but forgot. Thanks for tracking down. behdad

[HarfBuzz] harfbuzz: Branch 'master' - 2 commits

2012-09-06 Thread Behdad Esfahbod
src/hb-ot-shape-fallback.cc | 54 1 file changed, 45 insertions(+), 9 deletions(-) New commits: commit f67917161bbe317a33d6407fbc62ebffcafe7154 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Sep 6 17:22:31 2012 -0400 [OT] Do

[HarfBuzz] [BUG] commit b85800f9de8976a7418ef9df467d3080c6ab0199

2012-09-06 Thread Harshula
On Fri, 2012-08-31 at 16:21 -0700, Behdad Esfahbod wrote: commit b85800f9de8976a7418ef9df467d3080c6ab0199 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Aug 31 18:12:01 2012 -0400 [Indic] Implement dotted-circle insertion for broken clusters No panic, we reeally insert

Re: [HarfBuzz] harfbuzz-ng: Branch 'master'

2012-09-06 Thread Harshula
On Thu, 2012-09-06 at 15:17 -0400, Behdad Esfahbod wrote: On 09/06/2012 02:47 PM, Harshula wrote: ALLOCATE_ARRAY (const HB_UChar16, item.string, chars_len); + ALLOCATE_ARRAY (unsigned short, item.log_clusters, chars_len + 2); Why is the length chars_len + 2? 1. I *think* old

Re: [HarfBuzz] Harfbuzz Sinhala (si) script support status update

2012-09-06 Thread Harshula
On Mon, 2012-09-03 at 20:27 -0400, Behdad Esfahbod wrote: On 09/03/2012 03:11 AM, Harshula wrote: 3) Taking (2) into account, it may be possible for existing GNU/Linux fonts to support both the new and old shaper. However, I would have to defer that to someone who knows their way around