Re: [HarfBuzz] Streamlining hb_font_t some more

2015-10-09 Thread Simon Cozens
On 10/10/2015 01:33, Jonathan Kew wrote: > You probably want to be using the "typographic" metrics from the OS/2 > table, if present, with the hhea metrics as a fallback for fonts that > don't have OS/2. (They're rare, but can exist at least on OS X.) Hmm... that's something it doesn't look like

Re: [HarfBuzz] Streamlining hb_font_t some more

2015-10-09 Thread Khaled Hosny
On Thu, Oct 08, 2015 at 11:54:09AM -0400, Behdad Esfahbod wrote: > So, from my > point of view, you should NOT use this for line height calculation. You > should just use the typographical ascender/descender of the font and hence not >

Re: [HarfBuzz] Streamlining hb_font_t some more

2015-10-09 Thread Jonathan Kew
On 9/10/15 14:32, Simon Cozens wrote: On 09/10/2015 15:09, Khaled Hosny wrote: On Thu, Oct 08, 2015 at 11:54:09AM -0400, Behdad Esfahbod wrote: So, from my point of view, you should NOT use this for line height calculation. You

[HarfBuzz] harfbuzz: Branch 'master' - 3 commits

2015-10-09 Thread Behdad Esfahbod
src/hb-open-type-private.hh | 28 +- src/hb-ot-layout-gpos-table.hh | 15 +-- src/hb-ot-layout-gsub-table.hh | 13 +- src/hb-ot-layout-gsubgpos-private.hh

Re: [HarfBuzz] Streamlining hb_font_t some more

2015-10-09 Thread Simon Cozens
On 09/10/2015 15:09, Khaled Hosny wrote: > On Thu, Oct 08, 2015 at 11:54:09AM -0400, Behdad Esfahbod wrote: >> So, from my >> point of view, you should NOT use this for line height calculation. You >> should just use the typographical

[HarfBuzz] harfbuzz: Branch 'master'

2015-10-09 Thread Behdad Esfahbod
src/hb-open-type-private.hh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ee9b0b6cb5fdb08671ab064f26c299135f828260 Author: Behdad Esfahbod Date: Fri Oct 9 14:23:15 2015 -0400 Fix another sanitize bug Also discovered by