Re: [HarfBuzz] Line break properties in UCDN

2012-11-09 Thread Tom Hacohen
On 09/11/12 08:19, Lóránt Pintér wrote: Hi, Would it be possible to include data from LineBreaks.txt in the ucdn project? Maybe a conditional during build to enable this? Or am I missing something, and it's already included? (makeunicodedata.py mentions it, but I don't see it anywhere in

Re: [HarfBuzz] harfbuzz: Branch 'master'

2012-09-02 Thread Tom Hacohen
Thanks for the commit, have been waiting for this one. As for the first issue: there's only so much you can do to workaround broken fonts. -- Tom. On 02/09/12 03:40, Behdad Esfahbod wrote: src/hb-ot-shape.cc | 32 1 file changed, 32 insertions(+) New

Re: [HarfBuzz] Standalone Unicode support library

2012-08-20 Thread Tom Hacohen
Hey Grigori, Thanks a lot for this wonderful lib. I haven't checked the code nor have I tried compiling/using it, but just the concept is very much needed. Could you please consider adding CMake (or any other build system) support so it'll be easier to just build a lib out of it? Thanks a

Re: [HarfBuzz] Harfbuzz does not compile (errors)

2012-06-03 Thread Tom Hacohen
Thanks. gcc 4.7.0 -- Tom. On 03/06/12 22:55, Behdad Esfahbod wrote: Fixed. Interesting. What compiler was this? On 06/03/2012 06:45 AM, Tom Hacohen wrote: Dear, The following commit breaks compilation: commit 0558d55bac7fb9279aac859b465e7c0e3ad97492 Author: Behdad Esfahbodbeh

Re: [HarfBuzz] harfbuzz-ng: Branch 'master' - 86 commits

2012-05-13 Thread Tom Hacohen
Been trying to catch you on IRC to thank you personally, but we seem to be completely out of sync lately. Thanks a lot! I'll start testing it soon. :) -- Tom. ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

Re: [HarfBuzz] Possible bug with shaping

2012-04-12 Thread Tom Hacohen
On 12/04/12 16:41, Behdad Esfahbod wrote: On 01/23/2012 02:52 AM, Tom Hacohen wrote: On 23/01/12 02:12, Behdad Esfahbod wrote: Quite possible. The Indic shaper is far from perfect. I'm working on getting the test suite going so I can drive the number of failures way down. Getting

Re: [HarfBuzz] Possible bug with shaping

2012-01-30 Thread Tom Hacohen
On 30/01/12 11:53, Shriramana Sharma wrote: That's all understood. Just thought you might be interested in what is written with the script you are working with. I was interested, and I do appreciate the translation. I actually replied to the wrong person, I meant to reply to the previous

Re: [HarfBuzz] Possible bug with shaping

2012-01-29 Thread Tom Hacohen
Sure. Attached. -- Tom. On 29/01/12 15:45, Behdad Esfahbod wrote: Thanks Tom. Can you please send me a straight patch? Just add them to: test/shaping/texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt behdad On 01/29/2012 04:00 AM, Tom Hacohen wrote: On 23/01/12 02:12

[HarfBuzz] Possible bug with shaping

2012-01-19 Thread Tom Hacohen
Dear, A colleague of mine found a possible bug with Hindi. The string द्दि (u0926 + u094d + u0926 + u093f) displays correctly in GTK+ but not with hb-view (I tried with the Gargi-1.2b font). Please let me know if you need any more information. Thanks, Tom.

Re: [HarfBuzz] Level of support for HB in existing toolkits

2011-08-21 Thread Tom Hacohen
On 19/08/11 16:20, Shriramana Sharma wrote: Hello -- is there any assessment of the level of support for HB (possibly split up into support for HB-legacy or HB-ng) in existing major toolkits/libraries? I'm looking for something like: | HB-legacy | HB-ng --+---+--

Re: [HarfBuzz] harfbuzz-ng: Branch 'master'

2011-08-02 Thread Tom Hacohen
On 02/08/11 17:17, Shriramana Sharma wrote: I'm trying to update my local copy of HB since Behdad is doing more commits, but doing git fetch is still silent and my repo (according to git log) is still standing at commit 5e72071062c015237b79fbd0521341a63166a204 Please tell me what I am doing

Re: [HarfBuzz] harfbuzz-ng: Branch 'master'

2011-08-02 Thread Tom Hacohen
On 02/08/11 17:25, Shriramana Sharma wrote: BTW how about that question which I asked on the other thread -- how to build HB based on my latest git-pulled tree without mucking up the source-tree with compiled files? It's git, you shouldn't have to care about such nonsense. If you ever want to

Re: [HarfBuzz] harfbuzz-ng: Branch 'master' - 3 commits

2011-08-01 Thread Tom Hacohen
On 31/07/11 20:50, Behdad Esfahbod wrote: src/hb-ot-shape-complex-indic.cc | 61 +-- 1 file changed, 53 insertions(+), 8 deletions(-) New commits: commit 9da0487cd452d780673e24329ce03e174a4ef83b Author: Behdad Esfahbodbeh...@behdad.org Date: Sun Jul

Re: [HarfBuzz] [PATCH] Adding a configure flag to disable building of tests

2011-07-21 Thread Tom Hacohen
On 20/07/11 23:44, Behdad Esfahbod wrote: I actually fixed that last week, but seems like I had not pushed it out. Done now. I'd rather keep the configure magic to a minimum for now until I decide exactly what kind of configure API I want to provide. Dear Behdad, test-unicode.c: At top

[HarfBuzz] [PATCH] Adding a configure flag to disable building of tests

2011-07-20 Thread Tom Hacohen
Dear all, Currently, the testing code depends on g_test_fail which was only introduced in glib 2.30. This means that the harfbuzz build now depends on glib 2.30 was is not necessary for regular harfbuzz. One solution, would be checking the existence of this function or checking that the

Re: [HarfBuzz] Unicode vs glyphs

2011-06-14 Thread Tom Hacohen
On Tue, 2011-06-14 at 16:37 +0200, Eduardo Castiñeyra wrote: That's a good question. We have a render engine that expects the string to be passed in Unicode format, as all the drawing methods are based on Unicode indices. Changing it into a glyph based engine is not cheap and I have to

[HarfBuzz] [PATCH] Fixed inifinite loop in gpos code

2011-05-30 Thread Tom Hacohen
Dear, Commit 7403e055cd1463f38215ad9faedd61c3e1b66ac5 introduced an infinite loop, this patch fixes it. -- Tom. From e27c819388aa7e02b6bf26a101ac55aeef1bbd0e Mon Sep 17 00:00:00 2001 From: Tom 'TAsn' Hacohen tom.haco...@partner.samsung.com Date: Mon, 30 May 2011 10:33:01 +0300 Subject: [PATCH]

Re: [HarfBuzz] Inheriting/copying font functions

2011-05-16 Thread Tom Hacohen
On Sun, 2011-05-15 at 16:43 -0400, Behdad Esfahbod wrote: Looks right. Thank you very much. -- Tom. ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz

Re: [HarfBuzz] Inheriting/copying font functions

2011-05-15 Thread Tom Hacohen
On Thu, 2011-05-12 at 10:17 +0300, Tom Hacohen wrote: My code now looks like: hb_ft_font = hb_ft_font_create(ft_face, NULL); hb_font = hb_font_create_sub_font(hb_ft_font); hb_font_set_funcs(hb_font, my_font_funcs_get(), my_data,NULL); hb_shape(hb_font, buffer, NULL, 0

Re: [HarfBuzz] Possible memory leaks in latest revision

2011-05-12 Thread Tom Hacohen
On Wed, 2011-05-11 at 14:38 -0400, Behdad Esfahbod wrote: On 05/11/11 12:37, Tom Hacohen wrote: Since it used to work and the code looks correct, I think it's a memory leak, but it's possibly my misuse of the API. Please let me know. All fixed and in master now. Thanks a lot. Regarding

Re: [HarfBuzz] Inheriting/copying font functions

2011-05-12 Thread Tom Hacohen
On Wed, 2011-05-11 at 10:09 -0400, Behdad Esfahbod wrote: You start by subclassing the font: font = hb_font_create_sub_font (parent); And set your own font-funcs on it: hb_font_set_funcs (font, ffuncs, your_user_data, your_destroy); Now you only have to override any functions you

Re: [HarfBuzz] harfbuzz-ng: Branch 'master'

2011-05-11 Thread Tom Hacohen
On Tue, 2011-05-10 at 14:17 -0400, Behdad Esfahbod wrote: I'm hesitant to offer API for purely optimization purposes. In this case, it's not even possible to offer a meaningful API since the user is free to fetch the glyph array and manipulate it as they wish. So, if there is going to be an

[HarfBuzz] Inheriting/copying font functions

2011-05-11 Thread Tom Hacohen
Dear Behadad, After your recent changes (which removed the hb_font_funcs_get_contour_point_func and the like) and since there's no way to inherit/copy other func functions. It's now impossible to implement only part of the font functions and use Harfbuzz's default for freetype for the rest.

[HarfBuzz] Possible memory leaks in latest revision

2011-05-11 Thread Tom Hacohen
Dear all, Using the attached source code (also available at: http://pastebin.com/yu3gwvM5 if you find it more convenient) valgrind complains about a lot of memory leaks in Harfbuzz (latest revision), for example: ==23594== 64 bytes in 1 blocks are definitely lost in loss record 5 of 6 ==23594==

Re: [HarfBuzz] harfbuzz-ng: Branch 'master' - 4 commits

2011-04-27 Thread Tom Hacohen
On Wed, 2011-04-27 at 06:38 -0700, Behdad Esfahbod wrote: commit d4bee9f813bb299b1c4aab7c33d588be2a7d354b Author: Behdad Esfahbod beh...@behdad.org Date: Wed Apr 27 09:24:37 2011 -0400 [API] Add hb_unicode_funcs_get_default() Thanks a lot! -- Tom.

[HarfBuzz] Hindi scripts shaping support (Devangari and etc)

2011-04-21 Thread Tom Hacohen
Dear all, How are you? I hope you are well. I really need Harfbuzz to support those scripts which do not currently work. I remember that some time ago some people have shown interest in getting them to work and even someone (don't remember who) said he's working on it. I can't read/write any of

Re: [HarfBuzz] Hindi scripts shaping support (Devangari and etc)

2011-04-21 Thread Tom Hacohen
. I'm currently testing hb-view for Khmer script and it works like a charm, as long as the khmr script is defined in the font. If not, you just need to tell which opentype features hb should use. Olivier Le 21/04/11 12:39, Tom Hacohen a écrit : Dear all, How are you? I hope you are well

[HarfBuzz] [PATCH] Added an Indic shaper

2011-04-21 Thread Tom Hacohen
HEREUNDER IS + * ON AN AS IS BASIS, AND THE COPYRIGHT HOLDER HAS NO OBLIGATION TO + * PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. + * + * Author(s): Tom Hacohen t...@stosb.com + */ + +#include hb-ot-shape-complex-private.hh + +HB_BEGIN_DECLS + +static const hb_tag_t

Re: [HarfBuzz] [PATCH] Added an Indic shaper

2011-04-21 Thread Tom Hacohen
On Thu, 2011-04-21 at 15:54 +0100, Jonathan Kew wrote: I'm afraid this is _not_ sufficient to get correct rendering of most (all?) Indic scripts. In addition to the application of OpenType features, Indic scripts require reordering of certain characters; for example, some vowel marks such

Re: [HarfBuzz] [PATCH] Added an Indic shaper

2011-04-21 Thread Tom Hacohen
On Fri, 2011-04-22 at 00:12 +0900, suzuki toshiya wrote: Although init feature is not forbidden in Indic scripts, basic Indic shaping algorithm is defined without init feature, like, http://www.microsoft.com/typography/otfntdev/devanot/features.aspx I guess the usage of init for script

Re: [HarfBuzz] Why does kerning modify glyph advance?

2011-02-14 Thread Tom Hacohen
On Mon, 2011-02-14 at 14:42 +, Jonathan Kew wrote: Modifying x_offset alone would adjust the position of a glyph but not the position of any following glyphs, which is not the effect you want kerning to have. (OTOH, it's usually appropriate for things like accent positioning.) Oh, good

[HarfBuzz] Query regarding the state if the Indic shaper

2011-02-02 Thread Tom Hacohen
Dear all, Is there any progress regarding the Indic shaper? I remember seeing many people here showing interest in writing one, has anyone done so? What's the updated ETA for the Indic shaper? Thanks a lot, Tom. ___ HarfBuzz mailing list

Re: [HarfBuzz] How to override Harfbuzz's freetype functions?

2011-02-01 Thread Tom Hacohen
On Tue, 2011-02-01 at 14:03 -0500, Behdad Esfahbod wrote: Thank you very much, weird that I missed it. I'm not quite satisfied with this scheme. The problem with it is that if/when new callbacks are added to hb_font_funcs_t, your code needs to be updated to relay those. Would have been much

Re: [HarfBuzz] Template or sample code for writing a shaper for harfbuzz-ng?

2010-12-29 Thread Tom Hacohen
On Wed, 2010-12-29 at 14:27 +0530, Arjuna Rao Chavala wrote: I am also interested, as I would like to support to ensure the languages that I know Telugu, Hindi and Kannda are supported fine with the new shaper. I would also like that, because I would like seeing a shaper for those languages

[HarfBuzz] Who is responsible for Devanagari reordering?

2010-12-19 Thread Tom Hacohen
Dear all, I know there's no Indic support in Harfbuzz just yet, but still, when there will be, who is responsible for Indic reordering? Harfbuzz? Or is there another lib/will have to write it myself? Thanks, Tom. ___ HarfBuzz mailing list

Re: [HarfBuzz] Who is responsible for Devanagari reordering?

2010-12-19 Thread Tom Hacohen
On Sun, 2010-12-19 at 05:16 -0500, Behdad Esfahbod wrote: HarfBuzz will do it all for you. We don't expect users of HarfBuzz to even know about the delicate details of various scripts. Good to know. Thanks, Tom. ___ HarfBuzz mailing list

Re: [HarfBuzz] Optmizing code using Harfbuzz

2010-11-07 Thread Tom Hacohen
On Thu, 2010-11-04 at 13:54 -0400, Behdad Esfahbod wrote: Unless you show us some hard profiling data, I don't think there's much I can do. If it's good to run Firefox and GNOME, it out to be fast enough for a mobile screen... If you don't do anything else, it's no surprise that harfbuzz is

[HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Tom Hacohen
Hey, Is it just me, or do vowels break shaping in Arabic? If so, what should be done to fix it? I can't think of a way of solving it, maybe only removing the vowels, shaping without them and then adding previously shaped glyphs, and then vowels and then the glyphs again and reshaping, but that's

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Tom Hacohen
On Wed, 2010-10-27 at 09:48 -0400, Behdad Esfahbod wrote: Maybe you can attach a screenshot at least? I just get isolated forms of all of them, anyhow, screenshot attached. But please also look at the bottom of the previous message where I described a SEGFAULT I was getting and also what I

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Tom Hacohen
On Wed, 2010-10-27 at 10:41 -0400, Behdad Esfahbod wrote: On 10/27/10 09:19, Tom Hacohen wrote: because c-buffer-info[i].gproperty == 65535 So I think there's still an issue. Fixed that too. Pushed out. Cool to know my assumptions were correct. Thank you very much, works like a charm

Re: [HarfBuzz] Getting the number of Graphmes for a ligature

2010-10-26 Thread Tom Hacohen
On Mon, 2010-10-25 at 21:21 -0400, Behdad Esfahbod wrote: That's how it should be done in the current design, and what Pango does indeed. For the last cluster, you need to take the length of the original text into account, yes. I've been thinking about adding a sentinel item at the end of

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-26 Thread Tom Hacohen
On Mon, 2010-10-25 at 21:23 -0400, Behdad Esfahbod wrote: Not yet. But you can use hb_unicode_get_combining_class(). Thanks, Tom. ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz

[HarfBuzz] What's the correct Create/Destory usage of hb_ft_face/font ?

2010-10-26 Thread Tom Hacohen
Hey all, I don't understand what's the correct way of using those. Currently I just: hb_face = hb_ft_face_create(face, NULL); hb_font = hb_ft_font_create(face, NULL); hb_font_destroy(hb_font); hb_face_destroy(hb_face); But I think I'm doing something wrong, as I get: ==32762==

Re: [HarfBuzz] What's the correct Create/Destory usage of hb_ft_face/font ?

2010-10-26 Thread Tom Hacohen
On Tue, 2010-10-26 at 11:14 -0400, Behdad Esfahbod wrote: Can you try with master? I remember I fixed a blob leak a while ago... I'm with the latest harfbuzz from the master branch. Latest commit: 39dede9e732f78cbd092ccb3b48d77ddd66d from the 13th of October. -- Tom.

Re: [HarfBuzz] What's the correct Create/Destory usage of hb_ft_face/font ?

2010-10-26 Thread Tom Hacohen
On Tue, 2010-10-26 at 11:28 -0400, Behdad Esfahbod wrote: Fixed it in master right now. Looks like that fixed it, thank you very much. -- Tom. ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

[HarfBuzz] Getting the number of Graphmes for a ligature

2010-10-25 Thread Tom Hacohen
Hey all, I wonder, is there a way to get the number of Graphmes for a ligature? I can just take the cluster index and the next cluster index (or in rtl texts the other way around) and by that find the number of items, but this means I will have to handle the special case of just one ligature in

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-24 Thread Tom Hacohen
Dear Behdad, My replies are below. On Thu, 2010-10-21 at 14:55 -0400, Behdad Esfahbod wrote: It's more than just Latin. Yeah, also Yiddish and Hebrew, Arabic and Persian I know them, they just didn't pop to my head. If you have UTF-32 or UTF-16, just pass the length indeed. For UTF-8,

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-21 Thread Tom Hacohen
Hi Behdad, Thanks a lot for your response, my comments are below: On Wed, 2010-10-20 at 20:17 -0400, Behdad Esfahbod wrote: Yes, that's it. It's more than plain reversal at the end though. You get the direction from the output of UAX#9 (eg. FriBidi). What does it do more than a plain

[HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-20 Thread Tom Hacohen
Dear all, I have a couple of questions about things I don't completely understand. 1. What does the direction in hb_buffer mean (I'm only talking about LTR and RTL, TTB and BTT have more implications)? From what I've seen, it only controls whether it should reverse the order of buffer, or not. 2.

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-20 Thread Tom Hacohen
On Wed, 2010-10-20 at 17:50 +0200, Khaled Hosny wrote: Each OpenType lookup is associated with script(s) and language(s) where it should be active. Oh, right, didn't think about those Latin users, my bad. What's the best way to detect languages? Just use locale? or is there a better way? There

[HarfBuzz] Request for quick/small Harfbuzz usage flow

2010-10-13 Thread Tom Hacohen
Dear all, I need harfbuzz for diacritic positioning and character shaping (in many languages), or at least this is what I know I need from Harfbuzz now, am I missing anything? Is there anything more Harfbuzz does that I might be interested in? Anyhow, I would like, if possible, since there's no

[HarfBuzz] Intro to HarfBuzz

2010-08-30 Thread Tom Hacohen
Dear all, My name is Tom and I work on the Hebrew and Arabic support of enlightenment.org (efl/e17). Until now, I based my work on the FriBiDi shaper. I've heard the name HarfBuzz in the past, and was planning to use it for a while now, and the lack of ligatures support in FriBiDi was the final

Re: [HarfBuzz] Intro to HarfBuzz

2010-08-30 Thread Tom Hacohen
On Mon, 2010-08-30 at 15:24 +0530, arjuna rao chavala wrote: Please check this Thanks, looks like exactly what I was looking for, although I already went through some of the links you gave in the past, I found new info I haven't read already. Will read it today/tomorrow. Again, thanks, Tom.