src/hb-coretext.cc |2 ++
1 file changed, 2 insertions(+)
New commits:
commit aec468f01e866c99e65a8f764a792c74c96840d7
Author: Behdad Esfahbod
Date: Fri Nov 29 19:21:58 2013 -0500
[coretext] Add TODO
diff --git a/src/hb-coretext.cc b/src/hb-coretext.cc
index ecc1bf4..25e4055 100644
-
src/hb-coretext.cc | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
New commits:
commit 58cc233e8b5fdc9dce603acc1b968540a2dea3e1
Author: Behdad Esfahbod
Date: Fri Nov 29 19:17:42 2013 -0500
[coretext] Cleanup
diff --git a/src/hb-coretext.cc b/src/hb-c
src/hb-coretext.cc | 35 +++
src/hb-fallback-shape.cc | 10 ++
src/hb-ot-layout-common-private.hh |3 ++-
3 files changed, 47 insertions(+), 1 deletion(-)
New commits:
commit c8213c6198abff97822e29a6d565722cfbb43832
Author:
The cg_font is already there in the face data, so we don't need to copy it. I
can take it from here. Thanks!
On 13-11-29 06:57 PM, Khaled Hosny wrote:
> I wouldn’t know of course :) So I just checked, for Copy or Create
> functions you own the returned object, for Get functions you don’t, so
> a
I wouldn’t know of course :) So I just checked, for Copy or Create
functions you own the returned object, for Get functions you don’t, so
according to that only the CGFont's need to be released.
On Fri, Nov 29, 2013 at 06:19:36PM -0500, Behdad Esfahbod wrote:
> Shouldn't we CFRelease these:
>
> +
Shouldn't we CFRelease these:
+CTFontRef run_ct_font = static_cast(CFDictionaryGetValue
(attributes, kCTFontAttributeName));
+CGFontRef run_cg_font = CTFontCopyGraphicsFont (run_ct_font, 0);
+CGFontRef cg_font = CTFontCopyGraphicsFont (font_data->ct_font, 0);
On 13-11-29 06:01 PM, Kh
On Fri, Nov 29, 2013 at 05:38:06PM -0500, Behdad Esfahbod wrote:
> On 13-11-29 05:10 PM, Khaled Hosny wrote:
> > We should compare the CGFont's then. Updated patch attached.
>
> Ok, I just studied this. I think the work should be done at the very
> beginning of the look (line 653),
It had to be
On 13-11-29 05:10 PM, Khaled Hosny wrote:
> We should compare the CGFont's then. Updated patch attached.
Ok, I just studied this. I think the work should be done at the very
beginning of the look (line 653), and produce one notdef per input character.
The number of glyphs in the current run is d
We should compare the CGFont's then. Updated patch attached.
Regards,
Khaled
On Fri, Nov 29, 2013 at 03:13:19PM -0500, Behdad Esfahbod wrote:
> Your patch doesn't work with user features. For each user feature we use a
> sub-font of ct_font:
>
> range->font = CTFontCreateCopyWithAttributes (f
Your patch doesn't work with user features. For each user feature we use a
sub-font of ct_font:
range->font = CTFontCreateCopyWithAttributes (font_data->ct_font, 0.0, NULL,
font_desc);
On 13-11-25 08:42 AM, Khaled Hosny wrote:
> Resending a patch that actually applies!
>
>
>
>
10 matches
Mail list logo
