Re: [HarfBuzz] graphite and python available

2009-12-09 Thread Behdad Esfahbod
Thanks Martin, The anonymous URL for your repo: git://gitorious.org/harfbuzz-dev/harfbuzz-dev.git So what I did was I went into my hb-ng repo clone and: $ git remote add martin git://gitorious.org/harfbuzz-dev/harfbuzz-dev.git $ git fetch martin Then I can inspect your work: $ gitk

[HarfBuzz] harfbuzz-ng: Branch 'master' - 8 commits

2009-12-20 Thread Behdad Esfahbod
| 37 + src/hb-unicode.h| 21 ++ 8 files changed, 142 insertions(+), 34 deletions(-) New commits: commit 001fc2d2aa22f14302739fe4ca45f7535855e0fb Author: Behdad Esfahbod beh...@behdad.org Date: Sun Dec 20 17:24:05 2009 +0100 Add TrueType

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2009-12-20 Thread Behdad Esfahbod
src/hb-shape.c | 89 - 1 file changed, 76 insertions(+), 13 deletions(-) New commits: commit 51f141a7f38a73f671b23f58cadf97a72c43b625 Author: Behdad Esfahbod beh...@behdad.org Date: Sun Dec 20 18:22:28 2009 +0100 Avoid overflow

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-03-01 Thread Behdad Esfahbod
src/hb-ft.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit e48ed72230a83499dabbd02af2ac63340220a353 Author: Behdad Esfahbod beh...@behdad.org Date: Mon Mar 1 22:33:45 2010 -0500 [ft] Check stream-read instead of stream-base The former is more

[HarfBuzz] HarfBuzz hacking sprint in planning

2010-04-09 Thread Behdad Esfahbod
Hi, Martin Hosken and I have been thinking about doing a HarfBuzz hacking sprint. Current time/location we have in mind is week of May 17th in Reading, UK. We are deliberately trying to keep this a small hacking sprint as opposed to a meeting. It would be really nice to have Jonathan Kew, Evin

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-05-10 Thread Behdad Esfahbod
: commit fe9bc070e1d545b0df2ea548eebf5a1fc4c92ddc Author: Behdad Esfahbod beh...@behdad.org Date: Mon May 10 21:39:24 2010 -0400 Fix awful confusion between lookup format and subtable format As reported by John Daggett. diff --git a/src/hb-ot-layout-gpos-private.hh b/src/hb-ot-layout

[HarfBuzz] Next week's hackfest

2010-05-12 Thread Behdad Esfahbod
Hi, Just a quick note that I'm still waiting for my UK visa. So, there is considerable chance that I cannot make it to the hackfest :(. I'll wait till the weekend before trying to figure out what to do instead. behdad ___ HarfBuzz mailing list

[HarfBuzz] Meeting update

2010-05-16 Thread Behdad Esfahbod
Hi all, Two things: I see 5 people got automatically unsubscribed from the list. Something phishy with bouncing. I'll check it out when I get home tonight. As Morphy prophesied so rightfully, I didn't get my UK visa on time (and no sign that it will arrive tomorrow either), so I cancelled my

Re: [HarfBuzz] Typo in harfbuzz-hangul.c

2010-05-17 Thread Behdad Esfahbod
On 04/16/2010 10:44 PM, Dohyun Kim wrote: { HB_MAKE_TAG('l', 'j', 'm', 'o'), CcmpProperty }, -{ HB_MAKE_TAG('j', 'j', 'm', 'o'), CcmpProperty }, +{ HB_MAKE_TAG('v', 'j', 'm', 'o'), CcmpProperty }, { HB_MAKE_TAG('t', 'j', 'm', 'o'), CcmpProperty }, Fixed. Thanks. behdad

[HarfBuzz] harfbuzz-ng: Branch 'master' - 3 commits

2010-05-19 Thread Behdad Esfahbod
-layout.cc | 31 - src/hb-private.h |4 - 14 files changed, 219 insertions(+), 76 deletions(-) New commits: commit 0a4399ca228d244e646abdb3487da0f13b228889 Author: Behdad Esfahbod beh...@behdad.org Date: Wed May 19 15:45:06 2010 -0400 Fix scale issues

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-20 Thread Behdad Esfahbod
src/hb-font.cc | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) New commits: commit 99d9ef785f108df76f80a307eaa2784685ea86ba Author: Behdad Esfahbod beh...@behdad.org Date: Thu May 20 15:47:49 2010 +0100 Write hb_face_create_for_data() in terms

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-20 Thread Behdad Esfahbod
src/hb-font.cc |2 +- src/hb-ft.cc |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 750a2294553d252e28875b605fe61fd9d6696e0f Author: Behdad Esfahbod beh...@behdad.org Date: Thu May 20 16:23:27 2010 +0100 get_table() is allowed to return NULL. Use

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-28 Thread Behdad Esfahbod
src/hb-ot-shape.cc | 291 + 1 file changed, 186 insertions(+), 105 deletions(-) New commits: commit 0e235d0fc9bdeeaffa7215c21abc5d40767a10c7 Author: Behdad Esfahbod beh...@behdad.org Date: Fri May 28 20:21:47 2010 -0400 Towards a mask

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-05-28 Thread Behdad Esfahbod
src/hb-ot-shape.cc | 54 - 1 file changed, 25 insertions(+), 29 deletions(-) New commits: commit 8af45fda475d075c5a285002463a00a0423d3926 Author: Behdad Esfahbod beh...@behdad.org Date: Fri May 28 20:41:20 2010 -0400 Fix global feature

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-28 Thread Behdad Esfahbod
src/hb-ot-shape.cc | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) New commits: commit f062ec6bb24b1c21d37b12adc7e944a5fe53526a Author: Behdad Esfahbod beh...@behdad.org Date: Fri May 28 20:54:43 2010 -0400 Further simplify mask allocator diff --git a/src

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-06-03 Thread Behdad Esfahbod
src/hb-ot-shape.cc |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit f2a1b411b1d48c3dfac0df8e78c848d9aa3bb047 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Jun 3 11:37:51 2010 -0400 Followup fix for variation-selectors Patch from Jonathan Kew

Re: [HarfBuzz] variation selector support

2010-06-03 Thread Behdad Esfahbod
Good point. Pushed. On 06/03/2010 04:56 AM, Jonathan Kew wrote: On 3 Jun 2010, at 03:31, Behdad Esfahbod wrote: Done. Please test. Almost you missed the case where the last char in the buffer is a variation selector. In that case, the main loop has already processed it, and you

[HarfBuzz] harfbuzz-ng: Branch 'master' - 5 commits

2010-07-07 Thread Behdad Esfahbod
(-) New commits: commit cc8a4abea68f2dba26feb5785f9e518e6853c744 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Jul 8 00:40:04 2010 -0400 Use bsearch where applicable diff --git a/src/hb-open-type-private.hh b/src/hb-open-type-private.hh index 59c7866..9cc0518 100644 --- a/src/hb-open

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-07-15 Thread Behdad Esfahbod
src/hb-blob.c | 10 +- src/hb-open-type-private.hh |5 +++-- 2 files changed, 8 insertions(+), 7 deletions(-) New commits: commit 17e9ff938b638fd1cb80c990ba13bd47562116b8 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Jul 15 11:21:34 2010 -0700 Fix 64bit

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-07-21 Thread Behdad Esfahbod
src/hb-open-type-private.hh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4f801bd6586defdbf70162e0c7f8968d2b476df2 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Jul 21 16:37:01 2010 -0400 Mozilla bug 580233 - check for zero-length record in hb

Re: [HarfBuzz] potential crash in sanitizer code

2010-07-21 Thread Behdad Esfahbod
Fixed. Thanks. behdad On 07/20/10 10:16, Jonathan Kew wrote: Hi Behdad, We've run across a case where the sanitizer crashes (division by zero) on invalid data. This happens if *none* of the possible fields are actually specified as present in ValueFormat, so that the record_size passed

[HarfBuzz] harfbuzz-ng repository

2010-07-22 Thread Behdad Esfahbod
I get asked from time to time about where the harfbuzz-ng is hosted. Until I move it to a better place, this is where it is: git://git.freedesktop.org/~behdad/harfbuzz-ng behdad ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

[HarfBuzz] stdint.h vs inttypes.h

2010-07-22 Thread Behdad Esfahbod
From what I hear, MSVC and Solaris 9 don't have stdint.h. Is that correct? Apparently Solaris 9 does have inttypes.h. How about MSVC? If both have that one, maybe I can switch to including that one in hb-ng instead? What about other exotic platforms? behdad

[HarfBuzz] harfbuzz-ng: Branch 'master' - 4 commits

2010-07-23 Thread Behdad Esfahbod
|3 src/main.cc |6 51 files changed, 683 insertions(+), 490 deletions(-) New commits: commit acdba3f90b232fc12fcb200dca2584481b339118 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Jul 23 15:11:18 2010 -0400 Prefer C linkage

Re: [HarfBuzz] The status of harfbuzz-ng shapers

2010-08-13 Thread Behdad Esfahbod
On 08/13/10 14:20, Khaled Hosny wrote: Great, can't wait to try it (especially with the python bindings). Speaking of the Python bindings. They need a lot of love. Would be nice if someone makes a real FreeType binding first... If you want to work on it, would be hugely appreciated. behdad

Re: [HarfBuzz] patch for hb-ot-layout.cc to prevent null-deref

2010-08-16 Thread Behdad Esfahbod
Thanks Jonathan. Committed. I still need to rewrite the face to be a cache of arbitrary tables, but have committed the fix for now. Looking into the 'head' one now. behdad On 08/16/10 09:55, Jonathan Kew wrote: It looks to me like the _get_gdef, _get_gsub, and _get_gpos functions in

Re: [HarfBuzz] Intro to HarfBuzz

2010-08-31 Thread Behdad Esfahbod
On 08/31/10 11:18, Tom Hacohen wrote: I wonder how everything will work with FriBiDi, since currently my flow is: Split to paragraphs - Get bidi attributes per paragraph - split to lines - shape - reorder. You should break into runs that have the same direction and script, and shape each of

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-09-15 Thread Behdad Esfahbod
On 08/23/10 13:46, Jonathan Kew wrote: Hi Behdad, I notice that the code in MarkArray::apply() includes the following: hb_internal_glyph_position_t o = c-buffer-pos[c-buffer-i]; o.x_advance = 0; o.y_advance = 0; o.x_offset = base_x - mark_x; o.y_offset = base_y -

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-09-22 Thread Behdad Esfahbod
Hi Jonathan, I'm investigating this. Can you send me the exact version of DejaVuSansMono and the sample text reproducing this please. Thanks, behdad On 08/23/10 13:46, Jonathan Kew wrote: Hi Behdad, I notice that the code in MarkArray::apply() includes the following:

Re: [HarfBuzz] Caching of glyphmetrics and cmap data

2010-09-23 Thread Behdad Esfahbod
Hi Keith, Thanks for the effort. It's widely understood that FreeType's output is supposed to be cached. Though I was hoping that the CMAP access was at least fast enough. Anyway, there are a few problems with caching these in harfbuzz proper: 1) I really really really want to keep the

Re: [HarfBuzz] Caching of glyphmetrics and cmap data

2010-09-28 Thread Behdad Esfahbod
On 09/24/10 00:08, Keith Stribley wrote: Hi Behdad, Thanks for your quick response. On 23/09/10 21:10, Behdad Esfahbod wrote: Another, perhaps better, option is to do the caching in hb-ft.c. I think I like that even more. In this case, there will will need to be a way to store

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-09-28 Thread Behdad Esfahbod
On 09/24/10 12:15, Jonathan Kew wrote: On 23 Sep 2010, at 01:06, Behdad Esfahbod wrote: Hi Jonathan, I'm investigating this. Can you send me the exact version of DejaVuSansMono and the sample text reproducing this please. The attached version of DejaVu Sans Mono should serve. I see

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-10-01 Thread Behdad Esfahbod
Pushed this one out. Thanks. b On 09/24/10 12:15, Jonathan Kew wrote: On 23 Sep 2010, at 01:06, Behdad Esfahbod wrote: Hi Jonathan, I'm investigating this. Can you send me the exact version of DejaVuSansMono and the sample text reproducing this please. The attached version of DejaVu

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-10-01 Thread Behdad Esfahbod
|6 +++--- 6 files changed, 25 insertions(+), 18 deletions(-) New commits: commit ac0c1663fa6e93a5a94c88fc7497bc11ca17f0a1 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Oct 1 19:09:23 2010 -0400 Avoid div-by-zero, validate upem diff --git a/src/hb-ot-head-private.hh b/src/hb-ot-head

Re: [HarfBuzz] 'head' table issue

2010-10-01 Thread Behdad Esfahbod
I pushed a fix for the overflow issue. I'll handle the caching part separately. behdad On 08/16/10 10:30, Jonathan Kew wrote: Hi Behdad, I think there's an issue with how the 'head' table is handled in harfbuzz-ng at the moment. hb_face_create_for_tables() loads the 'head' table and

Re: [HarfBuzz] unreachable code in harfbuzz HeadlessArrayOf::sanitize and GenericArrayOf::sanitize

2010-10-12 Thread Behdad Esfahbod
On 10/12/10 07:25, Jonathan Kew wrote: Hi Behdad, Please see https://bugzilla.mozilla.org/show_bug.cgi?id=603346 it's harmless, but see comment #3 there. Thanks. Responded on the bug. Fix the typo, but don't know what to do about unreachable warning. behdad JK

[HarfBuzz] HarfBuzz news, please read.

2010-10-12 Thread Behdad Esfahbod
Hi all, With help from the fdo admins, I finally moved the hb-ng tree to a more prominent place. It also meant that the old tree had to move around to make room. So, effective immediately: New, being developed, HarfBuzz tree (aka harfbuzz-ng) is at: http://cgit.freedesktop.org/harfbuzz/

[HarfBuzz] Arabic/Syriac/N'ko shaper

2010-10-12 Thread Behdad Esfahbod
The Arabic/Syriac/N'ko shaper is hooked up and working now! Did some minimal testing. I'll update pango to drop the arabic-fc and syriac-fc shapers so it uses hb_shape(). Please test. There's still a few bits to put in place, but the current master makes it clear which way we are heading.

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-12 Thread Behdad Esfahbod
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3703f88b74707113e782eb6ca9a77603561760d0 Author: Behdad Esfahbod beh...@behdad.org Date: Tue Oct 12 18:34:20 2010 -0400 Step the version up to 0.2 now that Arabic shaper is in diff --git

Re: [HarfBuzz] features enumeration

2010-10-13 Thread Behdad Esfahbod
On 10/13/10 09:56, Pierre Marchand wrote: Hello, As I didn't want to allocate random amount of memory when enumerating opentype features, I added few functions in the public api. I promise to do something serious about documentation really soon. For now this will do: The

Re: [HarfBuzz] hb_font_funcs_is_immutable() is wrong

2010-10-13 Thread Behdad Esfahbod
On 10/13/10 10:04, Jonathan Kew wrote: Hi Behdad, This function, from hb-font.cc, doesn't look right to me. hb_bool_t hb_font_funcs_is_immutable (hb_font_funcs_t *ffuncs) { return ffuncs-immutable = TRUE; } I suggest removing the = TRUE here! Doh. Copy/paste error!

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-13 Thread Behdad Esfahbod
src/hb-font.cc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3111b8a0d5b38da57c0f6285aec2b92eb690188f Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 13 10:41:53 2010 -0400 Fix stupid bug, oops diff --git a/src/hb-font.cc b/src/hb-font.cc index

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-20 Thread Behdad Esfahbod
On 10/20/10 11:07, Tom Hacohen wrote: Dear all, Hi Tom, I have a couple of questions about things I don't completely understand. 1. What does the direction in hb_buffer mean (I'm only talking about LTR and RTL, TTB and BTT have more implications)? From what I've seen, it only controls

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-21 Thread Behdad Esfahbod
On 10/21/10 04:10, Tom Hacohen wrote: Language is used to do language-specific adjustments when appropriate. You typically just pass the locale or whatever your higher-level tells you (think of lang attribute in html) to hb_language_from_string. As I thought, thanks, I wasn't thinking about

Re: [HarfBuzz] Getting the number of Graphmes for a ligature

2010-10-25 Thread Behdad Esfahbod
On 10/25/10 09:25, Tom Hacohen wrote: Hey all, I wonder, is there a way to get the number of Graphmes for a ligature? I can just take the cluster index and the next cluster index (or in rtl texts the other way around) and by that find the number of items, but this means I will have to

Re: [HarfBuzz] What's the correct Create/Destory usage of hb_ft_face/font ?

2010-10-26 Thread Behdad Esfahbod
On 10/26/10 05:58, Tom Hacohen wrote: Hey all, I don't understand what's the correct way of using those. Currently I just: hb_face = hb_ft_face_create(face, NULL); hb_font = hb_ft_font_create(face, NULL); hb_font_destroy(hb_font); hb_face_destroy(hb_face); But I think

[HarfBuzz] harfbuzz-ng: Branch 'master' - 3 commits

2010-10-26 Thread Behdad Esfahbod
: Behdad Esfahbod beh...@behdad.org Date: Tue Oct 26 11:28:14 2010 -0400 Fix blob leak diff --git a/src/hb-font.cc b/src/hb-font.cc index ba8ab0d..bd55681 100644 --- a/src/hb-font.cc +++ b/src/hb-font.cc @@ -310,7 +310,7 @@ _hb_face_for_data_closure_create (hb_blob_t *blob, unsigned int index

Re: [HarfBuzz] What's the correct Create/Destory usage of hb_ft_face/font ?

2010-10-26 Thread Behdad Esfahbod
On 10/26/10 11:18, Tom Hacohen wrote: On Tue, 2010-10-26 at 11:14 -0400, Behdad Esfahbod wrote: Can you try with master? I remember I fixed a blob leak a while ago... I'm with the latest harfbuzz from the master branch. Latest commit: 39dede9e732f78cbd092ccb3b48d77ddd66d from the 13th

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-10-26 Thread Behdad Esfahbod
|9 +--- 6 files changed, 154 insertions(+), 89 deletions(-) New commits: commit 248e3c2ba47889c247959e44166644872aed59ba Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 01:23:14 2010 -0400 Oops, remove extra mask setting that broke complex shaping diff --git a/src/hb-ot

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-26 Thread Behdad Esfahbod
TODO |2 -- 1 file changed, 2 deletions(-) New commits: commit 12b2d09a87adc1e1aac089cd2e09a68fb7129829 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 01:28:28 2010 -0400 Remove obsolete TODO item We don't cache any metrics internally, so the correct way to add

[HarfBuzz] harfbuzz coordinate system

2010-10-26 Thread Behdad Esfahbod
Hi all, I'm wondering, should increasing y move upwards, or downwards? Most graphics API I've seen (PS-based API being the only exception) has y moving downward. I find that more intuitive in a text layout library, so we can say: in-line glyphs are stacked in the increasing x direction, lines

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 07:28, Tom Hacohen wrote: Hey, Is it just me, or do vowels break shaping in Arabic? Pango has code to work around Arabic fonts that have no GDEF table, and no GPOS table. I've had planned to implement that in HarfBuzz but been putting it off for a while. I'll go ahead and do

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
Maybe you can attach a screenshot at least? On 10/27/10 09:19, Tom Hacohen wrote: On Wed, 2010-10-27 at 14:26 +0200, Khaled Hosny wrote: On Wed, Oct 27, 2010 at 01:28:38PM +0200, Tom Hacohen wrote: Hey, Is it just me, or do vowels break shaping in Arabic? It shouldn't, either the font is

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 09:58, Tom Hacohen wrote: On Wed, 2010-10-27 at 09:48 -0400, Behdad Esfahbod wrote: Maybe you can attach a screenshot at least? I just get isolated forms of all of them, anyhow, screenshot attached. I fixed that bug and pushed out this morning. Please check with master

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-27 Thread Behdad Esfahbod
src/hb-ot-shape-complex-arabic.cc |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit aefdb64689aab19df76590a36c4a04052a8bffdb Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 10:40:39 2010 -0400 Fix segfault with Arabic combining marks diff --git

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 09:19, Tom Hacohen wrote: because c-buffer-info[i].gproperty == 65535 So I think there's still an issue. Fixed that too. Pushed out. behdad ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-27 Thread Behdad Esfahbod
src/hb-ot-layout-gpos-private.hh | 124 --- 1 file changed, 3 insertions(+), 121 deletions(-) New commits: commit ea22c749c7371cf66ca44f0bfe7030aef1926edd Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 11:09:48 2010 -0400 Fix Cursive

[HarfBuzz] harfbuzz-ng: Branch 'master' - 6 commits

2010-10-27 Thread Behdad Esfahbod
+-- src/hb-ot-layout.h | 13 6 files changed, 80 insertions(+), 61 deletions(-) New commits: commit 13528d0c78cadb1f67267c9a692558caef9fdaa6 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 14:09:27 2010 -0400 Supposedly implement vertical

Re: [HarfBuzz] harfbuzz coordinate system

2010-10-28 Thread Behdad Esfahbod
On 10/27/10 15:56, James Cloos wrote: BE == Behdad Esfahbod beh...@behdad.org writes: BE I'm wondering, should increasing y move upwards, or downwards? Most BE graphics API I've seen (PS-based API being the only exception) has y BE moving downward. I find that more intuitive in a text

Re: [HarfBuzz] harfbuzz coordinate system

2010-10-28 Thread Behdad Esfahbod
On 10/28/10 20:55, Martin Hosken wrote: I don't think it matters too much which way you jump on this one so long as: Right. What adds to the confusion is that in simple text, y_offset is always zero, so you can build an entire system without discovering your error... b

Re: [HarfBuzz] harfbuzz coordinate system

2010-10-31 Thread Behdad Esfahbod
On 10/29/10 18:19, Jonathan Kew wrote: So FWIW, my preference would be to keep the y-axis pointing up. I think that's right for a text-centric API, and I don't think making a change will really gain anything. I don't completely agree, but since the two responses I got both prefer the current

Re: [HarfBuzz] build failure in hb-ot-shape-complex-arabic.cc

2010-11-02 Thread Behdad Esfahbod
Thanks Jonathan. Not intended. I try to avoid that but gcc doesn't have a switch to warn when I miss :(. Will push with my next batch. b On 11/02/10 18:19, Jonathan Kew wrote: Hi Behdad, Please remove the trailing comma from the joining-types enumeration in

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-11-02 Thread Behdad Esfahbod
src/hb-ot-shape-complex-arabic.cc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f22802431a983bd4bc60a7653b1103973c3475cb Author: Behdad Esfahbod beh...@behdad.org Date: Tue Nov 2 19:12:37 2010 -0400 Remove trailing comma diff --git a/src/hb-ot-shape-complex

Re: [HarfBuzz] Optmizing code using Harfbuzz

2010-11-03 Thread Behdad Esfahbod
Hi Tom, First thing is to profile it to see where time is spent. Are you caching the shape() results? If you do that and still have problems then definitely profile and tell us about it. behdad On 11/03/10 03:47, Tom Hacohen wrote: Dear all, I'm using harfbuzz in my code, which obviously

Re: [HarfBuzz] Optmizing code using Harfbuzz

2010-11-04 Thread Behdad Esfahbod
Unless you show us some hard profiling data, I don't think there's much I can do. If it's good to run Firefox and GNOME, it out to be fast enough for a mobile screen... If you don't do anything else, it's no surprise that harfbuzz is taking 95% of the time. That doesn't mean anything. b On

[HarfBuzz] TrueType spec bsearch algorithm?

2010-11-04 Thread Behdad Esfahbod
Hi Jonathan, So, many places in the TrueType spec, there are these searchRange, entrySelector, and rangeShift values that seem to be there to facilitate a fast binary search algorithm. I cannot quite get the intended algorithm though (not that I want to implement it, just want to learn). I know

Re: [HarfBuzz] TrueType spec bsearch algorithm?

2010-11-09 Thread Behdad Esfahbod
Thanks Jonathan and Eric, On 11/05/10 15:18, Eric Mader wrote: It's designed to always search a number of items that is a power of 2 so that it can use a shift rather than a divide to compute the new search range. (a divide was quite expensive on a 68K ;-) Well, this is one part that always

Re: [HarfBuzz] 'init' OT feature in Hebrew

2010-11-12 Thread Behdad Esfahbod
On 11/12/10 13:17, Khaled Hosny wrote: Recently I've been told some Adobe apps (InDesign I think) support init, medi and fina for Latin script (and I geuss the support is generic so Hebrew might work too) and some font designers seem to be leveraging such support. I was surprised too, but

Re: [HarfBuzz] 'init' OT feature in Hebrew

2010-11-12 Thread Behdad Esfahbod
On 11/12/10 16:16, James Cloos wrote: If the miniscule folling a majuscule does not connect to the previous glyph then it should use its initial form. At least conceptually. Making it work does seem to be left as an exercise for the reader^W, err, writer(?). ☺ The font designer can do

Re: [HarfBuzz] Harfbuzz version

2010-11-17 Thread Behdad Esfahbod
GtkTextView and other display widgets that have integral Unicode bidi to render their display. On 18 November 2010 07:49, Behdad Esfahbod beh...@behdad.org mailto:beh...@behdad.org wrote: On 11/12/10 16:36, Chris Scaife wrote: Thanks for that reply :) I did indeed look at using

Re: [HarfBuzz] [ft-devel] Re: About Gsub table in opentype.

2010-11-17 Thread Behdad Esfahbod
On 11/16/10 22:47, Kenichi Handa wrote: I too want to switch from libotf to harfbuzz, but at the moment, harfbuzz is not released as an independent library (and APIs are still changing), I can't catch a good timing to shift to harfbuzz. Good to know. Maybe you're thinking of libm17n; that

[HarfBuzz] harfbuzz-ng: Branch 'master' - 6 commits

2010-11-17 Thread Behdad Esfahbod
-unicode.h |9 +++-- 6 files changed, 47 insertions(+), 19 deletions(-) New commits: commit 43bf2f7f1ec427c431e2ee2fd1a9345e7d5c9718 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Nov 17 14:49:40 2010 -0500 Add OpenType script tags for Unicode 5.2 and Unicode 6.0

Re: [HarfBuzz] hb_blob_get_user_data() ?

2010-11-17 Thread Behdad Esfahbod
On 11/16/10 16:22, Jonathan Kew wrote: Hi Behdad, Would you have any objection to adding an API to let the client retrieve the user_data from a blob? Karl's proposed patch to do this is here: Hi Jonathan, I'm hesitant to add that. How about generic set_user_data/get_user_data() like cairo

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-11-18 Thread Behdad Esfahbod
COPYING | 12 README |4 ++-- src/hb-graphite.cc |4 ++-- src/hb-object-private.h |2 +- 4 files changed, 17 insertions(+), 5 deletions(-) New commits: commit a45f00019242734fca742adeb2ed507305baeda6 Author: Behdad Esfahbod beh

Re: [HarfBuzz] A few HarfBuzz-ng questions

2010-11-18 Thread Behdad Esfahbod
On 11/17/10 17:25, Ed wrote: Hi, Behdad and everyone, Hi Ed, I'm just now starting to look at and think about HarfBuzz-ng Cool. ... but there isn't actually any above copyright notice. Shouldn't this COPYING file start out with something like Copyright (C) 2010 Google, Inc. or Copyright

Re: [HarfBuzz] A few HarfBuzz-ng questions

2010-11-18 Thread Behdad Esfahbod
Hi Keith, On 11/18/10 03:11, Keith Stribley wrote: I created a tool called grsvg which now allows ICU, HB and Gr rendering to be compared next to each other, Interesting. I know you shared the repo with us before, but can you point it out again? Also, mind adding Pango support?

[HarfBuzz] Hebrew shaper

2010-11-18 Thread Behdad Esfahbod
Hi Dov, As I'm developing HarfBuzz to replace the shapers in Pango I'm planning on removing the Hebrew fallback shaping functionality that is in Pango. Can you confirm that the fallback shaping functionality is obsolete and not needed with Hebrew fonts in wide circulation these days? If it *is*

Re: [HarfBuzz] Hebrew shaper

2010-11-18 Thread Behdad Esfahbod
, Behdad Esfahbod beh...@behdad.org mailto:beh...@behdad.org wrote: Hi Dov, As I'm developing HarfBuzz to replace the shapers in Pango I'm planning on removing the Hebrew fallback shaping functionality that is in Pango. Can you confirm that the fallback shaping

Re: [HarfBuzz] A few HarfBuzz-ng questions

2010-11-19 Thread Behdad Esfahbod
On 11/19/10 02:09, Martin Hosken wrote: Dear Behdad, 2. SHAPERS: In void hb_shape(...) in hb-shape.cc, I see this: The current Graphite shaper is disabled because it was crashing on me all the time. Deep in the libgraphite code... That's a major concern. Most probably I never enable

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-11-22 Thread Behdad Esfahbod
COPYING |2 +- src/hb-ft.c |2 +- src/hb-icu.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 9da26d6669e7f3b91ba37e71f6f8a6e2ea806688 Author: Behdad Esfahbod beh...@behdad.org Date: Mon Nov 22 11:03:18 2010 -0500 Remove email address from

[HarfBuzz] On fallback shaping and future directions

2010-11-22 Thread Behdad Esfahbod
[Warning: Loong email ahead!] Hi list, Now that we have the Arabic shaper in place and working, I spent the past couple weeks pushing the edge cases and in general trying to figure out what loose ends are there that I need to fix before moving on to making a plan for other shapers. I then

Re: [HarfBuzz] Hangul shaper

2010-11-23 Thread Behdad Esfahbod
On 11/23/10 12:28, Changwoo Ryu wrote: Hello, 2010-11-18 (목), 16:51 -0500, Behdad Esfahbod: Hi Changwoo, As I'm developing HarfBuzz to replace the shapers in Pango I'm planning on removing the Hangul shaping functionality that is in Pango, and rely on a generic shaper that can handle

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-11-28 Thread Behdad Esfahbod
contrib/python/lib/harfbuzz.pyx|7 -- src/hb-ot-shape-complex-arabic-table.h | 37 + 2 files changed, 42 insertions(+), 2 deletions(-) New commits: commit 3c48982be6b2286088541ee55cac78b0f2b6e771 Author: Behdad Esfahbod beh...@behdad.org Date

Re: [HarfBuzz] broken shaping for Arabic with LTR override

2010-12-07 Thread Behdad Esfahbod
On 12/07/10 09:14, Jonathan Kew wrote: Moving the call to hb_ot_shape_setup_masks() after hb_ensure_native_direction() seems to fix this, but I'm not sure if there are other potential issues (relating to mirroring, for example) that might complicate this. Right. That's why it was moved.

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-12-13 Thread Behdad Esfahbod
src/hb-ot-layout-gsubgpos-private.hh |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7eb875118dc31e9fb0e23c45985396a8bfe977e3 Author: Behdad Esfahbod beh...@behdad.org Date: Mon Dec 13 14:13:35 2010 -0500 Mozilla Bug 618592 - freeze on typekit Fix

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-12-13 Thread Behdad Esfahbod
src/hb-ot-layout-gsub-private.hh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b7683335146bfe3a74d9419db92cd7a8019a9c10 Author: Behdad Esfahbod beh...@behdad.org Date: Mon Dec 13 14:22:35 2010 -0500 Disallow ligature substitutions replacing one glyph diff

Re: [HarfBuzz] Harfbuzz support for opentype init, medi, fina forms

2010-12-13 Thread Behdad Esfahbod
On 12/09/10 07:20, tugi e wrote: Hallo Behdad, Which default feature is applied first? CALT? then CCMP and so on? When applied the INIT, MEDI, FINA and ISOL features? After the default features or before? Features are applied according to the lookup index of their indexes. behdad

Re: [HarfBuzz] how to migrate from older harfbuzz to harfbuzz-ng

2010-12-17 Thread Behdad Esfahbod
Hi there, On 11/30/10 01:27, suzuki toshiya wrote: Is there any document or good example showing how to migrate to harfbuzz-ng? I should have answered earlier. Anyway, here's the entirety of harfbuzz-shaper.h with my inline annotations: (Unfortunately I couldn't fix the broken lines in my

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-12-21 Thread Behdad Esfahbod
Author: Behdad Esfahbod beh...@behdad.org Date: Tue Dec 21 14:19:32 2010 -0500 Reroute Mandaic shaping through the Arabic shaper We added Mandaic joining data to the Arabic shaper a while ago, but were not actually using the Arabic shaper for Mandaic. Fixed. diff --git a/src

Re: [HarfBuzz] Template or sample code for writing a shaper for harfbuzz-ng?

2011-01-06 Thread Behdad Esfahbod
On 12/29/10 14:25, Jjgod Jiang wrote: On Wed, Dec 29, 2010 at 5:35 PM, Ed ed.tra...@gmail.com wrote: Christopher's question is very relevant: A listing of who is writing, or wants to help write, which shapers would be extremely helpful to everyone. I'd like to know who is working on or

Re: [HarfBuzz] Template or sample code for writing a shaper for harfbuzz-ng?

2011-01-06 Thread Behdad Esfahbod
Hi all, How are new shaping engines going to be handled in harfbuzz-ng? As plug-in modules, or as hard-coded files? Hardcoded. Is there sample or template code somewhere that shows how one would write a new shaper for harfbuzz-ng? hb-ot-shape* is really self-explanatory. Also are

Re: [HarfBuzz] How to override Harfbuzz's freetype functions?

2011-02-01 Thread Behdad Esfahbod
On 02/01/11 09:56, Tom Hacohen wrote: Dear all, I ran a test application in callgrind and noticed that the calls to FT_Load_Glyph are what slows everything down. We already have glyph cache in EFL and I would really like to be able to use it with harfbuzz. At first glance, it seems like I

[HarfBuzz] harfbuzz-ng: Branch 'master'

2011-02-15 Thread Behdad Esfahbod
src/hb-private.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 82438c6ad5f60b6afc75c48cef72e18bef532468 Author: Bradley Grainger bgrain...@logos.com Date: Tue Feb 15 18:37:29 2011 -0500 Fix #pragma message for MSVC. __LOC__ was renamed to _HB__LOC__

Re: [HarfBuzz] [PATCH] Fix #pragma message for MSVC.

2011-02-15 Thread Behdad Esfahbod
Pushed. Thanks. On 02/13/11 22:32, Bradley Grainger wrote: The attached patch fixes a compile error in MSVC. (__LOC__ was renamed to _HB__LOC__ in hb-common.h in cd7555ee but the corresponding change wasn't made to hb-private.h.) Bradley

Re: [HarfBuzz] FreeType/Cairo example

2011-02-22 Thread Behdad Esfahbod
On 02/20/11 15:29, Khaled Hosny wrote: I'm suspecting that the size setting in FT_Set_Char_Size() and cairo_set_font_size() don't line together, but I'm not sure what would be the correct use of both. Instead of setting size on the face yourself, just get a prepared face from cairo using

Re: [HarfBuzz] FreeType/Cairo example

2011-02-22 Thread Behdad Esfahbod
On 02/22/11 13:44, Khaled Hosny wrote: I thought about this already, but it give me much worse spacing; glyps are too widely spaced that two of them can't fit in the screen, see the attached file. Divide the offset/advance you get from harfbuzz by 64., that's the unit when using hb-ft.h. I'm

[HarfBuzz] harfbuzz-ng: Branch 'master'

2011-02-22 Thread Behdad Esfahbod
configure.ac| 18 ++ src/Makefile.am | 14 ++ src/hb-view.c | 342 3 files changed, 374 insertions(+) New commits: commit 5353bf439c150492708ef9337078cfd73b83627b Author: Behdad Esfahbod beh...@behdad.org Date: Tue Feb 22 18

[HarfBuzz] harfbuzz-ng: Branch 'master'

2011-02-23 Thread Behdad Esfahbod
src/hb-view.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a4b781e93a0bee0549611e129b3564d9804d9090 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Feb 23 12:47:56 2011 -0500 Default background color shall either be white or transparent

Re: [HarfBuzz] hb-view

2011-02-23 Thread Behdad Esfahbod
On 02/23/11 05:14, Jjgod Jiang wrote: Shouldn't the background color by default #FF instead of #00? Err. My bad. It used to be # for transparent. I decided to change it to white, and removed two zeros without testing :). Fixed. Any other comments? What other options would

[HarfBuzz] harfbuzz-ng: Branch 'master'

2011-02-28 Thread Behdad Esfahbod
src/hb-buffer.cc | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) New commits: commit b5dd44e24669cd35affcd92788d39ff56cac94db Author: Behdad Esfahbod beh...@behdad.org Date: Mon Feb 28 10:13:52 2011 -0800 Fix possible overflow diff --git a/src/hb-buffer.cc b/src/hb

  1   2   3   4   5   6   7   8   9   10   >