Re: [HarfBuzz] graphite and python available

2009-12-09 Thread Behdad Esfahbod
Thanks Martin, The anonymous URL for your repo: git://gitorious.org/harfbuzz-dev/harfbuzz-dev.git So what I did was I went into my hb-ng repo clone and: $ git remote add martin git://gitorious.org/harfbuzz-dev/harfbuzz-dev.git $ git fetch martin Then I can inspect your work: $ gitk

Re: [HarfBuzz] Indic support in Harfbuzz

2009-12-13 Thread Behdad Esfahbod
On 12/13/2009 11:03 PM, Parag Nemade wrote: Hi Behdad, On Friday 11 December 2009 01:57 PM, Jonathan Kew wrote: On 10 Dec 2009, at 21:29, Parag Nemade wrote: Hi, I would like to know whether current harfbuzz code can be used for testing the rendering of Indic scripts? Not easily, I

[HarfBuzz] harfbuzz-ng: Branch 'master'

2009-12-15 Thread Behdad Esfahbod
src/main.cc | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) New commits: commit bdd0ff5290bae4db65c3fdf95c5728031f13ca84 Author: Behdad Esfahbod beh...@behdad.org Date: Tue Dec 15 04:07:40 2009 -0500 Make main.cc compile without glib diff --git a/src/main.cc b

[HarfBuzz] harfbuzz-ng: Branch 'master' - 8 commits

2009-12-20 Thread Behdad Esfahbod
| 37 + src/hb-unicode.h| 21 ++ 8 files changed, 142 insertions(+), 34 deletions(-) New commits: commit 001fc2d2aa22f14302739fe4ca45f7535855e0fb Author: Behdad Esfahbod beh...@behdad.org Date: Sun Dec 20 17:24:05 2009 +0100 Add TrueType

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2009-12-20 Thread Behdad Esfahbod
src/hb-shape.c | 89 - 1 file changed, 76 insertions(+), 13 deletions(-) New commits: commit 51f141a7f38a73f671b23f58cadf97a72c43b625 Author: Behdad Esfahbod beh...@behdad.org Date: Sun Dec 20 18:22:28 2009 +0100 Avoid overflow

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-03-01 Thread Behdad Esfahbod
src/hb-ft.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit e48ed72230a83499dabbd02af2ac63340220a353 Author: Behdad Esfahbod beh...@behdad.org Date: Mon Mar 1 22:33:45 2010 -0500 [ft] Check stream-read instead of stream-base The former is more

[HarfBuzz] HarfBuzz hacking sprint in planning

2010-04-09 Thread Behdad Esfahbod
Hi, Martin Hosken and I have been thinking about doing a HarfBuzz hacking sprint. Current time/location we have in mind is week of May 17th in Reading, UK. We are deliberately trying to keep this a small hacking sprint as opposed to a meeting. It would be really nice to have Jonathan Kew, Evin

Re: [HarfBuzz] harfbuzz review

2010-04-21 Thread Behdad Esfahbod
Ok, based on your feedback and some help from Ehsan, I've pushed out a bunch of fixes and cleanup to master now. Some macros are replaced by templates. Notably, the int type definitions. More below. On 04/16/2010 02:19 AM, John Daggett wrote: Hmm, if by decoupling you mean that it's possible

Re: [HarfBuzz] compilation failure

2010-04-22 Thread Behdad Esfahbod
Thanks Jonthan, I pushed a different fix. behdad On 04/22/2010 06:33 AM, Jonathan Kew wrote: Hi Behdad, The most recent harfbuzz-ng code fails to compile under some gcc versions because of the use of a semicolon after the DEFINE_NULL_DATA(); macro. Under gcc-4.3.3, it failed with the

[HarfBuzz] harfbuzz-ng: Branch 'master' - 14 commits

2010-04-23 Thread Behdad Esfahbod
files changed, 209 insertions(+), 164 deletions(-) New commits: commit ad3653751b1e4a03f7058200cb83f64db46722d5 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Apr 23 19:43:40 2010 -0400 Typo diff --git a/src/hb-open-type-private.hh b/src/hb-open-type-private.hh index ccd26dc..106af0c

Re: [HarfBuzz] static_assertion failure in latest harfbuzz-ng code

2010-04-25 Thread Behdad Esfahbod
On 04/24/2010 07:30 AM, Jonathan Kew wrote: On 24 Apr 2010, at 00:54, Behdad Esfahbod wrote: - Tag tag;/* 4-byte identifier. */ + private: + union { + Tag tag;/* 4-byte identifier. */ + OpenTypeFontFace fontFace[VAR

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-04-26 Thread Behdad Esfahbod
, Val) \ + (SANITIZE_OBJ (Obj) \ +_hb_sanitize_edit (SANITIZE_ARG, CharP((Obj)), (Obj).get_size ()) \ +((Obj).set (Val), true)) /* Template to sanitize an object. */ commit 690b9194619589c32ffc0c092e45262ae7776e79 Author: Behdad Esfahbod beh...@behdad.org Date: Sun Apr

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-04-26 Thread Behdad Esfahbod
src/hb-ot-layout-common-private.hh |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit caff7db93d205e32a535d49e51a3cad70f91dfdd Author: Behdad Esfahbod beh...@behdad.org Date: Mon Apr 26 10:07:35 2010 -0400 Fix Device::get_size() calculation diff --git

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-04-27 Thread Behdad Esfahbod
src/hb-object-private.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) New commits: commit c165f25410f817d248ad5d07e1827d33efd1b0a0 Author: Behdad Esfahbod beh...@behdad.org Date: Tue Apr 27 23:28:10 2010 -0400 [object] Actually handle malloc() failure Caught

Re: [HarfBuzz] language-code issues

2010-04-29 Thread Behdad Esfahbod
On 04/28/2010 08:13 PM, Jonathan Kew wrote: I've run across a couple of things that seem wrong in the language code support (harfbuzz-ng). (1) hb_language_from_string() fails to increment num_langs when it allocates a new language code, so it never actually remembers what it has allocated!

[HarfBuzz] harfbuzz-ng: Branch 'master' - 5 commits

2010-04-29 Thread Behdad Esfahbod
fde6f5bd682f5ad0cc5e2ec69fc831b0192bf90b Author: Behdad Esfahbod beh...@behdad.org Date: Thu Apr 29 04:41:41 2010 -0400 Convert to uppercase in hb_ot_tag_from_language() diff --git a/src/hb-ot-tag.c b/src/hb-ot-tag.c index 40356b0..8b88eb3 100644 --- a/src/hb-ot-tag.c +++ b/src/hb-ot-tag.c @@ -599,8 +599,10

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-05-10 Thread Behdad Esfahbod
: commit fe9bc070e1d545b0df2ea548eebf5a1fc4c92ddc Author: Behdad Esfahbod beh...@behdad.org Date: Mon May 10 21:39:24 2010 -0400 Fix awful confusion between lookup format and subtable format As reported by John Daggett. diff --git a/src/hb-ot-layout-gpos-private.hh b/src/hb-ot-layout

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-05-10 Thread Behdad Esfahbod
(+), 24 deletions(-) New commits: commit 3d44fb6f15177dc6518166e435597936b044acc1 Author: Behdad Esfahbod beh...@behdad.org Date: Mon May 10 22:22:54 2010 -0400 Fix warning diff --git a/src/hb-ot-layout-common-private.hh b/src/hb-ot-layout-common-private.hh index e724d99..fb07161 100644

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-11 Thread Behdad Esfahbod
src/hb-ot-layout-gpos-private.hh |1 - 1 file changed, 1 deletion(-) New commits: commit 281f08954a1d96d7807153c25073b8eb7630703b Author: Behdad Esfahbod beh...@behdad.org Date: Tue May 11 11:37:58 2010 -0400 Remove obsolete friend diff --git a/src/hb-ot-layout-gpos-private.hh b/src

[HarfBuzz] Next week's hackfest

2010-05-12 Thread Behdad Esfahbod
Hi, Just a quick note that I'm still waiting for my UK visa. So, there is considerable chance that I cannot make it to the hackfest :(. I'll wait till the weekend before trying to figure out what to do instead. behdad ___ HarfBuzz mailing list

Re: [HarfBuzz] Adding tracing

2010-05-13 Thread Behdad Esfahbod
On 05/11/2010 02:09 PM, Martin Hosken wrote: Dear All, I've added tracing to harfbuzz-ng. This is to help font developers rather than programmers, figure out what is going on with their fonts. The cost is a simple if() for each lookup. If that is too high, we can probably make tracing

Re: [HarfBuzz] Next week's hackfest

2010-05-13 Thread Behdad Esfahbod
A quick update: my visa has been issued in Ottawa and now I'm at the mercy of DHL delivering it by tomorrow... behdad On 05/12/2010 05:00 PM, Behdad Esfahbod wrote: Hi, Just a quick note that I'm still waiting for my UK visa. So, there is considerable chance that I cannot make

Re: [HarfBuzz] Adding tracing

2010-05-13 Thread Behdad Esfahbod
On 05/13/2010 05:05 PM, Khaled Hosny wrote: On Thu, May 13, 2010 at 05:01:32PM -0400, Behdad Esfahbod wrote: On 05/11/2010 02:09 PM, Martin Hosken wrote: Dear All, I've added tracing to harfbuzz-ng. This is to help font developers rather than programmers, figure out what is going

[HarfBuzz] Meeting update

2010-05-16 Thread Behdad Esfahbod
Hi all, Two things: I see 5 people got automatically unsubscribed from the list. Something phishy with bouncing. I'll check it out when I get home tonight. As Morphy prophesied so rightfully, I didn't get my UK visa on time (and no sign that it will arrive tomorrow either), so I just cancelled

[HarfBuzz] Meeting update

2010-05-16 Thread Behdad Esfahbod
Hi all, Two things: I see 5 people got automatically unsubscribed from the list. Something phishy with bouncing. I'll check it out when I get home tonight. As Morphy prophesied so rightfully, I didn't get my UK visa on time (and no sign that it will arrive tomorrow either), so I cancelled my

Re: [HarfBuzz] Typo in harfbuzz-hangul.c

2010-05-17 Thread Behdad Esfahbod
On 04/16/2010 10:44 PM, Dohyun Kim wrote: { HB_MAKE_TAG('l', 'j', 'm', 'o'), CcmpProperty }, -{ HB_MAKE_TAG('j', 'j', 'm', 'o'), CcmpProperty }, +{ HB_MAKE_TAG('v', 'j', 'm', 'o'), CcmpProperty }, { HB_MAKE_TAG('t', 'j', 'm', 'o'), CcmpProperty }, Fixed. Thanks. behdad

[HarfBuzz] harfbuzz-ng: Branch 'master' - 3 commits

2010-05-19 Thread Behdad Esfahbod
-layout.cc | 31 - src/hb-private.h |4 - 14 files changed, 219 insertions(+), 76 deletions(-) New commits: commit 0a4399ca228d244e646abdb3487da0f13b228889 Author: Behdad Esfahbod beh...@behdad.org Date: Wed May 19 15:45:06 2010 -0400 Fix scale issues

[HarfBuzz] Scale issues resolved

2010-05-19 Thread Behdad Esfahbod
I believe you saw the commit going by. In short, hb_font_set_scale() changed in how it interprets it's arguments. If you use that API please update your code. I'm sitting in a plane right now, waiting for take off. Will be at the hackfest tomorrow, yay! Cheers, behdad

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-20 Thread Behdad Esfahbod
src/hb-font.cc | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) New commits: commit 99d9ef785f108df76f80a307eaa2784685ea86ba Author: Behdad Esfahbod beh...@behdad.org Date: Thu May 20 15:47:49 2010 +0100 Write hb_face_create_for_data() in terms

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-20 Thread Behdad Esfahbod
src/hb-font.cc |2 +- src/hb-ft.cc |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 750a2294553d252e28875b605fe61fd9d6696e0f Author: Behdad Esfahbod beh...@behdad.org Date: Thu May 20 16:23:27 2010 +0100 get_table() is allowed to return NULL. Use

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-05-20 Thread Behdad Esfahbod
b634beb39e0a4fef7167a8af646f6b2d8cafe69b Author: Behdad Esfahbod beh...@behdad.org Date: Thu May 20 17:44:52 2010 +0100 Fix delta scale, again... diff --git a/src/hb-ot-layout-common-private.hh b/src/hb-ot-layout-common-private.hh index e054b59..f965491 100644 --- a/src/hb-ot-layout-common-private.hh +++ b/src/hb

[HarfBuzz] hb_shape_context_t?

2010-05-28 Thread Behdad Esfahbod
So, staring at the new feature-setting code from Jonathan and having a pre-shape compile feature in mind, I wonder if we should add a hb_shape_context_t object and move script, language, and direction (and unicode callbacks) to it. They currently live in the buffer. The reason for this is that

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-28 Thread Behdad Esfahbod
src/hb-ot-shape.cc | 291 + 1 file changed, 186 insertions(+), 105 deletions(-) New commits: commit 0e235d0fc9bdeeaffa7215c21abc5d40767a10c7 Author: Behdad Esfahbod beh...@behdad.org Date: Fri May 28 20:21:47 2010 -0400 Towards a mask

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-05-28 Thread Behdad Esfahbod
src/hb-ot-shape.cc | 54 - 1 file changed, 25 insertions(+), 29 deletions(-) New commits: commit 8af45fda475d075c5a285002463a00a0423d3926 Author: Behdad Esfahbod beh...@behdad.org Date: Fri May 28 20:41:20 2010 -0400 Fix global feature

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-05-28 Thread Behdad Esfahbod
src/hb-ot-shape.cc | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) New commits: commit f062ec6bb24b1c21d37b12adc7e944a5fe53526a Author: Behdad Esfahbod beh...@behdad.org Date: Fri May 28 20:54:43 2010 -0400 Further simplify mask allocator diff --git a/src

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-06-03 Thread Behdad Esfahbod
src/hb-ot-shape.cc |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit f2a1b411b1d48c3dfac0df8e78c848d9aa3bb047 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Jun 3 11:37:51 2010 -0400 Followup fix for variation-selectors Patch from Jonathan Kew

Re: [HarfBuzz] variation selector support

2010-06-03 Thread Behdad Esfahbod
Good point. Pushed. On 06/03/2010 04:56 AM, Jonathan Kew wrote: On 3 Jun 2010, at 03:31, Behdad Esfahbod wrote: Done. Please test. Almost you missed the case where the last char in the buffer is a variation selector. In that case, the main loop has already processed it, and you

[HarfBuzz] harfbuzz-ng: Branch 'master' - 5 commits

2010-07-07 Thread Behdad Esfahbod
(-) New commits: commit cc8a4abea68f2dba26feb5785f9e518e6853c744 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Jul 8 00:40:04 2010 -0400 Use bsearch where applicable diff --git a/src/hb-open-type-private.hh b/src/hb-open-type-private.hh index 59c7866..9cc0518 100644 --- a/src/hb-open

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-07-15 Thread Behdad Esfahbod
src/hb-blob.c | 10 +- src/hb-open-type-private.hh |5 +++-- 2 files changed, 8 insertions(+), 7 deletions(-) New commits: commit 17e9ff938b638fd1cb80c990ba13bd47562116b8 Author: Behdad Esfahbod beh...@behdad.org Date: Thu Jul 15 11:21:34 2010 -0700 Fix 64bit

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-07-21 Thread Behdad Esfahbod
src/hb-open-type-private.hh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4f801bd6586defdbf70162e0c7f8968d2b476df2 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Jul 21 16:37:01 2010 -0400 Mozilla bug 580233 - check for zero-length record in hb

Re: [HarfBuzz] potential crash in sanitizer code

2010-07-21 Thread Behdad Esfahbod
Fixed. Thanks. behdad On 07/20/10 10:16, Jonathan Kew wrote: Hi Behdad, We've run across a case where the sanitizer crashes (division by zero) on invalid data. This happens if *none* of the possible fields are actually specified as present in ValueFormat, so that the record_size passed

[HarfBuzz] harfbuzz-ng repository

2010-07-22 Thread Behdad Esfahbod
I get asked from time to time about where the harfbuzz-ng is hosted. Until I move it to a better place, this is where it is: git://git.freedesktop.org/~behdad/harfbuzz-ng behdad ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

[HarfBuzz] stdint.h vs inttypes.h

2010-07-22 Thread Behdad Esfahbod
From what I hear, MSVC and Solaris 9 don't have stdint.h. Is that correct? Apparently Solaris 9 does have inttypes.h. How about MSVC? If both have that one, maybe I can switch to including that one in hb-ng instead? What about other exotic platforms? behdad

Re: [HarfBuzz] test or demo program for harfbuzz-ng

2010-07-22 Thread Behdad Esfahbod
On 07/08/10 02:33, pravin@gmail.com wrote: Hi All, do we have any test or demo program for testing rendering of harfbuzz-ng? will be very thankful in help in this regards. Currently I use pango-view from the harfbuzz-ng-external branch of pango's git repo. Note that only the basic

Re: [HarfBuzz] Patch: fix compilation of harfbuzz with Sun Studio on Solaris

2010-07-23 Thread Behdad Esfahbod
On 06/24/10 06:38, Ginn Chen wrote: 2) A union member cannot have a user-defined assignment operator. Same issue as https://bugzilla.gnome.org/show_bug.cgi?id=602408#c1 Well, technically BEInt is never used as a union member. It's used in strcut IntType, and IntType is used in unions. But

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-07-23 Thread Behdad Esfahbod
src/hb-open-type-private.hh |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 81408cd51ce575891e79e6483be187130f864c28 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Jul 23 14:46:57 2010 -0400 Don't use operator = Some compilers don't like

[HarfBuzz] harfbuzz-ng: Branch 'master' - 4 commits

2010-07-23 Thread Behdad Esfahbod
|3 src/main.cc |6 51 files changed, 683 insertions(+), 490 deletions(-) New commits: commit acdba3f90b232fc12fcb200dca2584481b339118 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Jul 23 15:11:18 2010 -0400 Prefer C linkage

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-07-23 Thread Behdad Esfahbod
TODO |3 +++ 1 file changed, 3 insertions(+) New commits: commit da6cff3864d2ef4a061a29e5918359bafcd51f4c Author: Behdad Esfahbod beh...@behdad.org Date: Fri Jul 23 15:40:58 2010 -0400 Add TODO items diff --git a/TODO b/TODO index 4b8db97..98391ab 100644 --- a/TODO +++ b/TODO @@ -1,3

[HarfBuzz] 'mset' feature

2010-07-27 Thread Behdad Esfahbod
Jonathan, I don't remember what your reply was last time. Should we apply 'mset' by default? Thanks, behdad ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz

Re: [HarfBuzz] 'mset' feature

2010-07-27 Thread Behdad Esfahbod
On 07/27/10 13:43, Jonathan Kew wrote: On 27 Jul 2010, at 18:12, Behdad Esfahbod wrote: Jonathan, I don't remember what your reply was last time. Should we apply 'mset' by default? I think we should apply it by default in the Arabic shaper, but not in the generic one. I don't

Re: [HarfBuzz] The status of harfbuzz-ng shapers

2010-08-13 Thread Behdad Esfahbod
On 08/13/10 14:04, Khaled Hosny wrote: I just came across this typophile thread[1], very nice stuff (especially the video in the linked Mozilla Hacks post), good to hear harfbuzz-ng is now integrated in the Firefox's official builds. Now I was wondering if there are any news regarding Arabic

Re: [HarfBuzz] The status of harfbuzz-ng shapers

2010-08-13 Thread Behdad Esfahbod
On 08/13/10 14:20, Khaled Hosny wrote: Great, can't wait to try it (especially with the python bindings). Speaking of the Python bindings. They need a lot of love. Would be nice if someone makes a real FreeType binding first... If you want to work on it, would be hugely appreciated. behdad

Re: [HarfBuzz] patch for hb-ot-layout.cc to prevent null-deref

2010-08-16 Thread Behdad Esfahbod
Thanks Jonathan. Committed. I still need to rewrite the face to be a cache of arbitrary tables, but have committed the fix for now. Looking into the 'head' one now. behdad On 08/16/10 09:55, Jonathan Kew wrote: It looks to me like the _get_gdef, _get_gsub, and _get_gpos functions in

Re: [HarfBuzz] are there any recent changes in harfbuzz?

2010-08-30 Thread Behdad Esfahbod
On 08/28/10 07:33, Rahul Bhalerao wrote: It is bit late to respond, yet I would like to clarify. Long back we, along with Oriya localization team, came to conclusion that OT specs for Oriya are not correct. Hence changes were made to both the fonts and pango. Now lohit, utkal, samyak are

Re: [HarfBuzz] Intro to HarfBuzz

2010-08-30 Thread Behdad Esfahbod
On 08/30/10 05:21, Tom Hacohen wrote: Dear all, My name is Tom and I work on the Hebrew and Arabic support of enlightenment.org (efl/e17). Hi Tom, Welcome to the list. Until now, I based my work on the FriBiDi shaper. I've heard the name HarfBuzz in the past, and was planning to use it

Re: [HarfBuzz] Intro to HarfBuzz

2010-08-31 Thread Behdad Esfahbod
On 08/31/10 11:18, Tom Hacohen wrote: I wonder how everything will work with FriBiDi, since currently my flow is: Split to paragraphs - Get bidi attributes per paragraph - split to lines - shape - reorder. You should break into runs that have the same direction and script, and shape each of

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-09-15 Thread Behdad Esfahbod
On 08/23/10 13:46, Jonathan Kew wrote: Hi Behdad, I notice that the code in MarkArray::apply() includes the following: hb_internal_glyph_position_t o = c-buffer-pos[c-buffer-i]; o.x_advance = 0; o.y_advance = 0; o.x_offset = base_x - mark_x; o.y_offset = base_y -

Re: [HarfBuzz] 'head' table issue

2010-09-15 Thread Behdad Esfahbod
On 08/16/10 10:30, Jonathan Kew wrote: Hi Behdad, I think there's an issue with how the 'head' table is handled in harfbuzz-ng at the moment. hb_face_create_for_tables() loads the 'head' table and calls Sanitizerhead::sanitize() on it. However, if sanitize() fails, the table gets

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-09-22 Thread Behdad Esfahbod
Hi Jonathan, I'm investigating this. Can you send me the exact version of DejaVuSansMono and the sample text reproducing this please. Thanks, behdad On 08/23/10 13:46, Jonathan Kew wrote: Hi Behdad, I notice that the code in MarkArray::apply() includes the following:

Re: [HarfBuzz] Caching of glyphmetrics and cmap data

2010-09-23 Thread Behdad Esfahbod
Hi Keith, Thanks for the effort. It's widely understood that FreeType's output is supposed to be cached. Though I was hoping that the CMAP access was at least fast enough. Anyway, there are a few problems with caching these in harfbuzz proper: 1) I really really really want to keep the

Re: [HarfBuzz] Caching of glyphmetrics and cmap data

2010-09-28 Thread Behdad Esfahbod
On 09/24/10 00:08, Keith Stribley wrote: Hi Behdad, Thanks for your quick response. On 23/09/10 21:10, Behdad Esfahbod wrote: Another, perhaps better, option is to do the caching in hb-ft.c. I think I like that even more. In this case, there will will need to be a way to store

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-09-28 Thread Behdad Esfahbod
On 09/24/10 12:15, Jonathan Kew wrote: On 23 Sep 2010, at 01:06, Behdad Esfahbod wrote: Hi Jonathan, I'm investigating this. Can you send me the exact version of DejaVuSansMono and the sample text reproducing this please. The attached version of DejaVu Sans Mono should serve. I see

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-10-01 Thread Behdad Esfahbod
src/hb-ot-layout-common-private.hh |3 +-- src/hb-ot-layout-gpos-private.hh |2 -- 2 files changed, 1 insertion(+), 4 deletions(-) New commits: commit 2841436926d6a406bd1f4a35c66a0e3c2fdbeca7 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Sep 29 12:20:36 2010 -0400 Don't

Re: [HarfBuzz] Should MarkToBase attachment zero the mark advance?

2010-10-01 Thread Behdad Esfahbod
Pushed this one out. Thanks. b On 09/24/10 12:15, Jonathan Kew wrote: On 23 Sep 2010, at 01:06, Behdad Esfahbod wrote: Hi Jonathan, I'm investigating this. Can you send me the exact version of DejaVuSansMono and the sample text reproducing this please. The attached version of DejaVu

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-10-01 Thread Behdad Esfahbod
|6 +++--- 6 files changed, 25 insertions(+), 18 deletions(-) New commits: commit ac0c1663fa6e93a5a94c88fc7497bc11ca17f0a1 Author: Behdad Esfahbod beh...@behdad.org Date: Fri Oct 1 19:09:23 2010 -0400 Avoid div-by-zero, validate upem diff --git a/src/hb-ot-head-private.hh b/src/hb-ot-head

Re: [HarfBuzz] 'head' table issue

2010-10-01 Thread Behdad Esfahbod
I pushed a fix for the overflow issue. I'll handle the caching part separately. behdad On 08/16/10 10:30, Jonathan Kew wrote: Hi Behdad, I think there's an issue with how the 'head' table is handled in harfbuzz-ng at the moment. hb_face_create_for_tables() loads the 'head' table and

Re: [HarfBuzz] unreachable code in harfbuzz HeadlessArrayOf::sanitize and GenericArrayOf::sanitize

2010-10-12 Thread Behdad Esfahbod
On 10/12/10 07:25, Jonathan Kew wrote: Hi Behdad, Please see https://bugzilla.mozilla.org/show_bug.cgi?id=603346 it's harmless, but see comment #3 there. Thanks. Responded on the bug. Fix the typo, but don't know what to do about unreachable warning. behdad JK

Re: [HarfBuzz] infinite loops in hb_ot_tag_from_language()

2010-10-12 Thread Behdad Esfahbod
I knew I need to write tests when I was writing that code... Anyway, fixed. Thanks. And I changed the repo location. Sending separate message about that. behdad On 10/12/10 06:45, Jonathan Kew wrote: Hi Behdad, There are a couple of infinite loops (they fail to increment the counter

[HarfBuzz] HarfBuzz news, please read.

2010-10-12 Thread Behdad Esfahbod
Hi all, With help from the fdo admins, I finally moved the hb-ng tree to a more prominent place. It also meant that the old tree had to move around to make room. So, effective immediately: New, being developed, HarfBuzz tree (aka harfbuzz-ng) is at: http://cgit.freedesktop.org/harfbuzz/

[HarfBuzz] Arabic/Syriac/N'ko shaper

2010-10-12 Thread Behdad Esfahbod
The Arabic/Syriac/N'ko shaper is hooked up and working now! Did some minimal testing. I'll update pango to drop the arabic-fc and syriac-fc shapers so it uses hb_shape(). Please test. There's still a few bits to put in place, but the current master makes it clear which way we are heading.

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-12 Thread Behdad Esfahbod
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3703f88b74707113e782eb6ca9a77603561760d0 Author: Behdad Esfahbod beh...@behdad.org Date: Tue Oct 12 18:34:20 2010 -0400 Step the version up to 0.2 now that Arabic shaper is in diff --git

Re: [HarfBuzz] features enumeration

2010-10-13 Thread Behdad Esfahbod
On 10/13/10 09:56, Pierre Marchand wrote: Hello, As I didn't want to allocate random amount of memory when enumerating opentype features, I added few functions in the public api. I promise to do something serious about documentation really soon. For now this will do: The

Re: [HarfBuzz] hb_font_funcs_is_immutable() is wrong

2010-10-13 Thread Behdad Esfahbod
On 10/13/10 10:04, Jonathan Kew wrote: Hi Behdad, This function, from hb-font.cc, doesn't look right to me. hb_bool_t hb_font_funcs_is_immutable (hb_font_funcs_t *ffuncs) { return ffuncs-immutable = TRUE; } I suggest removing the = TRUE here! Doh. Copy/paste error!

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-13 Thread Behdad Esfahbod
src/hb-font.cc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3111b8a0d5b38da57c0f6285aec2b92eb690188f Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 13 10:41:53 2010 -0400 Fix stupid bug, oops diff --git a/src/hb-font.cc b/src/hb-font.cc index

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-13 Thread Behdad Esfahbod
TODO | 72 ++- 1 file changed, 59 insertions(+), 13 deletions(-) New commits: commit 04a3023a66203d94b77f2d7a8d6bcdedf067e155 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 13 10:57:27 2010 -0400 Cleanup TODO

Re: [HarfBuzz] Request for quick/small Harfbuzz usage flow

2010-10-13 Thread Behdad Esfahbod
On 10/13/10 03:36, Tom Hacohen wrote: Dear all, I need harfbuzz for diacritic positioning and character shaping (in many languages), or at least this is what I know I need from Harfbuzz now, am I missing anything? Is there anything more Harfbuzz does that I might be interested in?

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-20 Thread Behdad Esfahbod
On 10/20/10 11:07, Tom Hacohen wrote: Dear all, Hi Tom, I have a couple of questions about things I don't completely understand. 1. What does the direction in hb_buffer mean (I'm only talking about LTR and RTL, TTB and BTT have more implications)? From what I've seen, it only controls

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-21 Thread Behdad Esfahbod
On 10/21/10 04:10, Tom Hacohen wrote: Language is used to do language-specific adjustments when appropriate. You typically just pass the locale or whatever your higher-level tells you (think of lang attribute in html) to hb_language_from_string. As I thought, thanks, I wasn't thinking about

Re: [HarfBuzz] Getting the number of Graphmes for a ligature

2010-10-25 Thread Behdad Esfahbod
On 10/25/10 09:25, Tom Hacohen wrote: Hey all, I wonder, is there a way to get the number of Graphmes for a ligature? I can just take the cluster index and the next cluster index (or in rtl texts the other way around) and by that find the number of items, but this means I will have to

Re: [HarfBuzz] A couple of clarifications regarding HarfBuzz

2010-10-25 Thread Behdad Esfahbod
On 10/24/10 04:50, Tom Hacohen wrote: Graphemes are what a user (of a language) considers to be one entity. Unicode defines them: http://www.unicode.org/reports/tr29/ We may add code in harfbuzz for that in the future. A cheap heuristic is to check for combining-class=0.

Re: [HarfBuzz] What's the correct Create/Destory usage of hb_ft_face/font ?

2010-10-26 Thread Behdad Esfahbod
On 10/26/10 05:58, Tom Hacohen wrote: Hey all, I don't understand what's the correct way of using those. Currently I just: hb_face = hb_ft_face_create(face, NULL); hb_font = hb_ft_font_create(face, NULL); hb_font_destroy(hb_font); hb_face_destroy(hb_face); But I think

[HarfBuzz] harfbuzz-ng: Branch 'master' - 3 commits

2010-10-26 Thread Behdad Esfahbod
: Behdad Esfahbod beh...@behdad.org Date: Tue Oct 26 11:28:14 2010 -0400 Fix blob leak diff --git a/src/hb-font.cc b/src/hb-font.cc index ba8ab0d..bd55681 100644 --- a/src/hb-font.cc +++ b/src/hb-font.cc @@ -310,7 +310,7 @@ _hb_face_for_data_closure_create (hb_blob_t *blob, unsigned int index

Re: [HarfBuzz] What's the correct Create/Destory usage of hb_ft_face/font ?

2010-10-26 Thread Behdad Esfahbod
On 10/26/10 11:18, Tom Hacohen wrote: On Tue, 2010-10-26 at 11:14 -0400, Behdad Esfahbod wrote: Can you try with master? I remember I fixed a blob leak a while ago... I'm with the latest harfbuzz from the master branch. Latest commit: 39dede9e732f78cbd092ccb3b48d77ddd66d from the 13th

[HarfBuzz] harfbuzz-ng: Branch 'master' - 2 commits

2010-10-26 Thread Behdad Esfahbod
|9 +--- 6 files changed, 154 insertions(+), 89 deletions(-) New commits: commit 248e3c2ba47889c247959e44166644872aed59ba Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 01:23:14 2010 -0400 Oops, remove extra mask setting that broke complex shaping diff --git a/src/hb-ot

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-26 Thread Behdad Esfahbod
TODO |2 -- 1 file changed, 2 deletions(-) New commits: commit 12b2d09a87adc1e1aac089cd2e09a68fb7129829 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 01:28:28 2010 -0400 Remove obsolete TODO item We don't cache any metrics internally, so the correct way to add

[HarfBuzz] harfbuzz coordinate system

2010-10-26 Thread Behdad Esfahbod
Hi all, I'm wondering, should increasing y move upwards, or downwards? Most graphics API I've seen (PS-based API being the only exception) has y moving downward. I find that more intuitive in a text layout library, so we can say: in-line glyphs are stacked in the increasing x direction, lines

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 07:28, Tom Hacohen wrote: Hey, Is it just me, or do vowels break shaping in Arabic? Pango has code to work around Arabic fonts that have no GDEF table, and no GPOS table. I've had planned to implement that in HarfBuzz but been putting it off for a while. I'll go ahead and do

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
Maybe you can attach a screenshot at least? On 10/27/10 09:19, Tom Hacohen wrote: On Wed, 2010-10-27 at 14:26 +0200, Khaled Hosny wrote: On Wed, Oct 27, 2010 at 01:28:38PM +0200, Tom Hacohen wrote: Hey, Is it just me, or do vowels break shaping in Arabic? It shouldn't, either the font is

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 09:58, Tom Hacohen wrote: On Wed, 2010-10-27 at 09:48 -0400, Behdad Esfahbod wrote: Maybe you can attach a screenshot at least? I just get isolated forms of all of them, anyhow, screenshot attached. I fixed that bug and pushed out this morning. Please check with master

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-27 Thread Behdad Esfahbod
src/hb-ot-shape-complex-arabic.cc |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit aefdb64689aab19df76590a36c4a04052a8bffdb Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 10:40:39 2010 -0400 Fix segfault with Arabic combining marks diff --git

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 09:19, Tom Hacohen wrote: because c-buffer-info[i].gproperty == 65535 So I think there's still an issue. Fixed that too. Pushed out. behdad ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-10-27 Thread Behdad Esfahbod
src/hb-ot-layout-gpos-private.hh | 124 --- 1 file changed, 3 insertions(+), 121 deletions(-) New commits: commit ea22c749c7371cf66ca44f0bfe7030aef1926edd Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 11:09:48 2010 -0400 Fix Cursive

[HarfBuzz] harfbuzz-ng: Branch 'master' - 6 commits

2010-10-27 Thread Behdad Esfahbod
+-- src/hb-ot-layout.h | 13 6 files changed, 80 insertions(+), 61 deletions(-) New commits: commit 13528d0c78cadb1f67267c9a692558caef9fdaa6 Author: Behdad Esfahbod beh...@behdad.org Date: Wed Oct 27 14:09:27 2010 -0400 Supposedly implement vertical

Re: [HarfBuzz] harfbuzz coordinate system

2010-10-28 Thread Behdad Esfahbod
On 10/27/10 15:56, James Cloos wrote: BE == Behdad Esfahbod beh...@behdad.org writes: BE I'm wondering, should increasing y move upwards, or downwards? Most BE graphics API I've seen (PS-based API being the only exception) has y BE moving downward. I find that more intuitive in a text

Re: [HarfBuzz] harfbuzz coordinate system

2010-10-28 Thread Behdad Esfahbod
On 10/28/10 20:55, Martin Hosken wrote: I don't think it matters too much which way you jump on this one so long as: Right. What adds to the confusion is that in simple text, y_offset is always zero, so you can build an entire system without discovering your error... b

Re: [HarfBuzz] harfbuzz coordinate system

2010-10-31 Thread Behdad Esfahbod
On 10/29/10 18:19, Jonathan Kew wrote: So FWIW, my preference would be to keep the y-axis pointing up. I think that's right for a text-centric API, and I don't think making a change will really gain anything. I don't completely agree, but since the two responses I got both prefer the current

Re: [HarfBuzz] build failure in hb-ot-shape-complex-arabic.cc

2010-11-02 Thread Behdad Esfahbod
Thanks Jonathan. Not intended. I try to avoid that but gcc doesn't have a switch to warn when I miss :(. Will push with my next batch. b On 11/02/10 18:19, Jonathan Kew wrote: Hi Behdad, Please remove the trailing comma from the joining-types enumeration in

[HarfBuzz] harfbuzz-ng: Branch 'master'

2010-11-02 Thread Behdad Esfahbod
src/hb-ot-shape-complex-arabic.cc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f22802431a983bd4bc60a7653b1103973c3475cb Author: Behdad Esfahbod beh...@behdad.org Date: Tue Nov 2 19:12:37 2010 -0400 Remove trailing comma diff --git a/src/hb-ot-shape-complex

Re: [HarfBuzz] build failure in hb-ot-shape-complex-arabic.cc

2010-11-02 Thread Behdad Esfahbod
Pushed this one out. By the way, you can push to the main repo now. behdad On 11/02/10 18:58, Behdad Esfahbod wrote: Thanks Jonathan. Not intended. I try to avoid that but gcc doesn't have a switch to warn when I miss :(. Will push with my next batch. b On 11/02/10 18:19, Jonathan

Re: [HarfBuzz] Optmizing code using Harfbuzz

2010-11-03 Thread Behdad Esfahbod
Hi Tom, First thing is to profile it to see where time is spent. Are you caching the shape() results? If you do that and still have problems then definitely profile and tell us about it. behdad On 11/03/10 03:47, Tom Hacohen wrote: Dear all, I'm using harfbuzz in my code, which obviously

  1   2   3   4   5   6   7   8   9   10   >