Leo,
I agree with you that big commits are hard to review and to understand what
was changed. Why not to partition them? At least I don't understand why
HARMONY-57 and HARMONY-88 were committed in one day. Integrating these two
contributions of course changed the build: wow, the build now
On 3/16/06, Stepan Mishura [EMAIL PROTECTED] wrote:
Leo,
I agree with you that big commits are hard to review and to understand what
was changed. Why not to partition them? At least I don't understand why
HARMONY-57 and HARMONY-88 were committed in one day. Integrating
these two
Don't reformat or get eclipse fixed... :)
-Original Message-
From: Richard Liang [mailto:[EMAIL PROTECTED]
Sent: Wed Mar 15 23:59:46 2006
To: harmony-dev
Subject:Subclipse Diff: Are there any way to ignore whitespace when
creating patch using Subclipse in Eclipse
There can't be anything surprising about when we get a codebase, we examine
it, we vote on it, and then it goes into svn.
As long as it goes into svn exactly as contributed (with exceptions allowed for
good reason, that we would have discussed and agreed to...). I don't see this
as a problem.
Thanks Mark -- I really object to regular builds reaching out over the
web. For now I may just make it a separate target or a simple ant
existence check.
Regards,
Tim
Mark Hindess wrote:
Mikhail,
I took a few shortcuts getting these integration done. I'm planning
to factor out the acquire
Stepan Mishura wrote:
Leo,
I agree with you that big commits are hard to review and to understand what
was changed. Why not to partition them?
They are incoming contributions that were committed in bulk and
reference the original JIRA. We have all had a chance to look at the
contributions
Hi, Mikhail,
Mikhail Loenko wrote:
Hi Paulex,
IMHO from compatibility point of view any behavior is legal.
HashMap is mostly designed for keys that do not change over time, at least
spec silent about changing the keys. So, I think implementation specsific is
allowed here.
But I think that
Hi Richard,
If you go to Window-Preferences, then look in General-Compare/Patch
there is a tick box that says Ignore white space. Ticking this may
solve some of your problems. However formatting that splits a single
line into multiple lines (where the line length is determined to be too
On 3/16/06, Stepan Mishura [EMAIL PROTECTED] wrote:
Hi Mark,
I will submit patches to improve the download process for the few
people that don't have (transparent proxy) internet access.
Please add property IdontHappyWithNetworkBuildUseLocalCopies :-)
See thread svn commit: r38617 for a
What was I concerned about?
-Original Message-
From: Mark Hindess [mailto:[EMAIL PROTECTED]
Sent: Thu Mar 16 00:36:38 2006
To: harmony-dev@incubator.apache.org
Subject:Re: svn commit: r386058 [1/49] ...
On 3/16/06, Stepan Mishura [EMAIL PROTECTED] wrote:
Leo,
I agree
On 3/16/06, Tim Ellison wrote:
Stepan Mishura wrote:
Leo,
I agree with you that big commits are hard to review and to understand
what
was changed. Why not to partition them?
They are incoming contributions that were committed in bulk and
reference the original JIRA. We have all had
On 3/16/06, Magnusson, Geir [EMAIL PROTECTED] wrote:
What was I concerned about?
...
On Mar 3, 2006 11:36 AM you wrote:
Mark Hindess wrote:
I've been spending a little time fixing up contributions that I think
are worthwhile - mostly patches that have been broken by the recent
shared
Ok. I agree actually.
I assumed because the contribution did it this way, and had been
accepted, that it had been agreed that it was ok. I will make a clear
distinction between the check and fetch targets. Only check
will be used unless the fetch is invoked explicity.
Regards,
Mark.
On
2006/3/16, Tim Ellison [EMAIL PROTECTED]:
In this case there will need be .ser files
for each platform.
I do not agree with this example.
Serialization-compatibility should be cross-platform, otherwise it does not make
much sense
Thanks,
Mikhail.
Yep. So we'll need multiple places for them anyway...
However, this is a horror if we have platform dependent serialization, isn't
it?
Geir
-Original Message-
From: Tim Ellison [mailto:[EMAIL PROTECTED]
Sent: Thu Mar 16 04:23:39 2006
To: harmony-dev@incubator.apache.org
Hi Tim,
I've reviewed my update and found I did a mistake - I occasionally
substituted in two places Security.setProperty with System.setProperty (Of
course I'll provide a patch to fix this). But this slip made me thinks how
to solve restoring testing environment in case of security properties.
Oliver Deakin wrote:
Hi Richard,
If you go to Window-Preferences, then look in General-Compare/Patch
there is a tick box that says Ignore white space. Ticking this may
solve some of your problems. However formatting that splits a single
line into multiple lines (where the line length is
Maenkova, Evgeniya G wrote:
Hi,
I would like to add that the diffs in svn commit notifications can be
changed in such cases by SVNROOT/hooks/post_commit modifying...
As far as I know, svn diff can't do that but it's possible to use
something like svn diff -r13:14 readme.txt --diff-cmd `which
Mark Hindess (JIRA) wrote:
[ http://issues.apache.org/jira/browse/HARMONY-202?page=comments#action_12370684 ]
Mark Hindess commented on HARMONY-202:
--
Looks good. All tests pass for me now. Thanks.
Non-ascii source file URITest breaking
That's great, Paulex. Then we can implement Java 5 language features for
Harmony.
Oliver Deakin wrote:
Paulex Yang wrote:
Hi,
I just find a way to use Java 5 language features in Eclipse. You can
set Compiler compliance level to 5.0, but set Generated .class
files compatibility to 1.4.
Hello Paulex,
According to Java 5 Spec, Note: great care must be exercised if mutable
objects are used as map keys. The behavior of a map is not specified if
the value of an object is changed in a manner that affects equals
comparisons while the object is a key in the map
As the
Mikhail,
You can use ant setproxy[1] task for resolving the problem. It works
for me. On the other hand, I don't think we should patch build files.
Perhaps, It will be useful to document this somewhere.
Thanks,
Vladimir.
[1] http://ant.apache.org/manual/OptionalTasks/setproxy.html
On 3/16/06,
For instance, we can add set-proxy target to depends.xml:
Index: classlib/trunk/make/depends.xml
===
--- classlib/trunk/make/depends.xml (revision 386350)
+++ classlib/trunk/make/depends.xml (working copy)
@@ -59,6 +59,8 @@
Exactly, thanks Vladimir. I've put that in at repo revision 386377
(with slightly modified property names).
Let me know if you need more.
Thanks,
Tim
Vladimir Strigun wrote:
For instance, we can add set-proxy target to depends.xml:
Index: classlib/trunk/make/depends.xml
Thanks Tim, everything works fine.
Thanks,
Vladimir.
On 3/16/06, Tim Ellison [EMAIL PROTECTED] wrote:
Exactly, thanks Vladimir. I've put that in at repo revision 386377
(with slightly modified property names).
Let me know if you need more.
Thanks,
Tim
Vladimir Strigun wrote:
For
again, guys, to be sure it's not missed:
adding -Dhttp.proxyHost=proxy -Dhttp.proxyPort=8080
to the ANT_OPTS environment variable should be
sufficient for command-line Ant without explicitly
invoking setproxy.
-Matt
--- Vladimir Strigun [EMAIL PROTECTED] wrote:
Thanks Tim, everything works
d'oh -- got it, thanks Matt.
Vladimir: If you give me the all clear I'll back-out the explicit call
to setproxy (but leave the comments in the properties file to remind
us how to do it).
Regards,
Tim
Matt Benson wrote:
again, guys, to be sure it's not missed:
adding -Dhttp.proxyHost=proxy
Mark Hindess wrote:
Stefano,
I don't really know much about gump but I'm interested to learn a
little more about it.
Gump is the, citing Leo, the most misunderstood piece of software ever.
On the surface, Gump is a nightly build system: it reads a bunch of xml
files that tell it where the
Richard Liang wrote:
Dears,
If you select Spaces only as Eclipse tab policy and you format the
Harmony source code in Eclipse, when you creating patch for the source
code, Subclipse may regard the source code as total different with the
source in SVN. Then other developers cannot know what
Oliver Deakin wrote:
Hi Richard,
If you go to Window-Preferences, then look in General-Compare/Patch
there is a tick box that says Ignore white space. Ticking this may
solve some of your problems. However formatting that splits a single
line into multiple lines (where the line length is
Mark Hindess wrote:
Our local builds now complete a two stage build. First with a
certified JDK and then with the eclipse compiler running on the VME
and deploy directory from the first stage build. They then run the
tests.
I'm also generating some reports as part of the build. The JAPI
On Thursday 16 March 2006 19:09, Stefano Mazzocchi wrote:
I *HATE*
tabs with a passion
+1
--
Chris Gray/k/ Embedded Java Solutions BE0503765045
Embedded Mobile Java, OSGihttp://www.k-embedded-java.com/
[EMAIL PROTECTED] +32 3 216 0369
Stefano Mazzocchi wrote:
Oliver Deakin wrote:
Hi Richard,
If you go to Window-Preferences, then look in General-Compare/Patch
there is a tick box that says Ignore white space. Ticking this may
solve some of your problems. However formatting that splits a single
line into multiple lines
Tim Ellison wrote:
Richard Liang wrote:
snip
Do we have any mandatory requirement about Harmony source file encoding?
or only US-ASCII is allowed. If yes, we shall document this requirement.
Any comments?
In this case the Eclipse compiler running on the build machine failed to
parse a
This is pretty cool. +1 for it
On 3/16/06, Tim Ellison [EMAIL PROTECTED] wrote:
Hey, good find Oliver. Sounds like a good idea to me.
Using those compiler options would be quite a significant change for the
project, I think we should have a vote on it first to ensure everyone is
Mark Hindess mark.hindess at googlemail.com writes:
Our local builds now complete a two stage build. First with a
certified JDK and then with the eclipse compiler running on the VME
and deploy directory from the first stage build. They then run the
tests.
This seems a good point to jump in
Hi Richard
2006/3/16, Richard Liang [EMAIL PROTECTED]:
Hello Paulex,
According to Java 5 Spec, Note: great care must be exercised if mutable
objects are used as map keys. The behavior of a map is not specified if
the value of an object is changed in a manner that affects equals
comparisons
On 3/17/06, Karan Malhi [EMAIL PROTECTED] wrote:
Hi,
Some of the methods/constructors in the API throw a NullPointerException
when a null is passed in as an argument. The spec doesnt say anything that
the method/constructor should throw a NullPointerException, neither does it
say anything
38 matches
Mail list logo
