Re: [classlib] ldap

2006-08-01 Thread George Harley
Hi Daniel, I don't think that there is any special reason for the absence of the classes you mention; the package looks to be incomplete because of lack of time. So far as I am aware there is no one actively working in this area so any contributions you could make would be a terrific help to

Re: [classlib] Testing conventions - a proposal

2006-07-26 Thread George Harley
*really* need it. Best regards, George 2006/7/20, George Harley [EMAIL PROTECTED]: Alexei Zakharov wrote: George, I remember my past experience with BeanShell - I was trying to create the custom BeanShell task for ant 1.6.1. I can't say I haven't succeeded. But I remember

Re: [testing] Peace (was: Re: svn commit: r419522 - in /incubator/harmony/enhanced/classlib/trunk/modules/nio: .classpath build.xml make/hyproperties.xml src/test/java/common/ src/test/java/common/org

2006-07-26 Thread George Harley
Richard Liang wrote: Vladimir Ivanov wrote: The more I work with our tests the more I see that managing tests via directory layout is worse than using metadata. Agree :-) I thought about three more characteristics we might want to mark-up tests with: - Platform-specific unit tests -

Re: [vote] acceptance of HARMONY-856 : assorted bug fixed for DRLVM

2006-07-26 Thread George Harley
+1 George Geir Magnusson Jr wrote: All is in order and in SVN for Harmony-856 wrt BCC and ACQ. Please vote to accept or reject this codebase into the Apache Harmony class library : [ ] + 1 Accept [ ] -1 Reject (provide reason below) Lets let this run a minimum of 3 days unless a) someone

Re: [vote] acceptance of HARMONY-948 : HTML sub-component of Swing

2006-07-26 Thread George Harley
+1 George Geir Magnusson Jr wrote: All is in order and in SVN for Harmony-948 wrt BCC and ACQ. Please vote to accept or reject this codebase into the Apache Harmony class library : [ ] + 1 Accept [ ] -1 Reject (provide reason below) Lets let this run a minimum of 3 days unless a) someone

Re: [classlib] Testing conventions - a proposal

2006-07-20 Thread George Harley
Richard Liang wrote: George Harley wrote: Richard Liang wrote: George Harley wrote: Hi, If annotations were to be used to help us categorise tests in order to simplify the definition of test configurations - what's included and excluded etc - then a core set of annotations would need

Re: [classlib] Testing conventions - a proposal

2006-07-20 Thread George Harley
Best regards, George 2006/7/19, George Harley [EMAIL PROTECTED]: Hi Alexei, I just downloaded the latest working build of TestNG 5.0 [1] and support for the jvm attribute is in there. This is not the official release build. Best regards, George [1] http://testng.org/testng-5.0.zip Alexei

Re: [classlib] Testing conventions - a proposal

2006-07-20 Thread George Harley
. When I get a chance I will try and explore your idea further. I really appreciate your input here. Best regards, George 2006/7/20, George Harley [EMAIL PROTECTED]: Richard Liang wrote: George Harley wrote: Richard Liang wrote: George Harley wrote: Hi, If annotations were

Re: [classlib] choose one [x-net] || [security] for HARMONY-536 (JSSE provider)

2006-07-19 Thread George Harley
Hi, Since the cacerts file contains root certificate information from well-known CA outfits that in at least one case is already publicly available I would hope that there is less of a legal problem than we think. For instance, take a look at the Verisign root certificates repository [1]

Re: [classlib] choose one [x-net] || [security] for HARMONY-536 (JSSE provider)

2006-07-19 Thread George Harley
Geir Magnusson Jr wrote: Tim Ellison wrote: Geir Magnusson Jr wrote: I'm integrating HARMONY-536, the JSSE provider. Two things: 1) it's contributed to go into x-net, but the package namespace is o.a.h.security.provider.jsse so I wonder if this would be better off in the security

Re: [classlib] Testing conventions - a proposal

2006-07-19 Thread George Harley
Richard Liang wrote: George Harley wrote: Hi, If annotations were to be used to help us categorise tests in order to simplify the definition of test configurations - what's included and excluded etc - then a core set of annotations would need to be agreed by the project. Consider

Re: [classlib] Testing conventions - a proposal

2006-07-19 Thread George Harley
? Thanks a lot. [1]http://testng.org/doc/ant.html Best regards, Richard George Harley wrote: Andrew Zhang wrote: On 7/18/06, George Harley [EMAIL PROTECTED] wrote: Oliver Deakin wrote: George Harley wrote: SNIP! Here the annotation on MyTestClass applies to all of its test methods. So what

Re: [classlib] Testing conventions - a proposal

2006-07-19 Thread George Harley
] Total tests run: 179, Failures: 10, Skips: 0 [testng-14] === ... Exactly the same results as with Sun JDK 1.4. Note: you may need to hatch the build.xml a little bit to achieve this. Thanks, 2006/7/19, George Harley [EMAIL PROTECTED]: Hi Richard

Re: [classlib] Why is there a c file in support/src/test/*java* ?

2006-07-19 Thread George Harley
Hi, Agreed. I think that the file is used in a couple of luni tests for java.lang.ClassLoader. No significance in the fact that it is a .c file and, as far as I can see, no special reason why it needs to be in the support folder. Best regards, George Mark Hindess wrote: On 19 July 2006

Re: [classlib] Testing conventions - a proposal

2006-07-19 Thread George Harley
in case of VM hang or crash. I suggest this only as a temporary solution. BTW, the fact that TestNG ant task still doesn't have such attributes looks like a sign for me - TestNG can be still immature in some aspects. Still comparing TestNG and JUnit. Regards, 2006/7/19, George Harley [EMAIL

Re: [classlib] Testing conventions - a proposal

2006-07-18 Thread George Harley
Oliver Deakin wrote: George Harley wrote: SNIP! Here the annotation on MyTestClass applies to all of its test methods. So what are the well-known TestNG groups that we could define for use inside Harmony ? Here are some of my initial thoughts: * type.impl -- tests that are specific

Re: [classlib] Testing conventions - a proposal

2006-07-18 Thread George Harley
Oliver Deakin wrote: George Harley wrote: Oliver Deakin wrote: George Harley wrote: SNIP! Here the annotation on MyTestClass applies to all of its test methods. So what are the well-known TestNG groups that we could define for use inside Harmony ? Here are some of my initial thoughts

Re: [classlib] Testing conventions - a proposal

2006-07-18 Thread George Harley
Andrew Zhang wrote: On 7/18/06, George Harley [EMAIL PROTECTED] wrote: Oliver Deakin wrote: George Harley wrote: SNIP! Here the annotation on MyTestClass applies to all of its test methods. So what are the well-known TestNG groups that we could define for use inside Harmony ? Here

Re: [classlib] Testing conventions - a proposal

2006-07-18 Thread George Harley
that if you intend to use the TestNG annotations approach then you will need to wait for a 5.0 VM for Harmony. Best regards, George Thanks, 2006/7/18, Andrew Zhang [EMAIL PROTECTED]: On 7/18/06, George Harley [EMAIL PROTECTED] wrote: Oliver Deakin wrote: George Harley wrote: SNIP

Re: [classlib] Testing conventions - a proposal

2006-07-18 Thread George Harley
are dependent on a 5.0 VM being available to run Harmony on. Hopefully that will materialise sometime soon. Best regards, George 2006/7/18, Andrew Zhang [EMAIL PROTECTED]: On 7/18/06, George Harley [EMAIL PROTECTED] wrote: Oliver Deakin wrote: George Harley wrote: SNIP! Here

Re: [announce] New Apache Harmony Committer : Paulex Yang

2006-07-17 Thread George Harley
This is fantastic news. Congratulations Paulex. Best regards, George Geir Magnusson Jr wrote: Please join the Apache Harmony PPMC in welcoming the project's newest committer, Paulex Yang. Mark has demonstrated the elements that help build a healthy community, namely his ability to work

Re: [classlib] Testing conventions - a proposal

2006-07-17 Thread George Harley
Andrew Zhang wrote: On 7/14/06, George Harley [EMAIL PROTECTED] wrote: Hi, If annotations were to be used to help us categorise tests in order to simplify the definition of test configurations - what's included and excluded etc - then a core set of annotations would need to be agreed

Re: [classlib] Testing conventions - a proposal

2006-07-14 Thread George Harley
, George George Harley wrote: Hi, Just seen Tim's note on test support classes and it really caught my attention as I have been mulling over this issue for a little while now. I think that it is a good time for us to return to the topic of class library test layouts. The current proposal [1

Re: [classlib] HARMONY-88 misses source file for MockJavaBean2.class

2006-07-13 Thread George Harley
. Your alternative version of the test looks great to me. Best regards, George 2006/7/13, Geir Magnusson Jr [EMAIL PROTECTED]: George Harley wrote: Hi Mikhail, You are probably already aware of this but the tests that use the SerClassLoader custom class loader result

Re: [classlib] HARMONY-88 misses source file for MockJavaBean2.class

2006-07-12 Thread George Harley
Hi Mikhail, Just seen your note. Yes, of course, I will look at this immediately. Sorry for the inconvenience. Best regards, George Mikhail Loenko wrote: Hi George! HARMONY-88 contribution contains a file MockJavaBean2.bin that seems to be a binary representation of

Re: [classlib] HARMONY-88 misses source file for MockJavaBean2.class

2006-07-12 Thread George Harley
Hi, I looked at this earlier on (soon after my first note) and found that the matter seemed to already been resolved ? Best regards, George Mikhail Loenko wrote: Hi George! HARMONY-88 contribution contains a file MockJavaBean2.bin that seems to be a binary representation of

Re: [classlib] HARMONY-88 misses source file for MockJavaBean2.class

2006-07-12 Thread George Harley
Hi Mikhail, You are probably already aware of this but the tests that use the SerClassLoader custom class loader result in a StackOverflowError when run against the RI. The overridden implementation of findResource(String) calls getResource(String) which, according to the spec, may end up

Re: [classlib] TestNG v. JUnit

2006-07-11 Thread George Harley
://testng.org/doc/documentation-main.html#annotations 3. http://testng.org/doc/documentation-main.html#test-groups 4. http://testng.org/doc/documentation-main.html#rerunning Best regards, Richard. -Nathan -Original Message- From: George Harley [mailto:[EMAIL PROTECTED] Sent: Monday

Re: [classlib][testing] excluding the failed tests

2006-07-10 Thread George Harley
Alexei Zakharov wrote: Hi, If there are really useful tests that are being unnecessarily excluded by being in the same *Test class, then you may want to consider moving the failing tests into SecureRandom3Test and excluding that -- but by the sound of it all SecureRandom tests will be failing.

Re: [classlib] Testing conventions - a proposal

2006-07-10 Thread George Harley
Alexei Zakharov wrote: Actually, there's a very valid benefit for using TestNG markers (= annotations/JavaDoc) for grouping tests; the directory structure is a tree, whereas the markers can form any slice of tests, and the sets Concerning TestNG vs JUnit. I just like to pay your attention on

Re: [vote] acceptance of HARMONY-609 : AWT, Java2D, Swing TESTS

2006-07-10 Thread George Harley
+1 -- George Geir Magnusson Jr wrote: All is in order and in SVN for Harmony-609 wrt BCC and ACQ. Please vote to accept or reject this codebase into the Apache Harmony class library : [ ] + 1 Accept [ ] -1 Reject (provide reason below) Lets let this run a minimum of 3 days unless a)

Re: [classlib] Testing conventions - a proposal

2006-07-10 Thread George Harley
-archives.apache.org/mod_mbox/incubator-harmony-dev/200607.mbox/[EMAIL PROTECTED] 2006/7/10, George Harley [EMAIL PROTECTED]: Alexei Zakharov wrote: Actually, there's a very valid benefit for using TestNG markers (= annotations/JavaDoc) for grouping tests; the directory structure is a tree, whereas

Re: [testing] Peace

2006-07-07 Thread George Harley
Tim Ellison wrote: May I tactfully suggest that we get this back to a discussion of the pros and cons of JUnit test suites and/or TestNG metadata vs. directory layout. It sounds like we all want to resolve that problem asap. Regards, Tim +1 -- George George Harley wrote: Mark

Re: [classlib] Testing conventions - a proposal

2006-07-06 Thread George Harley
Alex Blewitt wrote: On 06/07/06, Richard Liang [EMAIL PROTECTED] wrote: It seems that you're very familiar with TestNG. ;-) So would you please identify what we shall do to transfer from junit to TestNG? Thanks a lot. Me? I'm just highly opinionated :-) Hi Alex, I think we are all

Re: svn commit: r419522 - in /incubator/harmony/enhanced/classlib/trunk/modules/nio: .classpath build.xml make/hyproperties.xml src/test/java/common/ src/test/java/common/org/ src/test/java/linux/ src

2006-07-06 Thread George Harley
Hi Mark, From what I can tell this JIRA hasn't really achieved much apart from pushing code around the repository and breaking at least one patch (HARMONY-755). It would be great if you or Paulex (and everyone in fact) could comment in the [classlib] Testing conventions - a proposal thread

Re: svn commit: r419522 - in /incubator/harmony/enhanced/classlib/trunk/modules/nio: .classpath build.xml make/hyproperties.xml src/test/java/common/ src/test/java/common/org/ src/test/java/linux/ src

2006-07-06 Thread George Harley
Mark Hindess wrote: On 6 July 2006 at 12:55, George Harley [EMAIL PROTECTED] wrote: Hi Mark, From what I can tell this JIRA hasn't really achieved much apart from pushing code around the repository and breaking at least one patch (HARMONY-755). Well, obviously that wasn't my

Re: svn commit: r419522 - in /incubator/harmony/enhanced/classlib/trunk/modules/nio: .classpath build.xml make/hyproperties.xml src/test/java/common/ src/test/java/common/org/ src/test/java/linux/ src

2006-07-06 Thread George Harley
that we can get on with more valuable activities. Best regards, George George Harley wrote: Hi Mark, From what I can tell this JIRA hasn't really achieved much apart from pushing code around the repository and breaking at least one patch (HARMONY-755). It would be great if you or Paulex

Re: svn commit: r419522 - in /incubator/harmony/enhanced/classlib/trunk/modules/nio: .classpath build.xml make/hyproperties.xml src/test/java/common/ src/test/java/common/org/ src/test/java/linux/ src

2006-07-06 Thread George Harley
Mark Hindess wrote: On 6 July 2006 at 18:05, George Harley [EMAIL PROTECTED] wrote: Mark Hindess wrote: On 6 July 2006 at 12:55, George Harley [EMAIL PROTECTED] wrote: Hi Mark, From what I can tell this JIRA hasn't really achieved much apart from pushing code around

[classlib] Testing conventions - a proposal

2006-07-05 Thread George Harley
Hi, Just seen Tim's note on test support classes and it really caught my attention as I have been mulling over this issue for a little while now. I think that it is a good time for us to return to the topic of class library test layouts. The current proposal [1] sets out to segment our

Re: [announce] New Apache Harmony Committer : Weldon Washburn

2006-07-05 Thread George Harley
Congratulations ! -- George Geir Magnusson Jr wrote: Please join the Apache Harmony PPMC in welcoming the project's newest committer, Weldon Washburn. Weldon was one of the initial committers listed on the original Harmony proposal. Incubator tradition is such that listed committers be

Re: [continuum] BUILD FAILURE: Classlib/linux.ia32 Build/Test

2006-07-05 Thread George Harley
Hi, The test fails on Linux appear to have been caused by HARMONY-755 which I committed a little earlier today. I have backed out the changes and will re-open the JIRA now. Sorry for any inconvenience caused. Best regards, George Apache Harmony Build wrote: Online report :

[classlib][regex] Acknowledgement of Unicode Character Database

2006-07-04 Thread George Harley
Hi, Just noticed that the source file java.util.regex.AbstractCharClass in modules/regex contains the following Javadoc comment for the PredefinedCharacterClasses inner class: /** * character classes generated from * http://www.unicode.org/reports/tr18/ *

Re: [classlib][regex] Acknowledgement of Unicode Character Database

2006-07-04 Thread George Harley
@incubator.apache.org Subject: Re: [classlib][regex] Acknowledgement of Unicode Character Database +1 That's fine. Go for it. geir George Harley wrote: Hi, Just noticed that the source file java.util.regex.AbstractCharClass in modules/regex contains the following Javadoc comment

Re: [classlib] build file stuff

2006-07-01 Thread George Harley
Nathan Beyer wrote: Occasionally I use make/build-tests.xml to access the 'gen-reports' target. I only do this when I run a test from within a single module, instead of a full test run. Maybe there is a better or easier way. -Nathan Hi Nathan, Maybe this isn't exactly what you mean, but

Re: [classlib] Code chill for snapshot

2006-06-30 Thread George Harley
Sorry Tim, I committed 704 just before your note got downloaded to my email client. Best regards, George Tim Ellison wrote: Please hold-off any commits to classlib code for about an hour, so we can get a stable snapshot. There are two issues that are currently under investigation: - this

Re: [classlib] Exception-throwing compatibility question

2006-06-30 Thread George Harley
Mikhail Loenko wrote: For the example I've started this thread with it seems that complying the spec is more appropriate there. But probably there are other examples that caused that the doc was worded the given way George and Tim could you please comment? Thanks, Mikhail Hi Mikhail, I love

Re: [classlib][testing] excluding the failed tests

2006-06-29 Thread George Harley
: Re: [classlib][testing] excluding the failed tests George Harley wrote: Hi Geir, As you may recall, a while back I floated the idea and supplied some seed code to define all known test failing test methods in an XML file (an exclusions list) that could be used by JUnit at test run time

Re: svn commit: r417385 - in /incubator/harmony/enhanced/classlib/trunk/modules/nio: ./ make/ src/main/java/org/apache/harmony/nio/ src/main/java/org/apache/harmony/nio/internal/ src/main/native/ src/

2006-06-27 Thread George Harley
Hi Tim, Fixed by your revision 417397 change. Looks like I just chose a bad time to update from the repository. Thanks, George George Harley wrote: Hi Tim, I have started to see test errors in my local Windows XP sandbox since this commit. In particular there are three tests in the new

Re: [classlib] Help wanted!

2006-06-26 Thread George Harley
Nathan Beyer wrote: Yeah, I noticed that. Unfortunately, it can only be used luni for now, since the compiler is turning it into an interface class. The sooner we move to 1.5 class files the better; I'm tired of the weird 1.5 source to 1.4 class file behavior that's basically undefined. Hi

Re: [classlib] Help wanted!

2006-06-26 Thread George Harley
Nathan Beyer wrote: -Original Message- From: George Harley [mailto:[EMAIL PROTECTED] Nathan Beyer wrote: Yeah, I noticed that. Unfortunately, it can only be used luni for now, since the compiler is turning it into an interface class. The sooner we move

Re: svn commit: r416477 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni: ./ src/main/java/java/net/ src/test/java/tests/api/java/net/

2006-06-23 Thread George Harley
Hi Stepan, Just seen your note. This is a bit odd; seems that different tests are failing depending on the Linux distro. As has been pointed out, on Debian and Red Hat EL4 it is a question of variability with the InetAddress host name whereas you are seeing an unexpected number of aliases

Re: Eclipse Plug-in Dependencies not resolving

2006-06-20 Thread George Harley
Hi Nathan, Yes, seeing this too. Suspect that the Swing and AWT manifests are currently broken and that this is upsetting PDE. Perhaps things can be temporarily solved for you by reverting your Eclipse PDE target to a build prior to the Swing/AWT ? Assuming you have one lying around. Best

Re: [classlib][nio]NIO project cannot compile in Eclipse(Re: svn commit: r415333 ...)

2006-06-20 Thread George Harley
Hi Paulex, Sorry about that. Requested change made in revision 415600. Best regards, George Paulex Yang wrote: George, nio project cannot compile in my Eclipse after this revision, seems the MANIFEST.MF needs to add tests.util to Import-Package section as below, would you please have a

Re: Eclipse Plug-in Dependencies not resolving

2006-06-20 Thread George Harley
r415629). Regards, Tim George Harley wrote: Hi Nathan, Yes, seeing this too. Suspect that the Swing and AWT manifests are currently broken and that this is upsetting PDE. Perhaps things can be temporarily solved for you by reverting your Eclipse PDE target to a build prior to the Swing/AWT

Re: [classlib][testing]resource files: location and usage

2006-06-19 Thread George Harley
Hello Vladimir, The agreements page on the web site [1] is also of interest here although it does not dive into any details beyond asking that all resource files go under module root/src/test/resources. Seeing as you are canvassing for opinions then my shiny 2 Euro cents worth is that: *

Re: [announce] New Apache Harmony Committer : Mark Hindess

2006-06-13 Thread George Harley
Belated congratulations Mark ! -- George Geir Magnusson Jr wrote: Please join the Apache Harmony PPMC in welcoming the project's newest committer, Mark Hindess. Mark has demonstrated the elements that help build a healthy community, namely his ability to work together with others, continued

Re: [announce] New Apache Harmony Committer : Nathan Beyer

2006-06-06 Thread George Harley
Congratulations Nathan ! -- George Geir Magnusson Jr wrote: Please join the Apache Harmony PPMC in welcoming the project's newest committer, Nathan Beyer. Nathan has shown sustained dedication to the project, an ability to work well with others, and share the common vision we have for

Re: [classlib] jetty based tests

2006-05-23 Thread George Harley
demonstrates the possible way. Also are we going to create negative tests, for example, for broken server response? I think yes. Can jetty server be used for negative testing? Yes. You can send back any error. See other comments below On 5/22/06, George Harley wrote: Stepan Mishura wrote

Re: [classlib] jetty based tests

2006-05-23 Thread George Harley
-164 demonstrates the possible way. Also are we going to create negative tests, for example, for broken server response? I think yes. Can jetty server be used for negative testing? See other comments below On 5/22/06, George Harley wrote: Stepan Mishura wrote: On 5/19/06, Tim Ellison wrote

Re: [classlib] jetty based tests

2006-05-23 Thread George Harley
objects this can be done with no problems and HARMONY-164 demonstrates the possible way. Also are we going to create negative tests, for example, for broken server response? I think yes. Can jetty server be used for negative testing? See other comments below On 5/22/06, George

Re: [classlib] jetty based tests

2006-05-23 Thread George Harley
Mikhail Loenko wrote: 2006/5/23, George Harley [EMAIL PROTECTED]: Mikhail Loenko wrote: Can jetty send back for example a response consisting of the following 4 bytes: 0x00 0x01 0x02 0x03 ? Have you checked ? I'm just asking. I do not state that Hi Mikhail, I misunderstood your

Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java

2006-05-22 Thread George Harley
Stepan Mishura wrote: Hi George, On 5/19/06, George Harley wrote: Stepan Mishura wrote: [SNIP] Hi Stepan, Is your preference to separate out all remote server dependent tests (that could be made work with a locally installed server) from the normal test flow ? Yes. For instance, have

Re: [classlib] jetty based tests

2006-05-22 Thread George Harley
Stepan Mishura wrote: On 5/19/06, Tim Ellison wrote: Stepan Mishura wrote: snip I'm OK only if we separate tests with Jetty from common test suite run. Why? Because each external dependency complicates 'normal' test suite run ( I don't want to face with situation when to run Harmony

Re: [classlib] HARMONY-199 Contents

2006-05-22 Thread George Harley
Hi Miguel, A list of files that you think can be removed would be ideal. Maybe add it as a comment to the JIRA ? Thank you, George Miguel Montes wrote: George: Ok. Would you like me to send a pruned version, or a list of files to be removed? Miguel On 5/18/06, George Harley [EMAIL

Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java

2006-05-19 Thread George Harley
Hi Stepan, Yes, there is probably scope for adding some logic to this test method where - in the event of no network connection we write a message to stderr and move on. An alternative is to provide for connections to be opened up against a server on the local machine. A couple of days ago I

Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java

2006-05-19 Thread George Harley
Thanks, Mikhail 2006/5/19, George Harley [EMAIL PROTECTED]: Hi Stepan, Yes, there is probably scope for adding some logic to this test method where - in the event of no network connection we write a message to stderr and move on. An alternative is to provide for connections to be opened up

Re: svn commit: r407752 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/org/apache/harmony/luni/internal/net/www/protocol/http/HttpURLConnection.java

2006-05-19 Thread George Harley
Stepan Mishura wrote: Hi George, see below On 5/19/06, George Harley wrote: Hi Stepan, Yes, there is probably scope for adding some logic to this test method where - in the event of no network connection we write a message to stderr and move on. An alternative is to provide for connections

Re: [jira] Created: (HARMONY-479) java.io.FileInputStream and FileOutputStream might cause Finalizer thread suspending

2006-05-19 Thread George Harley
Gregory Shimansky wrote: Hello Paulex I have a question about this problem. Do you know how exception in finalizer method affects the finalizer thread that it becomes suspended? I thought that when calling finalize method the code should catch all exceptions thrown by it and ignore them.

Re: [classlib] Layout of tests in crypto module

2006-05-18 Thread George Harley
intended to be loaded by boot class loader, compiled to bin.injected Does that sound reasonable ? Best regards, George 2006/5/17, George Harley [EMAIL PROTECTED]: Mikhail Loenko wrote: 2006/5/16, George Harley [EMAIL PROTECTED]: Mikhail Loenko wrote: Hi George, see below 2006/5/16

Re: [classlib] Layout of tests in crypto module

2006-05-18 Thread George Harley
differentiating mark to a class or package name. Thanks, Mikhail 2006/5/18, George Harley [EMAIL PROTECTED]: Mikhail Loenko wrote: Hi George, I use ant to build and run the tests, so I'm likely unaware of some Eclipse problems. If we put classpath test classes to impl/java and api/java

Re: [classlib] Layout of tests in crypto module

2006-05-18 Thread George Harley
Mikhail Loenko wrote: There are classes like X509CertImpl.java in this case impl test for it would be X509CertImplImplTest which does not look very good. How about ITest ? Thanks, Mikhail Hi Mikhail, Sure, that works for me. Best regards, George 2006/5/18, George Harley [EMAIL

Re: [classlib] Layout of tests in crypto module

2006-05-17 Thread George Harley
Mikhail Loenko wrote: 2006/5/16, George Harley [EMAIL PROTECTED]: Mikhail Loenko wrote: Hi George, see below 2006/5/16, George Harley [EMAIL PROTECTED]: Hi Mikhail, I have a couple of minor comments about your proposal for a test layouts. I should have responded sooner, I know, but I

Re: [classlib] Layout of tests in crypto module

2006-05-16 Thread George Harley
Mikhail Loenko wrote: Hi George, see below 2006/5/16, George Harley [EMAIL PROTECTED]: Hi Mikhail, I have a couple of minor comments about your proposal for a test layouts. I should have responded sooner, I know, but I have suffered from a number of hardware problems in the past few weeks

Re: [continuum] BUILD FAILURE: Classlib/win.ia32 Build/Test

2006-05-16 Thread George Harley
Mark Hindess wrote: This has broken because the subant target picks up any directory matching modules/* which has a make/build.xml in it. The modules/rmi2/ make/build.xml isn't integrated so it breaks the build. Quick fix would be to rename: modules/rmi2/make/build.xml to:

Re: [RESULT] Re: [VOTE] Acceptance of HARMONY-199 : Contribution of javax.crypto and java.math

2006-05-15 Thread George Harley
Hi Geir, I'll take it. Best regards, George Geir Magnusson Jr wrote: 10 +1 votes, no others. Someone want to re-assign to themselves and bring this in? Please make sure that the initial commit is *identical* to what was contributed, and then do any tweaks, fixes, moves etc from there.

Re: [RESULT] Re: [VOTE] Acceptance of HARMONY-337 : Contribution of RMI framework

2006-05-15 Thread George Harley
Hi Geir, I'll take it. Best regards, George Geir Magnusson Jr wrote: 9 +1 votes, no others. Someone want to re-assign to themselves and bring this in? Please make sure that the initial commit is *identical* to what was contributed, and then do any tweaks, fixes, moves etc from there.

Re: [classlib] Layout of tests in crypto module

2006-05-15 Thread George Harley
Hi Mikhail, I have a couple of minor comments about your proposal for a test layouts. I should have responded sooner, I know, but I have suffered from a number of hardware problems in the past few weeks that slowed things down somewhat for me. Anyway, it's all great but it would be nice to

Re: [classlib] Exception throwing compatibility

2006-05-12 Thread George Harley
. On 5/11/06, Richard Liang [EMAIL PROTECTED] wrote: George Harley wrote: Hi, I would like to start a little discussion around JIRA issue 436 [1] which deals with exception throwing compatibility between Harmony and the RI. I feel it is important

Re: [classlib] Exception throwing compatibility

2006-05-12 Thread George Harley
Chris Gray wrote: On Friday 12 May 2006 11:37, George Harley wrote: Nathan Beyer wrote: Note, the RI is NOT throwing ArrayIndexOutOfBoundsExceptions, it is just letting them happen via invalid array look ups, but in these cases, the specification is marked

Re: [classlib] Exception throwing compatibility

2006-05-12 Thread George Harley
Mikhail Loenko wrote: 2006/5/12, George Harley [EMAIL PROTECTED]: It sounds like there are as many interpretations of the guidelines as their are correspondents on this topic :-) My suggested change would be that we state that Harmony class library code should throw exceptions of the same

Re: [VOTE] Acceptance of HARMONY-211 : Contribution of java.rmi

2006-05-11 Thread George Harley
+1 George Geir Magnusson Jr wrote: I have received the ACQs and the BCC for Harmony-211 in paper form and have reviewed them, so I can assert that the critical provenance paperwork is in order. It is not in SVN yet, but I wanted to get this vote going at the same time as the Intel

Re: [VOTE] Acceptance of HARMONY-256 : Contribution of DNS service provider for JNDI classlibrary code

2006-05-11 Thread George Harley
+1 George Geir Magnusson Jr wrote: I have received the ACQs and the BCC for Harmony-256, so I can assert that the critical provenance paperwork is in order and in SVN. Please vote to accept or reject this codebase into the Apache Harmony class library : [ ] + 1 Accept [ ] -1 Reject

Re: [VOTE] Acceptance of HARMONY-337 : Contribution of RMI framework

2006-05-11 Thread George Harley
+1 George Geir Magnusson Jr wrote: I have received the ACQs and the BCC for Harmony-337, so I can assert that the critical provenance paperwork is in order and in SVN. This is the contribution from Intel. Please vote to accept or reject this codebase into the Apache Harmony class

[classlib] Layout of tests in beans module

2006-05-10 Thread George Harley
Hi, Just a heads up to you all (and especially anyone working in beans just now) that I would like to make some changes to src/tests in the beans module in the next day or so. Proposed changes are similar to the tidy ups that have taken place in archive, jndi, rmi, logging, prefs etc over

[classlib] Exception throwing compatibility

2006-05-10 Thread George Harley
Hi, I would like to start a little discussion around JIRA issue 436 [1] which deals with exception throwing compatibility between Harmony and the RI. I feel it is important to reach a concrete agreement on this as so far all of the participants in the issue seem to disagree about the

Re: [classlib] Testing

2006-04-27 Thread George Harley
Geir Magnusson Jr wrote: Geir Magnusson Jr wrote: George Harley wrote: Of course, the text module has only implementation-independent tests that designed to be run from classpath. For modules that have got implementation-specific tests then I suppose we could use something like

Re: [classlib] Testing

2006-04-27 Thread George Harley
Geir Magnusson Jr wrote: George Harley wrote: Geir Magnusson Jr wrote: Geir Magnusson Jr wrote: George Harley wrote: Of course, the text module has only implementation-independent tests that designed to be run from classpath. For modules that have got implementation-specific tests

Re: [classlib] Testing

2006-04-27 Thread George Harley
George Harley wrote: Geir Magnusson Jr wrote: George Harley wrote: Geir Magnusson Jr wrote: Geir Magnusson Jr wrote: George Harley wrote: Of course, the text module has only implementation-independent tests that designed to be run from classpath. For modules that have got

Re: [VOTE] Acceptance of HARMONY-114 : rough draft of files that glue Harmony Class Lib to JCHEVM native methods

2006-04-27 Thread George Harley
+1 George Geir Magnusson Jr wrote: We have all the docs for HARMONY-114 and they are in SVN Please vote to accept or reject this codebase into the Apache Harmony class library : [ ] + 1 Accept [ ] -1 Reject (provide reason below) Lets let this run 3 days unless a) someone states they

Re: [classlib] Testing

2006-04-26 Thread George Harley
org.apache.harmony.[module].tests.impl.[package under test] or org.apache.harmony.[module].tests.internal.[package under test] etc. I've got no preference. Best regards, George [1] http://incubator.apache.org/harmony/subcomponents/classlibrary/pkgnaming.html 2006/3/24, George Harley [EMAIL PROTECTED

Re: [jira] Assigned: (HARMONY-353) improvements to junit test method usage

2006-04-26 Thread George Harley
Mark Hindess wrote: On 26 April 2006 at 14:50, Stepan Mishura [EMAIL PROTECTED] wrote: Hi Mark, Update 396968 renamed tests in 'text' module. Could you provide a new patch for this module? It should just be: sed

Re: Classpath setting for Eclipse(was Re: [jira] Resolved: (HARMONY-349) The currency field of DecimalFormatSymbols is not deserialized properly)

2006-04-20 Thread George Harley
output=bin/resources/test kind=src path=src/test/resources/ classpathentry output=bin/resources/main kind=src path=src/main/resources/ George Harley (JIRA) wrote: [ http://issues.apache.org/jira/browse/HARMONY-349?page=all ] George Harley resolved HARMONY-349

Re: Copying resource files - what for?

2006-04-20 Thread George Harley
Hi Stepan, As I recall it ( I've not my morning coffee yet so it could get a bit unreliable here :-) ) the motivation for wanting resource files on the classpath was to enable serialization data files to be read in by test programs without depending on specific file locations. Copying such

Re: Copying resource files - what for?

2006-04-20 Thread George Harley
Paulex Yang wrote: Stepan +1. I just proposed similar modification to classpath of each modules in another thread, which will make the IDE(Eclipse at least) user easier to run test. Hi Paulex, Your proposed modification to the Eclipse .classpath file doesn't add src/test/resources to the

Re: Copying resource files - what for?

2006-04-20 Thread George Harley
Mark Hindess wrote: I suspect inclusion of the resource files (with path renaming) could be handled by a zip/tar task rather than by copying every time the tests are run. So I don't think this is a good reason. Regards, Mark. Hi Mark, The resource files don't get copied every time the

Re: Copying resource files - what for?

2006-04-20 Thread George Harley
Hi Mark, Sorry, I misunderstood your append. Please ignore my response. I really need to go for a coffee :-) Best regards, George George Harley wrote: Mark Hindess wrote: I suspect inclusion of the resource files (with path renaming) could be handled by a zip/tar task rather than

Re: Classpath setting for Eclipse(was Re: [jira] Resolved: (HARMONY-349) The currency field of DecimalFormatSymbols is not deserialized properly)

2006-04-20 Thread George Harley
environment is Eclipse 3.2 M5 on WinXP If this issue can be resolved, I'm fine to output them directly to existing bin/test directory. George Harley wrote: Hi Paulex, Adding new Eclipse source folders to a module to cater for the resources sounds good to me, but I don't understand the need to have

Re: Classpath setting for Eclipse(was Re: [jira] Resolved: (HARMONY-349) The currency field of DecimalFormatSymbols is not deserialized properly)

2006-04-20 Thread George Harley
regards, George George Harley wrote: Paulex Yang wrote: Well, George, you caught me;) I tried your solution on TEXT module at first, but for some unknown reasons, Eclipse refused to compile according to the modification and outputs: Cannot nest output folder 'text/bin/main' inside output folder

Re: Copying resource files - what for?

2006-04-20 Thread George Harley
Stepan Mishura wrote: On 4/20/06, George Harley wrote: Hi Stepan, As I recall it ( I've not my morning coffee yet so it could get a bit unreliable here :-) ) the motivation for wanting resource files on the classpath was to enable serialization data files to be read in by test programs

Re: Classpath setting for Eclipse(was Re: [jira] Resolved: (HARMONY-349) The currency field of DecimalFormatSymbols is not deserialized properly)

2006-04-20 Thread George Harley
Paulex Yang wrote: George Harley wrote: Hi Paulex, I pressed send a bit too soon there. This is the sort of classpath set up I was referring to in the previous message. Please note the bottom classpathentry element which I think specifies the default output folder for a project

  1   2   >