Re: [Haskell-cafe] Too much inlining on text package

2012-04-08 Thread Michael Snoyman
On Apr 8, 2012 8:47 AM, Bryan Oapos;Sullivan b...@serpentine.com wrote: On Sun, Mar 18, 2012 at 12:02 AM, Michael Snoyman mich...@snoyman.com wrote: OK, issue created: https://github.com/bos/text/issues/19 I fixed the too-much-inlining bug tonight. As a bonus, Text literals are now decoded

Re: [Haskell-cafe] Too much inlining on text package

2012-04-08 Thread Felipe Almeida Lessa
On Sun, Apr 8, 2012 at 2:47 AM, Bryan O'Sullivan b...@serpentine.com wrote: I fixed the too-much-inlining bug tonight. As a bonus, Text literals are now decoded straight from GHC's packed encoding, without an intermediate step through String. Generated code now looks like this at -O and

Re: [Haskell-cafe] Too much inlining on text package

2012-04-07 Thread Bryan O'Sullivan
On Sun, Mar 18, 2012 at 12:02 AM, Michael Snoyman mich...@snoyman.comwrote: OK, issue created: https://github.com/bos/text/issues/19 I fixed the too-much-inlining bughttps://github.com/bos/text/commit/2b2cb084c4689c06f1a7851ff8eb1e412eb02c1btonight. As a bonus, Text literals are now decoded

Re: [Haskell-cafe] Too much inlining on text package

2012-03-18 Thread Michael Snoyman
On Sat, Mar 17, 2012 at 1:28 AM, Johan Tibell johan.tib...@gmail.com wrote: On Fri, Mar 16, 2012 at 3:48 PM, Aleksey Khudyakov alexey.sklad...@gmail.com wrote: On 17.03.2012 02:24, Johan Tibell wrote: I suggest you file a bug. :) I'm way too lazy for that. Also I don't want to steal joy of

[Haskell-cafe] Too much inlining on text package

2012-03-16 Thread Felipe Almeida Lessa
Hello! tl;dr: text package's pack function is creating huge chunks of code everywhere. Michael Snoyman and I have been trying to nail the performance problems of persistent's Template Haskell code -- GHC was taking a lot of memory and CPU time to compile these. What we found out is that the

Re: [Haskell-cafe] Too much inlining on text package

2012-03-16 Thread Aleksey Khudyakov
On 16.03.2012 17:41, Felipe Almeida Lessa wrote: Does anyone have any ideas why GHC is inlining so much code everywhere? While everything I said here was tested on GHC 7.0, we have evidence that GHC 7.4 suffers from the same problem. We don't know about GHC 6.12, though. This seems to be a

Re: [Haskell-cafe] Too much inlining on text package

2012-03-16 Thread wren ng thornton
On 3/16/12 12:22 PM, Aleksey Khudyakov wrote: Disclaimer. I'm no expert in text internals. Because it's told to do so. This is an unfortunate feature of stream fusion. It does eliminate intermediate data structures but it requires that everything is inlined. There are ways of mitigating

Re: [Haskell-cafe] Too much inlining on text package

2012-03-16 Thread Aleksey Khudyakov
On 17.03.2012 01:51, wren ng thornton wrote: On 3/16/12 12:22 PM, Aleksey Khudyakov wrote: Disclaimer. I'm no expert in text internals. Because it's told to do so. This is an unfortunate feature of stream fusion. It does eliminate intermediate data structures but it requires that everything is

Re: [Haskell-cafe] Too much inlining on text package

2012-03-16 Thread Johan Tibell
I suggest you file a bug. :) https://github.com/bos/text/issues -- Johan ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe

Re: [Haskell-cafe] Too much inlining on text package

2012-03-16 Thread Aleksey Khudyakov
On 17.03.2012 02:24, Johan Tibell wrote: I suggest you file a bug. :) I'm way too lazy for that. Also I don't want to steal joy of reporting a bug from people who actually suffer from it ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org

Re: [Haskell-cafe] Too much inlining on text package

2012-03-16 Thread Johan Tibell
On Fri, Mar 16, 2012 at 3:48 PM, Aleksey Khudyakov alexey.sklad...@gmail.com wrote: On 17.03.2012 02:24, Johan Tibell wrote: I suggest you file a bug. :) I'm way too lazy for that. Also I don't want to steal joy of reporting a bug from people who actually suffer from it I meant you as in