Re: [Haskell-cafe] Possible FGL bug

2009-11-26 Thread Ivan Lazar Miljenovic
Well, I've made two changes, either of which might have done the trick... 1) Sort the lists of nodes and edge; 2) Remove multiple edges (that is, have at most one edge f - t). The latter requirement was because the property I was testing only worked if there were no multiple edges. Either way,

Re: [Haskell-cafe] Possible FGL bug

2009-11-25 Thread Neil Brown
It looks like a bug to me. Can you show an exact list of nodes and edges that is causing mkGraph to fail? Or is that what you have displayed, and I can't parse it properly? Thanks, Neil. Ivan Lazar Miljenovic wrote: When developing my QuickCheck-2 test-suite for graphviz, I wrote the

Re: [Haskell-cafe] Possible FGL bug

2009-11-25 Thread Ivan Lazar Miljenovic
(Sorry for sending this to you twice Neil, I forgot to CC -cafe). Neil Brown nc...@kent.ac.uk writes: It looks like a bug to me. Can you show an exact list of nodes and edges that is causing mkGraph to fail? Or is that what you have displayed, and I can't parse it properly? That's what I

Re: [Haskell-cafe] Possible FGL bug

2009-11-25 Thread David Menendez
On Wed, Nov 25, 2009 at 6:28 AM, Neil Brown nc...@kent.ac.uk wrote: It looks like a bug to me.  Can you show an exact list of nodes and edges that is causing mkGraph to fail?  Or is that what you have displayed, and I can't parse it properly? From what I can tell, insEdge inserts an edge

Re: [Haskell-cafe] Possible FGL bug

2009-11-25 Thread Neil Brown
David Menendez wrote: From what I can tell, insEdge inserts an edge between two nodes which are already in the graph. The code is calling insEdge on arbitrarily-labeled nodes, which may not exist in the graph. That's what I thought initially, but in fact what it is doing is exactly what you

Re: [Haskell-cafe] Possible FGL bug

2009-11-25 Thread David Menendez
On Wed, Nov 25, 2009 at 11:02 AM, Neil Brown nc...@kent.ac.uk wrote: David Menendez wrote: From what I can tell, insEdge inserts an edge between two nodes which are already in the graph. The code is calling insEdge on arbitrarily-labeled nodes, which may not exist in the graph. That's what

[Haskell-cafe] Possible FGL bug

2009-11-24 Thread Ivan Lazar Miljenovic
When developing my QuickCheck-2 test-suite for graphviz, I wrote the following Arbitrary instance for FGL graphs (which needs FlexibleInstances): , | instance (Graph g, Arbitrary n, Arbitrary e, Show n, Show e) = Arbitrary (g n e) where | arbitrary = do ns - liftM nub arbitrary |