Re: [Haskell-cafe] hslogger bugs or features - patches

2009-02-16 Thread Marc Weber
You didn't notice setHandlers? -- | Set the 'Logger'\'s list of handlers to the list supplied. -- All existing handlers are removed first. setHandlers :: LogHandler a = [a] - Logger - Logger It is perfectly valid to set the root logger's handlers to [] if you want it to do nothing

Re: [Haskell-cafe] hslogger bugs or features - patches

2009-02-03 Thread John Goerzen
Marc Weber wrote: I've written some patches increasing speed by 30%. See the benchmark. Hi Marc, Patches are always great to see! Where is this benchmark? Can you separate out your speed changes (which I take it have no impact on functionality or API) from your other changes? I am not

Re: [Haskell-cafe] hslogger bugs or features - patches

2009-02-03 Thread Marc Weber
Hi John, Yes, a NotSet corresponds to my new Nothing setting. Proably you're right that adding that would have been enogh. API changes: Probably you're talking about the introduction of those classes? The idea was to not have to split that String over and over again. This way I thought you could

Re: [Haskell-cafe] hslogger bugs or features - patches

2009-02-03 Thread John Goerzen
Hi Marc, I have pushed to my hslogger repo the optional priority for a logger support that we talked about, which is the Haskell version of Python's NOTSET. It is currently untested and represents only a minor API change. Please take a look and let me know your thoughts. It adds one new

Re: [Haskell-cafe] hslogger bugs or features - patches

2009-02-03 Thread John Goerzen
On Tue, Feb 03, 2009 at 02:55:15PM -0600, John Goerzen wrote: I looked at your git repo, but I'm not going to pull anything from it right this minute. I would consider your performance change, but it was wrapped up with half a dozen other things in a single commit so I couldn't extract just

Re: [Haskell-cafe] hslogger bugs or features - patches

2009-02-02 Thread Marc Weber
== issue 1 That's not the most awkward thing: When logging to A.B.C hslogger does add 3 loggers to the global logger Map: A A.B A.B.C all three inheriting the default priority level of the default