Re: Haskell Platform proposal: Add case-insensitive

2013-02-11 Thread Gregory Collins
Today is the deadline for reviews. As Mark summarized over the weekend, looks like the consensus is "+1" with the possible exception that case-insensitive depends on hashable which hasn't yet been proposed for the platform. IIRC Johan has some plans to release a hashable-1.3 very soon that will res

Re: Haskell Platform proposal: Add case-insensitive

2013-01-31 Thread Gregory Collins
It deserves its own proposal. On Thu, Jan 31, 2013 at 9:01 PM, wren ng thornton wrote: > On 1/30/13 6:36 PM, Bas van Dijk wrote: > >> I just realized one complication: case-insensitive depends on hashable >> which is not in the HP. >> >> I think hashable should also be proposed for the HP: >> >

Re: Haskell Platform proposal: Add case-insensitive

2013-01-31 Thread wren ng thornton
On 1/30/13 6:36 PM, Bas van Dijk wrote: I just realized one complication: case-insensitive depends on hashable which is not in the HP. I think hashable should also be proposed for the HP: I agree. Should we make this a separate proposal, or just keep it as a subproposal of adding case-insensi

Re: Haskell Platform proposal: Add case-insensitive

2013-01-30 Thread Gregory Collins
On Wed, Jan 30, 2013 at 11:36 PM, Bas van Dijk wrote: > > The only function which could be controversial is: > > hash :: Hashable a => a -> Int > > since that function could give different results on different > application runs when the environment variable HASHABLE_SALT is set to > "random". H

Re: Haskell Platform proposal: Add case-insensitive

2013-01-30 Thread Bas van Dijk
On 11 January 2013 21:00, Gregory Collins wrote: > Hi all, > > First: Bas, would you support making case-insensitive a Haskell platform > package? > > Assuming you say yes, I'd like to propose it for inclusion in the Haskell > platform. The wiki page for this proposal is here: > > http://trac.

Re: Haskell Platform proposal: Add case-insensitive

2013-01-28 Thread Bas van Dijk
I released case-insensitive-1.0: http://hackage.haskell.org/package/case-insensitive-1.0 Bas ___ Haskell-platform mailing list Haskell-platform@projects.haskell.org http://projects.haskell.org/cgi-bin/mailman/listinfo/haskell-platform

Re: Haskell Platform proposal: Add case-insensitive

2013-01-28 Thread Bas van Dijk
Adding the following rewrite rule makes the "case-insensitve" benchmark as fast as the "no-class" benchmark: {-# RULES "mk/ByteString" forall (bs :: B.ByteString). mk bs = CI bs (foldCaseBS bs) #-} foldCaseBS :: B.ByteString -> B.ByteString foldCaseBS bs = B.map toLower8' bs where t

Re: Haskell Platform proposal: Add case-insensitive

2013-01-26 Thread Simon Hengel
On Sat, Jan 26, 2013 at 08:38:44PM +, Ben Millwood wrote: > One thing I would regard as nice-to-have and worth mentioning while > we have the review process here: a ChangeLog with (at least) the API > changes to each version documented. I second this. Would it make sense to extend the package

Re: Haskell Platform proposal: Add case-insensitive

2013-01-26 Thread Simon Hengel
On Fri, Jan 11, 2013 at 11:43:56PM +0100, Bas van Dijk wrote: > On 11 January 2013 21:00, Gregory Collins wrote: > > First: Bas, would you support making case-insensitive a Haskell platform > > package? > > Yes, I would support that. > > > Assuming you say yes, I'd like to propose it for inclusi

Re: Haskell Platform proposal: Add case-insensitive

2013-01-26 Thread Ben Millwood
(Oh dear, I sent the below e-mail from the wrong address /again/. Will take this as a cue to faff with my mail client settings, and in the meanwhile apologise to Gregory and Bas for the duplication; please do not reply to my address at srcf.net) On Fri, Jan 11, 2013 at 03:00:58PM -0500, Gregor

Re: Haskell Platform proposal: Add case-insensitive

2013-01-26 Thread Ben Millwood
On Fri, Jan 11, 2013 at 03:00:58PM -0500, Gregory Collins wrote: Hi all, First: Bas, would you support making case-insensitive a Haskell platform package? Assuming you say yes, I'd like to propose it for inclusion in the Haskell platform. The wiki page for this proposal is here: http://trac

Re: Haskell Platform proposal: Add case-insensitive

2013-01-26 Thread Bas van Dijk
On 26 January 2013 19:31, Bas van Dijk wrote: > Any ideas how to improve this? It also doesn't help using a rewrite rule to not go via the type class: {-# RULES "mk/ByteString" forall (bs :: B.ByteString). mk bs = CI bs (B.map toLower8 bs) #-} and modifying the benchmark so that the rule fi

Re: Haskell Platform proposal: Add case-insensitive

2013-01-26 Thread Bas van Dijk
I added a simple benchmark: https://github.com/basvandijk/case-insensitive/blob/hp/bench/bench.hs Unfortunately it shows some negative results: $ cabal configure --enable-benchmarks $ echo -n "performance" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor $ cabal build && \ dist/build/b

Re: Haskell Platform proposal: Add case-insensitive

2013-01-26 Thread Bas van Dijk
On 21 January 2013 21:03, Ganesh Sittampalam wrote: > I couldn't spot any tests. Some ideas: > > - It uses a few different implementations of toLower (Data.Char, Text, > toLower8) depending on how it is being used. Those implementations could > be tested against each other. > > - Some concrete tes

Re: Haskell Platform proposal: Add case-insensitive

2013-01-21 Thread Isaac Dupree
On 01/21/2013 05:21 PM, Ivan Lazar Miljenovic wrote: Is there any particular reason for this library to be in the Platform? See the proposal: http://trac.haskell.org/haskell-platform/wiki/Proposals/case-insensitive#Rationale "Rationale Used whenever you need a case-insensitive comparison of t

Re: Haskell Platform proposal: Add case-insensitive

2013-01-21 Thread Ivan Lazar Miljenovic
On 22 January 2013 02:00, Gregory Collins wrote: > > On Fri, Jan 11, 2013 at 9:00 PM, Gregory Collins > wrote: >> >> Any proposals for deadlines? Mark? > > > P.S. all: I've set the review deadline to Feb 10. Is there any particular reason for this library to be in the Platform? > > G > -- > Gre

Re: Haskell Platform proposal: Add case-insensitive

2013-01-21 Thread Ganesh Sittampalam
On 11/01/2013 20:00, Gregory Collins wrote: > Hi all, > > First: Bas, would you support making case-insensitive a Haskell platform > package? > > Assuming you say yes, I'd like to propose it for inclusion in the > Haskell platform. The wiki page for this proposal is here: > > http://trac.has

Re: Haskell Platform proposal: Add case-insensitive

2013-01-21 Thread Gregory Collins
On Fri, Jan 11, 2013 at 9:00 PM, Gregory Collins wrote: > Any proposals for deadlines? Mark? P.S. all: I've set the review deadline to Feb 10. G -- Gregory Collins ___ Haskell-platform mailing list Haskell-platform@projects.haskell.org http://projec

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-21 Thread Bas van Dijk
On 21 January 2013 00:29, Mark Lentczner wrote: > In 0.4.0.2 and earlier, it was mapping Data.Char's toLower for all types > except Text (where it was using Text's toCaseFold) > From 0.4.0.3 and on, it is using Text's toCaseFold for all types, except > ByteString, where it uses it's own toLower fu

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-20 Thread Mark Lentczner
Okay, my bad - case-insensitive *IS* doing the right thing for ByteString. (At least if you believe that treating ByteString as ISO-8859-1 encoded is the right thing!) However, note that it is folding two different ways: In 0.4.0.2 and earlier, it was mapping Data.Char's toLower for all types exc

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-20 Thread Ben Millwood
On Sun, Jan 20, 2013 at 08:21:32AM -0800, Mark Lentczner wrote: On Mon, Jan 14, 2013 at 9:43 AM, Gregory Collins wrote: The bytestring instances are what it's most often used for! The haddocks warn about this issue. And: yes, we do want an ASCII case fold. If we didn't, we'd be using Text. N

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-20 Thread Mark Lentczner
On Mon, Jan 14, 2013 at 9:43 AM, Gregory Collins wrote: > The bytestring instances are what it's most often used for! The haddocks > warn about this issue. And: yes, we do want an ASCII case fold. If we > didn't, we'd be using Text. > Note: case-insensitive provides ASCII case folding when used o

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Bas van Dijk
On Jan 15, 2013 12:29 AM, "Gregory Collins" wrote: > > On Mon, Jan 14, 2013 at 2:24 PM, Bas van Dijk wrote: >> >> Something else: according to the HP procedure proposals should be >> discussed on the libraries list. Gregory: could you start a new >> discussion there? > > > libraries@ is already o

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Gregory Collins
On Mon, Jan 14, 2013 at 2:24 PM, Bas van Dijk wrote: > Something else: according to the HP procedure proposals should be > discussed on the libraries list. Gregory: could you start a new > discussion there? > libraries@ is already on this thread. G -- Gregory Collins _

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Bas van Dijk
On 14 January 2013 18:20, Henning Thielemann wrote: > > On Mon, 14 Jan 2013, Ben Millwood wrote: > >> In response to this, I ask you: is compatibility with the platform really >> a goal for your live-sequencer? Would the live-sequencer benefit >> particularly from use of the case-insensitive packa

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Gregory Collins
On Mon, Jan 14, 2013 at 12:20 PM, Henning Thielemann < lemm...@henning-thielemann.de> wrote: > I think it should import ByteString.Char instead of ByteString. That's a type synonym, the distinction doesn't matter here. G -- Gregory Collins ___ Haske

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Gregory Collins
On Mon, Jan 14, 2013 at 11:29 AM, Ben Millwood wrote: > This is easily fixed, although may be controversial: remove the ByteString > instances. The bytestring instances are what it's most often used for! The haddocks warn about this issue. And: yes, we do want an ASCII case fold. If we didn't,

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Henning Thielemann
On Mon, 14 Jan 2013, Ben Millwood wrote: In response to this, I ask you: is compatibility with the platform really a goal for your live-sequencer? Would the live-sequencer benefit particularly from use of the case-insensitive package? Would making the case-insensitive package Haskell2010 enab

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Brandon Allbery
On Mon, Jan 14, 2013 at 11:31 AM, Ben Millwood wrote: > I don't think other compilers are not forthcoming because GHC dominates > the ecosystem. I think GHC dominates the ecosystem because other compilers > are not forthcoming. If people who are really developing an alternative > compiler come for

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Ben Millwood
I think that the Haskell Platform should respond to genuine, rather than theoretical, demand for portability. At the moment it looks like portability is work that no-one would actually benefit from. I don't think other compilers are not forthcoming because GHC dominates the ecosystem. I think

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-14 Thread Ben Millwood
I think that the Haskell Platform should respond to genuine, rather than theoretical, demand for portability. At the moment it looks like portability is work that no-one would actually benefit from. I don't think other compilers are not forthcoming because GHC dominates the ecosystem. I think

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-13 Thread Henning Thielemann
On Sat, 12 Jan 2013, Roman Cheplyaka wrote: * Henning Thielemann [2013-01-12 13:42:56+0100] If you can easily avoid using an extension, like in the case of the TypeSynonymInstances and FlexibleInstances in case-insensitive then this seems better to me, than adding FlexibleInstances to all Ha

Re: HP Package Requirements (was: Haskell Platform proposal: Add case-insensitive)

2013-01-13 Thread Roman Cheplyaka
* Gregory Collins [2013-01-13 08:55:32-0500] > At this point I think the argument for standards breaks down > altogether because there's only one conformant Haskell 2010 implementation. JHC are UHC are pretty close to Haskell 2010. Roman ___ Haskell-p

Re: HP Package Requirements (was: Haskell Platform proposal: Add case-insensitive)

2013-01-13 Thread Gregory Collins
On Sat, Jan 12, 2013 at 8:07 AM, Herbert Valerio Riedel wrote: > | Every package should fulfil the following requirements. Any > | requirements that are not met must be clearly explained and justified > | in the proposal. > | > | [...] > | > | - Compile on all operating systems and compilers that

Re: Haskell Platform proposal: Add case-insensitive

2013-01-12 Thread wren ng thornton
On 1/12/13 7:08 AM, Roman Cheplyaka wrote: I agree that this situation is sad, but package authors are the last ones to blame. Instead of needlessly constraining the code we write, it would be much better to update the Haskell standard to reflect the state of modern Haskell. Indeed. At the very

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-12 Thread Roman Cheplyaka
* Henning Thielemann [2013-01-12 13:42:56+0100] > > On Sat, 12 Jan 2013, Roman Cheplyaka wrote: > > >* Henning Thielemann [2013-01-12 > >12:40:22+0100] > >>On Sat, 12 Jan 2013, Roman Cheplyaka wrote: > >> > >>Ok, I like to request this for the whole platform. :-) > > > >This is easier to say t

HP Package Requirements (was: Haskell Platform proposal: Add case-insensitive)

2013-01-12 Thread Herbert Valerio Riedel
Roman Cheplyaka writes: [...] > There should be a policy regarding standard compliance of the platform > packages. > > The status quo is that a large part of the platform is not Haskell2010, > and converting it to Haskell2010 does not seem feasible. > > So the policy seems to be that the platfor

Re: Haskell Platform proposal: Add case-insensitive and Haskell 98/2010 compliance

2013-01-12 Thread Henning Thielemann
On Sat, 12 Jan 2013, Roman Cheplyaka wrote: * Henning Thielemann [2013-01-12 12:40:22+0100] On Sat, 12 Jan 2013, Roman Cheplyaka wrote: Ok, I like to request this for the whole platform. :-) This is easier to say than to do :) E.g. here's the result of a quick grep of the bytestring sourc

Re: Haskell Platform proposal: Add case-insensitive

2013-01-12 Thread Roman Cheplyaka
* Henning Thielemann [2013-01-12 12:40:22+0100] > On Sat, 12 Jan 2013, Roman Cheplyaka wrote: > > >* Henning Thielemann [2013-01-12 > >11:17:40+0100] > >> However, if the package is included in the platform I would prefer > >>to have it converted to plain Haskell 98 first, which should not be >

Re: Haskell Platform proposal: Add case-insensitive

2013-01-12 Thread Henning Thielemann
On Sat, 12 Jan 2013, Roman Cheplyaka wrote: * Henning Thielemann [2013-01-12 11:17:40+0100] However, if the package is included in the platform I would prefer to have it converted to plain Haskell 98 first, which should not be too hard. IMO, such requests shouldn't be made on per-package b

Re: Haskell Platform proposal: Add case-insensitive

2013-01-12 Thread Roman Cheplyaka
* Henning Thielemann [2013-01-12 11:17:40+0100] > However, if the package is included in the platform I would prefer > to have it converted to plain Haskell 98 first, which should not be > too hard. IMO, such requests shouldn't be made on per-package basis. There should be a policy regarding st

Re: Haskell Platform proposal: Add case-insensitive

2013-01-12 Thread Henning Thielemann
On Fri, 11 Jan 2013, Gregory Collins wrote: First: Bas, would you support making case-insensitive a Haskell platform package? Assuming you say yes, I'd like to propose it for inclusion in the Haskell platform. The wiki page for this proposal is here:     http://trac.haskell.org/haskell-platf

Re: Haskell Platform proposal: Add case-insensitive

2013-01-11 Thread Bardur Arantsson
On 01/11/2013 11:43 PM, Bas van Dijk wrote: > On 11 January 2013 21:00, Gregory Collins wrote: >> First: Bas, would you support making case-insensitive a Haskell platform >> package? > > Yes, I would support that. > >> Assuming you say yes, I'd like to propose it for inclusion in the Haskell >>

Re: Haskell Platform proposal: Add case-insensitive

2013-01-11 Thread Bas van Dijk
On 11 January 2013 21:00, Gregory Collins wrote: > First: Bas, would you support making case-insensitive a Haskell platform > package? Yes, I would support that. > Assuming you say yes, I'd like to propose it for inclusion in the Haskell > platform. The wiki page for this proposal is here: > >

Haskell Platform proposal: Add case-insensitive

2013-01-11 Thread Gregory Collins
Hi all, First: Bas, would you support making case-insensitive a Haskell platform package? Assuming you say yes, I'd like to propose it for inclusion in the Haskell platform. The wiki page for this proposal is here: http://trac.haskell.org/haskell-platform/wiki/Proposals/case-insensitive And