Re: [DISCUSS] Assume Private-Unstable for classes that are not annotated

2014-07-25 Thread Karthik Kambatla
Thanks everyone for chiming in. I created https://issues.apache.org/jira/browse/HADOOP-10896 as a 2.5 blocker. On Thu, Jul 24, 2014 at 9:34 PM, Chris Nauroth cnaur...@hortonworks.com wrote: +1 for the proposal. I believe stating that classes without annotations are implicitly private is

Re: [DISCUSS] Assume Private-Unstable for classes that are not annotated

2014-07-25 Thread Colin McCabe
+1. Colin On Tue, Jul 22, 2014 at 2:54 PM, Karthik Kambatla ka...@cloudera.com wrote: Hi devs As you might have noticed, we have several classes and methods in them that are not annotated at all. This is seldom intentional. Avoiding incompatible changes to all these classes can be

Re: [DISCUSS] Assume Private-Unstable for classes that are not annotated

2014-07-23 Thread Karthik Kambatla
Fair points, Jason. The fact that we include this in the compatibility guideline should not affect how developers go about this. We should still strive to annotate every new class we add, and reviewers should continue to check for them. However, in case we miss annotations, we won't be burdened

[DISCUSS] Assume Private-Unstable for classes that are not annotated

2014-07-22 Thread Karthik Kambatla
Hi devs As you might have noticed, we have several classes and methods in them that are not annotated at all. This is seldom intentional. Avoiding incompatible changes to all these classes can be considerable baggage. I was wondering if we should add an explicit disclaimer in our compatibility