Based on the positive feedback, filed
https://issues.apache.org/jira/browse/HADOOP-17813 to update the
checkstyle rule.
I don't think it requires a vote thread.
Thanks and regards,
Akira
On Sun, Jun 13, 2021 at 1:14 AM Steve Loughran
wrote:
>
> +1
>
> if you look closely the hadoop-azure module
+1
if you look closely the hadoop-azure module went to 100 lines a while back
and all is good
On Wed, 19 May 2021 at 22:13, Sean Busbey wrote:
> Hello!
>
> What do folks think about changing our line length guidelines to allow for
> 100 character width?
>
> Currently, we tell folks to follow
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles wrote:
> In apache tez, formal line length is 120 characters. So, I
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey
> wrote:
>
> > Hi folks!
> >
> >
+1 for the 100 char limit.
But I would have liked 132 columns more. :)
Kihwal
On Mon, May 24, 2021 at 1:46 PM Sean Busbey
wrote:
> Hi folks!
>
> The consensus seems pretty strongly in favor of increasing the line length
> limit. Do folks still want to see a formal VOTE thread?
>
>
> > On May
Hi folks!
The consensus seems pretty strongly in favor of increasing the line length
limit. Do folks still want to see a formal VOTE thread?
> On May 19, 2021, at 4:22 PM, Sean Busbey wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for
> 100
t; > > > > How
> > > > > > > we are planning to handle this?
> > > > > > >
> > > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com
> > > > > > 821684...@qq.com>> wrote:
> > > >
>
> > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com > > > > 821684...@qq.com>> wrote:
> > > > > >
> > > > > >> +1 100 is reasonable.
> > > > > >>
> > > > &
wrote:
> > > > >
> > > > >> +1 100 is reasonable.
> > > > >>
> > > > >>
> > > > >>
> > > > >> ---Original---
> > > > >> From: "Xiaoqiao He" > > hexiaoq...@apache.org
>
gt;>
> > > >> ---Original---
> > > >> From: "Xiaoqiao He" > hexiaoq...@apache.org
> > > >
> > > >> Date: Thu, May 20, 2021 13:35 PM
> > > >> To: "Masatake Iwasaki" > > iwasak...@oss.nttdata.co.j
;> Date: Thu, May 20, 2021 13:35 PM
> >> To: "Masatake Iwasaki" iwasak...@oss.nttdata.co.jp>;
> >> Cc: "Akira Ajisaka" >> <mailto:aajis...@apache.org>;"Hadoop
> Common"<
> >> common-...@hadoop.apache.org <mailto:common-...
hdfs-dev@hadoop.apache.org>
>> ;"yarn-dev"> <mailto:yarn-...@hadoop.apache.org>;"mapreduce-dev"<
>> mapreduce-...@hadoop.apache.org <mailto:mapreduce-...@hadoop.apache.org>;
>> Subject: Re: [DISCUSS] Change project style guideline
quot;Xiaoqiao He" > > Date: Thu, May 20, 2021 13:35 PM
> > > To: "Masatake Iwasaki" > > Cc: "Akira Ajisaka" > > common-...@hadoop.apache.org;"Hdfs-dev" > > ;"yarn-dev" > > mapreduce-...@hadoop.apache.org;
>
May 20, 2021 13:35 PM
> > To: "Masatake Iwasaki" > Cc: "Akira Ajisaka" > common-...@hadoop.apache.org;"Hdfs-dev" > ;"yarn-dev" > mapreduce-...@hadoop.apache.org;
> > Subject: Re: [DISCUSS] Change project style guidelines to all
1 13:35 PM
> To: "Masatake Iwasaki" Cc: "Akira Ajisaka" common-...@hadoop.apache.org;"Hdfs-dev" ;"yarn-dev" mapreduce-...@hadoop.apache.org;
> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> length 100
>
>
> +1
+1 100 is reasonable.
---Original---
From: "Xiaoqiao He"https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
I have no inconvenience on 100 characters for using Emacs and side-by-side
diff even on
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasak...@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
>
I'm +1 too.
I feel 80 characters limit tends to degrade readability by introducing useless
line breaks.
https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
I have no inconvenience on 100 characters
+1 for 100 instead of 80.
I can see that some projects have already changed to 120.
Akira Ajisaka 于2021年5月20日周四 上午10:01写道：
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> -
>
I'm +1 to allow <= 100 chars.
FYI: There were some discussions long before:
-
https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
-
Hello!
What do folks think about changing our line length guidelines to allow for 100
character width?
Currently, we tell folks to follow the sun style guide with some exception
unrelated to line length. That guide says width of 80 is the standard and our
current check style rules act as
21 matches
Mail list logo
