[ https://issues.apache.org/jira/browse/HDFS-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas resolved HDFS-4627. ----------------------------------- Resolution: Fixed Fix Version/s: Snapshot (HDFS-2802) Hadoop Flags: Reviewed I committed the patch to HDFS-2802 branch. Thank you Jing. > Fix FSImageFormat#Loader NPE and synchronization issues > ------------------------------------------------------- > > Key: HDFS-4627 > URL: https://issues.apache.org/jira/browse/HDFS-4627 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Fix For: Snapshot (HDFS-2802) > > Attachments: HDFS-4627.001.patch, HDFS-4627.002.patch > > > 1. Currently FSImageFormat#Loader#loadFilesUnderConstruction calls > FSDirectory#unprotectedReplaceINodeFile without acquiring FSDirectory's lock. > FSDirectory#replaceINodeFile should be called instead. > 2. Currently FSImage#Loader#loadINode does not create block[] object (i.e., > keep it as null) when the length of the block is 0. This will cause NPE when > the loaded INodeFile is empty, and then an append operation on this inode is > applied from edit log. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira