[ https://issues.apache.org/jira/browse/HDFS-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618043#comment-17618043 ]
ASF GitHub Bot commented on HDFS-16803: --------------------------------------- jianghuazhu commented on PR #5031: URL: https://github.com/apache/hadoop/pull/5031#issuecomment-1279704327 @ZanderXu , thanks for reviewing this pr. In Journal.java, there is a display annotation error. Such as: ![image](https://user-images.githubusercontent.com/6416939/195979236-c6dadda9-811c-485e-9b48-943b5ae0deef.png) This looks like an error, but you can actually link to FileJournalManager#lastReadableTxId. It looks right here. What do you think? > Improve some annotations in hdfs module > --------------------------------------- > > Key: HDFS-16803 > URL: https://issues.apache.org/jira/browse/HDFS-16803 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, namenode > Affects Versions: 2.9.2, 3.3.4 > Reporter: JiangHua Zhu > Assignee: JiangHua Zhu > Priority: Major > Labels: pull-request-available > > In FSDirRenameOp, some annotations are out of date. E.g: > {code:java} > /** > * @see {@link #unprotectedRenameTo(FSDirectory, String, String, > INodesInPath, > * INodesInPath, long, BlocksMapUpdateInfo, Options.Rename...)} > */ > static RenameResult renameTo(FSDirectory fsd, FSPermissionChecker pc, > String src, String dst, BlocksMapUpdateInfo collectedBlocks, > boolean logRetryCache,Options.Rename... options) > throws IOException { > {code} > We should try to improve these annotations to make the documentation look > more comfortable. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org