[jira] [Commented] (HDFS-4266) BKJM: Separate write and ack quorum

[ https://issues.apache.org/jira/browse/HDFS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066305#comment-14066305 ] Ivan Kelly commented on HDFS-4266: -- That would work. BKJM: Separate write and ack quorum

[jira] [Commented] (HDFS-4266) BKJM: Separate write and ack quorum

[ https://issues.apache.org/jira/browse/HDFS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066357#comment-14066357 ] Ivan Kelly commented on HDFS-4266: -- lgtm + 1 BKJM: Separate write and ack quorum

[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads

[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064972#comment-14064972 ] Ivan Kelly commented on HDFS-4265: -- lgtm +1 BKJM doesn't take advantage of speculative

[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads

[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057646#comment-14057646 ] Ivan Kelly commented on HDFS-4265: -- I think the constant names need MS also,

[jira] [Commented] (HDFS-4266) BKJM: Separate write and ack quorum

[ https://issues.apache.org/jira/browse/HDFS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057654#comment-14057654 ] Ivan Kelly commented on HDFS-4266: -- Looks good to me, but the test could be a little

[jira] [Commented] (HDFS-5411) Update Bookkeeper dependency to 4.2.3

[ https://issues.apache.org/jira/browse/HDFS-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053816#comment-14053816 ] Ivan Kelly commented on HDFS-5411: -- change lgtm +1 Update Bookkeeper dependency to 4.2.3

[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads

[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053820#comment-14053820 ] Ivan Kelly commented on HDFS-4265: -- Change looks good, but you should add units to the

[jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of speculative reads

[ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713827#comment-13713827 ] Ivan Kelly commented on HDFS-4265: -- +1 for the patch. BKJM doesn't take

[jira] [Commented] (HDFS-4266) BKJM: Separate write and ack quorum

[ https://issues.apache.org/jira/browse/HDFS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713821#comment-13713821 ] Ivan Kelly commented on HDFS-4266: -- The patch makes an ack quorum mandatory. This breaks

[jira] [Commented] (HDFS-4445) All BKJM ledgers are not checked while tailing, So failover will fail.

[ https://issues.apache.org/jira/browse/HDFS-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567844#comment-13567844 ] Ivan Kelly commented on HDFS-4445: -- lgtm. +1 All BKJM ledgers are not

[jira] [Moved] (HDFS-4286) Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server jar in hidden package of BKJM

[ https://issues.apache.org/jira/browse/HDFS-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly moved BOOKKEEPER-478 to HDFS-4286: - Fix Version/s: (was: 4.2.0) 2.0.3-alpha

[jira] [Updated] (HDFS-4286) Changes from BOOKKEEPER-203 broken capability of including bookkeeper-server jar in hidden package of BKJM

[ https://issues.apache.org/jira/browse/HDFS-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-4286: - Issue Type: Sub-task (was: Bug) Parent: HDFS-3399 Changes from BOOKKEEPER-203 broken

[jira] [Commented] (HDFS-4130) BKJM: The reading for editlog at NN starting using bkjm is not efficient

[ https://issues.apache.org/jira/browse/HDFS-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509677#comment-13509677 ] Ivan Kelly commented on HDFS-4130: -- The patch looks good to me +1. BKJM:

[jira] [Created] (HDFS-4265) BKJM doesn't take advantage of speculative reads

Ivan Kelly created HDFS-4265: Summary: BKJM doesn't take advantage of speculative reads Key: HDFS-4265 URL: https://issues.apache.org/jira/browse/HDFS-4265 Project: Hadoop HDFS Issue Type:

[jira] [Created] (HDFS-4266) BKJM: Separate write and ack quorum

Ivan Kelly created HDFS-4266: Summary: BKJM: Separate write and ack quorum Key: HDFS-4266 URL: https://issues.apache.org/jira/browse/HDFS-4266 Project: Hadoop HDFS Issue Type: Sub-task

[jira] [Commented] (HDFS-4154) BKJM: Two namenodes usng bkjm can race to create the version znode

[ https://issues.apache.org/jira/browse/HDFS-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498998#comment-13498998 ] Ivan Kelly commented on HDFS-4154: -- [~umamaheswararao] Yes, it's very straightforward to

[jira] [Commented] (HDFS-3623) BKJM: zkLatchWaitTimeout hard coded to 6000. Make use of ZKSessionTimeout instead.

[ https://issues.apache.org/jira/browse/HDFS-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497957#comment-13497957 ] Ivan Kelly commented on HDFS-3623: -- lgtm +1 BKJM: zkLatchWaitTimeout

[jira] [Created] (HDFS-4154) Two namenodes usng bkjm can race to create the version znode

Ivan Kelly created HDFS-4154: Summary: Two namenodes usng bkjm can race to create the version znode Key: HDFS-4154 URL: https://issues.apache.org/jira/browse/HDFS-4154 Project: Hadoop HDFS

[jira] [Commented] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487137#comment-13487137 ] Ivan Kelly commented on HDFS-3809: -- HDFS-4121 caused this. New patch attached.

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Target Version/s: 2.0.1-alpha, 3.0.0 (was: 3.0.0, 2.0.1-alpha) Status: Patch Available

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Attachment: 0001-HDFS-3809.-Make-BKJM-use-protobufs-for-all-serializa.patch Make BKJM use protobufs

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Attachment: 0001-HDFS-3809.-Make-BKJM-use-protobufs-for-all-serializa.patch ah, I had generated from what

[jira] [Updated] (HDFS-3769) standby namenode become active fails because starting log segment fail on shared storage

[ https://issues.apache.org/jira/browse/HDFS-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3769: - Issue Type: Sub-task (was: Bug) Parent: HDFS-3399 standby namenode become active fails

[jira] [Updated] (HDFS-3908) In HA mode, when there is a ledger in BK missing, which is generated after the last checkpoint, NN can not restore it.

[ https://issues.apache.org/jira/browse/HDFS-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3908: - Issue Type: Sub-task (was: Bug) Parent: HDFS-3399 In HA mode, when there is a ledger in BK

[jira] [Updated] (HDFS-3573) Supply NamespaceInfo when instantiating JournalManagers

[ https://issues.apache.org/jira/browse/HDFS-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3573: - Attachment: 0001-HDFS-3573-for-branch-2.patch Patch for branch-2 very similar to trunk, but distributed

[jira] [Updated] (HDFS-3695) Genericize format() to non-file JournalManagers

[ https://issues.apache.org/jira/browse/HDFS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3695: - Fix Version/s: 2.0.3-alpha Genericize format() to non-file JournalManagers

[jira] [Updated] (HDFS-3695) Genericize format() to non-file JournalManagers

[ https://issues.apache.org/jira/browse/HDFS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3695: - Attachment: 0002-HDFS-3695-for-branch-2.patch Only offsets and conflict resolution compared to trunk. No

[jira] [Updated] (HDFS-3789) JournalManager#format() should be able to throw IOException

[ https://issues.apache.org/jira/browse/HDFS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3789: - Attachment: 0003-HDFS-3789-for-branch-2.patch Only offsets have changed, compared to trunk version.

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Attachment: 0004-HDFS-3809-for-branch-2.patch Some offset changes. Make BKJM use

[jira] [Updated] (HDFS-3789) JournalManager#format() should be able to throw IOException

[ https://issues.apache.org/jira/browse/HDFS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3789: - Fix Version/s: 2.0.3-alpha JournalManager#format() should be able to throw IOException

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Fix Version/s: 2.0.3-alpha Make BKJM use protobufs for all serialization with ZK

[jira] [Commented] (HDFS-3958) Integrate upgrade/finalize/rollback with external journals

[ https://issues.apache.org/jira/browse/HDFS-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458528#comment-13458528 ] Ivan Kelly commented on HDFS-3958: -- I guess an upgrade operation itself isn't really

[jira] [Commented] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450478#comment-13450478 ] Ivan Kelly commented on HDFS-3809: -- [~umamahesh] I think both these should be pushed to

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Attachment: HDFS-3809.diff New patch addresses comments. {quote} One doubt, Do we need to handle

[jira] [Updated] (HDFS-3810) Implement format() for BKJM

[ https://issues.apache.org/jira/browse/HDFS-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3810: - Attachment: HDFS-3810.diff New patch addresses comments. Implement format() for BKJM

[jira] [Commented] (HDFS-3891) QJM: SBN fails if selectInputStreams throws RTE

[ https://issues.apache.org/jira/browse/HDFS-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449736#comment-13449736 ] Ivan Kelly commented on HDFS-3891: -- Yup, #2 is definitely better than one. Do you remember

[jira] [Commented] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449801#comment-13449801 ] Ivan Kelly commented on HDFS-3809: -- We use it later in HDFS-3810. I can move it to that

[jira] [Created] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

Ivan Kelly created HDFS-3809: Summary: Make BKJM use protobufs for all serialization with ZK Key: HDFS-3809 URL: https://issues.apache.org/jira/browse/HDFS-3809 Project: Hadoop HDFS Issue Type:

[jira] [Created] (HDFS-3810) Implement format() for BKJM

Ivan Kelly created HDFS-3810: Summary: Implement format() for BKJM Key: HDFS-3810 URL: https://issues.apache.org/jira/browse/HDFS-3810 Project: Hadoop HDFS Issue Type: Sub-task

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Attachment: HDFS-3809.diff Patch makes BKJM use NamespaceInfo also. Make BKJM use

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Status: Patch Available (was: Open) Make BKJM use protobufs for all serialization with ZK

[jira] [Updated] (HDFS-3810) Implement format() for BKJM

[ https://issues.apache.org/jira/browse/HDFS-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3810: - Attachment: HDFS-3810.diff Patch applies over patch for HDFS-3809. Implement format()

[jira] [Updated] (HDFS-3810) Implement format() for BKJM

[ https://issues.apache.org/jira/browse/HDFS-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3810: - Status: Patch Available (was: Open) Implement format() for BKJM ---

[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

[ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3809: - Attachment: HDFS-3809.diff Fixed findbugs (exclude protobuf from check) Make BKJM use

[jira] [Created] (HDFS-3789) JournalManager#format() should be able to throw IOException

Ivan Kelly created HDFS-3789: Summary: JournalManager#format() should be able to throw IOException Key: HDFS-3789 URL: https://issues.apache.org/jira/browse/HDFS-3789 Project: Hadoop HDFS Issue

[jira] [Updated] (HDFS-3789) JournalManager#format() should be able to throw IOException

[ https://issues.apache.org/jira/browse/HDFS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3789: - Status: Patch Available (was: Open) JournalManager#format() should be able to throw IOException

[jira] [Updated] (HDFS-3789) JournalManager#format() should be able to throw IOException

[ https://issues.apache.org/jira/browse/HDFS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3789: - Attachment: HDFS-3789.diff JournalManager#format() should be able to throw IOException

[jira] [Commented] (HDFS-3695) Genericize format() and initializeSharedEdits() to non-file JournalManagers

[ https://issues.apache.org/jira/browse/HDFS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431784#comment-13431784 ] Ivan Kelly commented on HDFS-3695: -- New patch looks good +1 Genericize

[jira] [Commented] (HDFS-3695) Genericize format() and initializeSharedEdits() to non-file JournalManagers

[ https://issues.apache.org/jira/browse/HDFS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430939#comment-13430939 ] Ivan Kelly commented on HDFS-3695: -- New patch looks good, though I think

[jira] [Commented] (HDFS-3464) BKJM: Deleting currentLedger and leaving 'inprogress_x' on exceptions can throw BKNoSuchLedgerExistsException later.

[ https://issues.apache.org/jira/browse/HDFS-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295697#comment-13295697 ] Ivan Kelly commented on HDFS-3464: -- Have you seen this exception with the latest code?

[jira] [Updated] (HDFS-3389) Document the BKJM usage in Namenode HA.

[ https://issues.apache.org/jira/browse/HDFS-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3389: - Attachment: HDFS-3389.diff Documentation looks good. I made a few modifications which I think makes

[jira] [Commented] (HDFS-3423) BKJM: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286546#comment-13286546 ] Ivan Kelly commented on HDFS-3423: -- lgtm +1. BKJM: NN startup is

[jira] [Commented] (HDFS-3441) Race condition between rolling logs at active NN and purging at standby

[ https://issues.apache.org/jira/browse/HDFS-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286549#comment-13286549 ] Ivan Kelly commented on HDFS-3441: -- looks good. Just needs a small tweak in the test. +

[jira] [Commented] (HDFS-3441) Race condition between rolling logs at active NN and purging at standby

[ https://issues.apache.org/jira/browse/HDFS-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286588#comment-13286588 ] Ivan Kelly commented on HDFS-3441: -- Latest patch is good. +1 from me.

[jira] [Created] (HDFS-3474) Cleanup Exception handling in BookKeeper journal manager

Ivan Kelly created HDFS-3474: Summary: Cleanup Exception handling in BookKeeper journal manager Key: HDFS-3474 URL: https://issues.apache.org/jira/browse/HDFS-3474 Project: Hadoop HDFS Issue

[jira] [Updated] (HDFS-3474) Cleanup Exception handling in BookKeeper journal manager

[ https://issues.apache.org/jira/browse/HDFS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3474: - Attachment: HDFS-3474.diff Patch to replace catch (Exception e) with specific exceptions

[jira] [Updated] (HDFS-3474) Cleanup Exception handling in BookKeeper journal manager

[ https://issues.apache.org/jira/browse/HDFS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3474: - Status: Patch Available (was: Open) Cleanup Exception handling in BookKeeper journal manager

[jira] [Updated] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3423: - Attachment: HDFS-3423.diff Rebased on trunk. This patch clashes with HDFS-3474, so which ever goes in

[jira] [Commented] (HDFS-3470) [Log Improvement]: Error logs logged at the time of switch which is misleading

[ https://issues.apache.org/jira/browse/HDFS-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285567#comment-13285567 ] Ivan Kelly commented on HDFS-3470: -- This occurs because of the way we open ledgers in

[jira] [Updated] (HDFS-3470) [Log Improvement]: Error logs logged at the time of switch which is misleading

[ https://issues.apache.org/jira/browse/HDFS-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3470: - Issue Type: Bug (was: Sub-task) Parent: (was: HDFS-3399) [Log Improvement]: Error logs

[jira] [Updated] (HDFS-3474) Cleanup Exception handling in BookKeeper journal manager

[ https://issues.apache.org/jira/browse/HDFS-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3474: - Attachment: HDFS-3474.diff Fixed typo. Cleanup Exception handling in BookKeeper journal

[jira] [Commented] (HDFS-3441) Race condition between rolling logs at active NN and purging at standby

[ https://issues.apache.org/jira/browse/HDFS-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285659#comment-13285659 ] Ivan Kelly commented on HDFS-3441: -- the code of the patch looks good. I think the test

[jira] [Commented] (HDFS-3452) BKJM:Switch from standby to active fails and NN gets shut down due to delay in clearing of lock

[ https://issues.apache.org/jira/browse/HDFS-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284727#comment-13284727 ] Ivan Kelly commented on HDFS-3452: -- The new patch looks almost ready to go. I have a

[jira] [Commented] (HDFS-3452) BKJM:Switch from standby to active fails and NN gets shut down due to delay in clearing of lock

[ https://issues.apache.org/jira/browse/HDFS-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284805#comment-13284805 ] Ivan Kelly commented on HDFS-3452: -- For #1, what you have is good.

[jira] [Commented] (HDFS-3452) BKJM:Switch from standby to active fails and NN gets shut down due to delay in clearing of lock

[ https://issues.apache.org/jira/browse/HDFS-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284939#comment-13284939 ] Ivan Kelly commented on HDFS-3452: -- lgtm +1 BKJM:Switch from standby to

[jira] [Commented] (HDFS-3452) BKJM:Switch from standby to active fails and NN gets shut down due to delay in clearing of lock

[ https://issues.apache.org/jira/browse/HDFS-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283547#comment-13283547 ] Ivan Kelly commented on HDFS-3452: -- Patch looks good Uma. A few comments. # The version

[jira] [Moved] (HDFS-3452) BKJM:Switch from standby to active fails and NN gets shut down due to delay in clearing of lock

[ https://issues.apache.org/jira/browse/HDFS-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly moved BOOKKEEPER-253 to HDFS-3452: - Component/s: (was: bookkeeper-client) Target Version/s:

[jira] [Commented] (HDFS-3452) BKJM:Switch from standby to active fails and NN gets shut down due to delay in clearing of lock

[ https://issues.apache.org/jira/browse/HDFS-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280956#comment-13280956 ] Ivan Kelly commented on HDFS-3452: -- Moved to HDFS. I've thought about this a bit more.

[jira] [Commented] (HDFS-3386) BK JM : Namenode is not deleting his lock entry '/ledgers/lock/lock-0000X', when fails to acquire the lock

[ https://issues.apache.org/jira/browse/HDFS-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280964#comment-13280964 ] Ivan Kelly commented on HDFS-3386: -- HDFS-3452 will make this unnecessary.

[jira] [Commented] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280967#comment-13280967 ] Ivan Kelly commented on HDFS-3423: -- How would you change it though? I don't see a clean

[jira] [Commented] (HDFS-3441) Race condition between rolling logs at active NN and purging at standby

[ https://issues.apache.org/jira/browse/HDFS-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280987#comment-13280987 ] Ivan Kelly commented on HDFS-3441: -- Patch looks good to me. It would be good to have some

[jira] [Commented] (HDFS-3441) Race condition between rolling logs at active NN and purging at standby

[ https://issues.apache.org/jira/browse/HDFS-3441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278717#comment-13278717 ] Ivan Kelly commented on HDFS-3441: -- This solution looks good to me. Will you generate a

[jira] [Commented] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278802#comment-13278802 ] Ivan Kelly commented on HDFS-3423: -- If the store here is to a txid older than what we

[jira] [Updated] (HDFS-3058) HA: Bring BookKeeperJournalManager up to date with HA changes

[ https://issues.apache.org/jira/browse/HDFS-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3058: - Attachment: HDFS-3058.diff Rebased on trunk. Some fixups were required to tests, as the way Namenode

[jira] [Updated] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3423: - Attachment: HDFS-3423.diff New patch fixes findbugs BookKeeperJournalManager: NN

[jira] [Commented] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278917#comment-13278917 ] Ivan Kelly commented on HDFS-3423: -- @Rakesh In the case of a primary nn crashing, the

[jira] [Commented] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277703#comment-13277703 ] Ivan Kelly commented on HDFS-3423: -- This can't happen, as maxid always grows unless it is

[jira] [Moved] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly moved BOOKKEEPER-244 to HDFS-3423: - Target Version/s: 2.0.0, 3.0.0 Key: HDFS-3423 (was:

[jira] [Updated] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3423: - Attachment: HDFS-3423.diff BookKeeperJournalManager: NN startup is failing, when tries to

[jira] [Updated] (HDFS-3423) BookKeeperJournalManager: NN startup is failing, when tries to recoverUnfinalizedSegments() a bad inProgress_ ZNodes

[ https://issues.apache.org/jira/browse/HDFS-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3423: - Status: Patch Available (was: Open) This patch requires HDFS-3058 to apply

[jira] [Updated] (HDFS-2717) BookKeeper Journal output stream doesn't check addComplete rc

[ https://issues.apache.org/jira/browse/HDFS-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-2717: - Fix Version/s: (was: 0.24.0) 3.0.0 2.0.0 BookKeeper

[jira] [Updated] (HDFS-3058) HA: Bring BookKeeperJournalManager up to date with HA changes

[ https://issues.apache.org/jira/browse/HDFS-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3058: - Attachment: HDFS-3058.diff Rebased onto trunk HA: Bring BookKeeperJournalManager up to

[jira] [Updated] (HDFS-3386) BK JM : Namenode is not deleting his lock entry '/ledgers/lock/lock-0000X', when fails to acquire the lock

[ https://issues.apache.org/jira/browse/HDFS-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3386: - Attachment: HDFS-3386.diff Patch applies on top of HDFS-3058 BK JM : Namenode is not

[jira] [Updated] (HDFS-3386) BK JM : Namenode is not deleting his lock entry '/ledgers/lock/lock-0000X', when fails to acquire the lock

[ https://issues.apache.org/jira/browse/HDFS-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-3386: - Fix Version/s: (was: 0.23.0) 3.0.0 2.0.0 Assignee: Ivan

[jira] [Commented] (HDFS-3392) BookKeeper Journal Manager is not retrying to connect to BK when BookKeeper is not available for write.

[ https://issues.apache.org/jira/browse/HDFS-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272411#comment-13272411 ] Ivan Kelly commented on HDFS-3392: -- I don't understand the description here. If the BK

[jira] [Updated] (HDFS-234) Integration with BookKeeper logging system

[ https://issues.apache.org/jira/browse/HDFS-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-234: Attachment: HDFS-234-branch-2.patch This patch is a direct copy of the bkjournal code from trunk on the 8th

[jira] [Commented] (HDFS-2743) Streamline usage of bookkeeper journal manager

[ https://issues.apache.org/jira/browse/HDFS-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262722#comment-13262722 ] Ivan Kelly commented on HDFS-2743: -- {quote} I think you already handled them as part of

[jira] [Commented] (HDFS-2158) Add JournalSet to manage the set of journals.

[ https://issues.apache.org/jira/browse/HDFS-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114563#comment-13114563 ] Ivan Kelly commented on HDFS-2158: -- Why not get rid of journal stream completely? Perhaps

[jira] [Commented] (HDFS-2158) Add JournalSet to manage the set of journals.

[ https://issues.apache.org/jira/browse/HDFS-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114564#comment-13114564 ] Ivan Kelly commented on HDFS-2158: -- Forgot to say, the xml above should be added to

[jira] [Updated] (HDFS-2188) HDFS-1580: Make FSEditLog create its journals from a list of URIs rather than NNStorage

[ https://issues.apache.org/jira/browse/HDFS-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-2188: - Attachment: HDFS-2188.diff Removed storage of conf for the moment. I've left conf as a parameter to

[jira] [Commented] (HDFS-2188) HDFS-1580: Make FSEditLog create its journals from a list of URIs rather than NNStorage

[ https://issues.apache.org/jira/browse/HDFS-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109626#comment-13109626 ] Ivan Kelly commented on HDFS-2188: -- The mechanism for loading the journal from the type of

[jira] [Commented] (HDFS-2158) Add JournalSet to manage the set of journals.

[ https://issues.apache.org/jira/browse/HDFS-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109656#comment-13109656 ] Ivan Kelly commented on HDFS-2158: -- Looks like a pretty straight forward refactor. A few

[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk

[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105221#comment-13105221 ] Ivan Kelly commented on HDFS-2333: -- Looks good to me. +1 Perhaps add to the

[jira] [Created] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk

HDFS-2284 introduced 2 findbugs warnings on trunk - Key: HDFS-2333 URL: https://issues.apache.org/jira/browse/HDFS-2333 Project: Hadoop HDFS Issue Type: Bug Reporter: Ivan Kelly

[jira] [Updated] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk

[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-2333: - Attachment: HDFS-2333.diff The warning is that, if DFSOutputStream is extended, the thread could start

[jira] [Updated] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk

[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-2333: - Status: Patch Available (was: Open) HDFS-2284 introduced 2 findbugs warnings on trunk

[jira] [Commented] (HDFS-2188) HDFS-1580: Make FSEditLog create its journals from a list of URIs rather than NNStorage

[ https://issues.apache.org/jira/browse/HDFS-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104388#comment-13104388 ] Ivan Kelly commented on HDFS-2188: -- The findbugs were introduced by HDFS-2284 and are

[jira] [Updated] (HDFS-2188) HDFS-1580: Make FSEditLog create its journals from a list of URIs rather than NNStorage

[ https://issues.apache.org/jira/browse/HDFS-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-2188: - Attachment: HDFS-2188.diff Last patch had an issue with TestStorageRestore that didn't show up in jenkins

[jira] [Created] (HDFS-2334) Add Closeable to JournalManager

Add Closeable to JournalManager --- Key: HDFS-2334 URL: https://issues.apache.org/jira/browse/HDFS-2334 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ivan Kelly Assignee: Ivan Kelly

[jira] [Updated] (HDFS-2334) Add Closeable to JournalManager

[ https://issues.apache.org/jira/browse/HDFS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated HDFS-2334: - Attachment: HDFS-2334.diff Add Closeable to JournalManager ---

  1   2   3   4   >