[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289251#comment-15289251 ] Josh Elser commented on HDFS-9226: -- bq. Test failures were not caused by the patch (verified all tests

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289179#comment-15289179 ] Josh Elser commented on HDFS-9226: -- Hrm, let me take a look at these unit test failures and checkstyle. I

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: HDFS-9926.006.patch .006 Rebased .004 on top of the correct "trunk" branch :) >

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: (was: HDFS-9926.006.patch) > MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288134#comment-15288134 ] Josh Elser commented on HDFS-9226: -- bq. so here's a rebase on top of master. Oh my. {{master}} is not

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: HDFS-9926.006.patch .006 This one came across my radar again today, so here's a rebase on top

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965545#comment-14965545 ] Josh Elser commented on HDFS-9226: -- bq. I must confess I don't understand how HDFS-8953 introduced this.

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962801#comment-14962801 ] Josh Elser commented on HDFS-9226: -- Anything else that needs to be done here? This at least fixed the

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957042#comment-14957042 ] Josh Elser commented on HDFS-9226: -- bq. I agree with this. Adding mockito as dependency would be better.

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957503#comment-14957503 ] Josh Elser commented on HDFS-9226: -- Well, I thought this would be simple, but it seems like I might be

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: HDFS-9226.005.patch > MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils >

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: HDFS-9226.004.patch > MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils >

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953601#comment-14953601 ] Josh Elser commented on HDFS-9226: -- bq. The class name InternalDataNodeTestUtils is not clear because test

[jira] [Created] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

Josh Elser created HDFS-9226: Summary: MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils Key: HDFS-9226 URL: https://issues.apache.org/jira/browse/HDFS-9226 Project: Hadoop HDFS

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952424#comment-14952424 ] Josh Elser commented on HDFS-9226: -- FYI, [~kanaka], [~vinayrpet], [~arpitagarwal], [~ste...@apache.org]

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: HDFS-9226.001.patch > MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils >

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Status: Patch Available (was: Open) > MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils >

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: HDFS-9226.002.patch 002 is the same patch as 001 except for one removed changeset in which the

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952498#comment-14952498 ] Josh Elser commented on HDFS-9226: -- 001 takes the route of just moving the test utilities that rely on

[jira] [Updated] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-9226: - Attachment: HDFS-9226.003.patch RAT is a false positive and the test failure appears sporadic (passed

[jira] [Commented] (HDFS-9226) MiniDFSCluster leaks dependency Mockito via DataNodeTestUtils

[ https://issues.apache.org/jira/browse/HDFS-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952642#comment-14952642 ] Josh Elser commented on HDFS-9226: -- Thanks for taking a look, [~iwasakims]. bq. Mockito has been used for

[jira] [Commented] (HDFS-8088) Reduce the number of HTrace spans generated by HDFS reads

[ https://issues.apache.org/jira/browse/HDFS-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494783#comment-14494783 ] Josh Elser commented on HDFS-8088: -- bq. Keep in mind that doing a write in HDFS just hands

[jira] [Commented] (HDFS-8088) Reduce the number of HTrace spans generated by HDFS reads

[ https://issues.apache.org/jira/browse/HDFS-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492997#comment-14492997 ] Josh Elser commented on HDFS-8088: -- I re-ran my test on Hadoop-2.7.1-SNAP with your patch

[jira] [Commented] (HDFS-8088) Reduce the number of HTrace spans generated by HDFS reads

[ https://issues.apache.org/jira/browse/HDFS-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493363#comment-14493363 ] Josh Elser commented on HDFS-8088: -- Ran a write-heavy test with the patch here as well as

[jira] [Commented] (HDFS-8088) Reduce the number of HTrace spans generated by HDFS reads

[ https://issues.apache.org/jira/browse/HDFS-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492586#comment-14492586 ] Josh Elser commented on HDFS-8088: -- Thanks for putting up a patch, Colin. I'll try to play

[jira] [Commented] (HDFS-8069) Tracing implementation on DFSInputStream seriously degrades performance

[ https://issues.apache.org/jira/browse/HDFS-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486310#comment-14486310 ] Josh Elser commented on HDFS-8069: -- bq. Thanks for confirming this. Just to double-check,

[jira] [Created] (HDFS-8069) Tracing implementation on DFSInputStream seriously degrades performance

Josh Elser created HDFS-8069: Summary: Tracing implementation on DFSInputStream seriously degrades performance Key: HDFS-8069 URL: https://issues.apache.org/jira/browse/HDFS-8069 Project: Hadoop HDFS

[jira] [Commented] (HDFS-8069) Tracing implementation on DFSInputStream seriously degrades performance

[ https://issues.apache.org/jira/browse/HDFS-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482261#comment-14482261 ] Josh Elser commented on HDFS-8069: -- Thanks for chiming in, [~billie.rinaldi]. I had been

[jira] [Commented] (HDFS-8069) Tracing implementation on DFSInputStream seriously degrades performance

[ https://issues.apache.org/jira/browse/HDFS-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482274#comment-14482274 ] Josh Elser commented on HDFS-8069: -- With regards to your other points: Comments to

[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE

[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887941#comment-13887941 ] Josh Elser commented on HDFS-5856: -- Thanks, [~sureshms]. DataNode.checkDiskError might

[jira] [Created] (HDFS-5856) DataNode.checkDiskError might throw NPE

Josh Elser created HDFS-5856: Summary: DataNode.checkDiskError might throw NPE Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug

[jira] [Updated] (HDFS-5856) DataNode.checkDiskError might throw NPE

[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-5856: - Attachment: HDFS-5856.diff Patch against trunk DataNode.checkDiskError might throw NPE

[jira] [Updated] (HDFS-5856) DataNode.checkDiskError might throw NPE

[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-5856: - Fix Version/s: (was: 3.0.0) Target Version/s: 3.0.0 Status: Patch Available

[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE

[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886893#comment-13886893 ] Josh Elser commented on HDFS-5856: -- Current patch also applies cleanly to branch-2.

[jira] [Updated] (HDFS-5856) DataNode.checkDiskError might throw NPE

[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-5856: - Attachment: HDFS-5856.diff Thanks for the quick suggestions, [~sureshms]. New patch with your suggestions

[jira] [Commented] (HDFS-5560) Trash configuration log statements prints incorrect units

[ https://issues.apache.org/jira/browse/HDFS-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13837291#comment-13837291 ] Josh Elser commented on HDFS-5560: -- Great! Thanks, Andrew and Vinay. Trash configuration

[jira] [Created] (HDFS-5560) Trash configuration log statements prints incorrect units

Josh Elser created HDFS-5560: Summary: Trash configuration log statements prints incorrect units Key: HDFS-5560 URL: https://issues.apache.org/jira/browse/HDFS-5560 Project: Hadoop HDFS Issue

[jira] [Updated] (HDFS-5560) Trash configuration log statements prints incorrect units

[ https://issues.apache.org/jira/browse/HDFS-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-5560: - Target Version/s: 3.0.0, 2.2.1 Status: Patch Available (was: Open) Patch currently applies

[jira] [Updated] (HDFS-5560) Trash configuration log statements prints incorrect units

[ https://issues.apache.org/jira/browse/HDFS-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HDFS-5560: - Attachment: HDFS-5560.patch Trash configuration log statements prints incorrect units