[
https://issues.apache.org/jira/browse/HDDS-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760432#comment-16760432
]
Bharat Viswanadham edited comment on HDDS-1044 at 2/5/19 3:59 AM:
------------------------------------------------------------------
Hi [~linyiqun]
Thanks for the contribution.
{code:java}
Can we change Line 174 as: "Container " + containerID +" creation failed due
to " + result. {code}
And we can rewrite the code as, we don't need null checks here.
{code:java}
if (responseProto.getResult() != Result.Success)
{ // return SCE exception with result from responseProto }
{code}
And also can we add some Unit tests if possible for this error propagation.
was (Author: bharatviswa):
Hi [~linyiqun]
Thanks for the contribution.
Can we change Line 174 as: "Container " + containerID +" creation failed due
to " + result.
And we can rewrite the code as, we don't need null checks here.
if (responseProto.getResult() != Result.Success) {
// return SCE exception with result from responseProto
}
And also can we add some Unit tests if possible for this error propagation.
> Client doesn't propogate correct error code to client on out of disk space
> --------------------------------------------------------------------------
>
> Key: HDDS-1044
> URL: https://issues.apache.org/jira/browse/HDDS-1044
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client, Ozone Datanode
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Yiqun Lin
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1044.001.patch
>
>
> Ozone Datanode doesn't propagate the correct error to client when the
> datanode runs out of distk space. In space of throwing out of disk space
> exception, Container not found exception is thrown to clients.
> {code}
> 2019-02-02 18:56:22 INFO KeyValueHandler:149 - Operation: CreateContainer :
> Trace ID:
> 72e5c6cc-e624-4acb-bba7-574e3a98ac90WriteChunk1868fc02742c62c3543022377edc0c5ca_stream_4fdc8750-f0d5-4e17-8e37-6d78552053b0_chunk_1
> : Message: Container creation failed, due to disk out of space : Result:
> DISK_OUT_OF_SPACE
> 2019-02-02 18:56:22 INFO HddsDispatcher:149 - Operation: WriteChunk : Trace
> ID:
> 72e5c6cc-e624-4acb-bba7-574e3a98ac90WriteChunk1868fc02742c62c3543022377edc0c5ca_stream_4fdc8750-f0d5-4e17-8e37-6d78552053b0_chunk_1
> : Message: ContainerID 65 does not exist : Result: CONTAINER_NOT_FOUND
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
