[ https://issues.apache.org/jira/browse/HDFS-15559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193386#comment-17193386 ]
Lisheng Sun edited comment on HDFS-15559 at 9/10/20, 5:56 AM: -------------------------------------------------------------- Hi [~hexiaoqiao] There are two places of missing infomation. 1. missing config in hdfs-default.xml 2. missing constant interfaces in TestHdfsConfigFields#initializeMemberVariables as follow. {code:java} HdfsClientConfigKeys.Write.class, HdfsClientConfigKeys.Read.class, HdfsClientConfigKeys.Retry.class, HdfsClientConfigKeys.ShortCircuit.class, HdfsClientConfigKeys.Mmap.class, HdfsClientConfigKeys.HedgedRead.class, {code} Since missing HdfsClientConfigKeys.Write.class in TestHdfsConfigFields#initializeMemberVariables, TestHdfsConfigFields#testCompareConfigurationClassAgainstXml pass when missed config at HDFS-14694 Other missing constant interfaces in TestHdfsConfigFields#initializeMemberVariables are not related to HDFS-14694, so i create this issue. was (Author: leosun08): Hi [~hexiaoqiao] There are two places of missing infomation. 1. missing config in hdfs-default.xml 2. missing constant interfaces in TestHdfsConfigFields#initializeMemberVariables as follow. {code:java} HdfsClientConfigKeys.Write.class, HdfsClientConfigKeys.Read.class, HdfsClientConfigKeys.Retry.class, HdfsClientConfigKeys.ShortCircuit.class, HdfsClientConfigKeys.Mmap.class, HdfsClientConfigKeys.HedgedRead.class, {code} Since missing HdfsClientConfigKeys.Write.class in TestHdfsConfigFields#initializeMemberVariables, TestHdfsConfigFields#testCompareConfigurationClassAgainstXml pass when missed config at HDFS-14694 Other missing constant interfaces in TestHdfsConfigFields#initializeMemberVariables are not related to HDFS-14694, so i create this issue.++ > Complement initialize member variables in > TestHdfsConfigFields#initializeMemberVariables > ---------------------------------------------------------------------------------------- > > Key: HDFS-15559 > URL: https://issues.apache.org/jira/browse/HDFS-15559 > Project: Hadoop HDFS > Issue Type: Test > Reporter: Lisheng Sun > Assignee: Lisheng Sun > Priority: Minor > Attachments: HDFS-15559.001.patch > > > There are some missing constant interfaces in > TestHdfsConfigFields#initializeMemberVariables > {code:java} > @Override > public void initializeMemberVariables() { > xmlFilename = new String("hdfs-default.xml"); > configurationClasses = new Class[] { HdfsClientConfigKeys.class, > HdfsClientConfigKeys.Failover.class, > HdfsClientConfigKeys.StripedRead.class, DFSConfigKeys.class, > HdfsClientConfigKeys.BlockWrite.class, > HdfsClientConfigKeys.BlockWrite.ReplaceDatanodeOnFailure.class }; > }{code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org