[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-02-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760418#comment-16760418 ] Hudson commented on HDDS-1029: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15883 (See

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-02-04 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759970#comment-16759970 ] Yiqun Lin commented on HDDS-1029: - LGTM, +1. > Allow option for force in DeleteContainerCommand >

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-02-03 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759640#comment-16759640 ] Bharat Viswanadham commented on HDDS-1029: -- Test failures are not related to this patch.   >

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-02-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759633#comment-16759633 ] Hadoop QA commented on HDDS-1029: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-02-03 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759610#comment-16759610 ] Bharat Viswanadham commented on HDDS-1029: -- Hi [~linyiqun] Thanks for the suggestion. I have

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-31 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758018#comment-16758018 ] Yiqun Lin commented on HDDS-1029: - Before the check, can we check is the container is replicated across

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757733#comment-16757733 ] Hadoop QA commented on HDDS-1029: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-31 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757709#comment-16757709 ] Bharat Viswanadham commented on HDDS-1029: -- Not sure why the test failed on the trunk, but it is

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757677#comment-16757677 ] Hadoop QA commented on HDDS-1029: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-31 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757629#comment-16757629 ] Bharat Viswanadham commented on HDDS-1029: -- Fixed checkstyle issue. Thank You, [~linyiqun] for

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-30 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756960#comment-16756960 ] Yiqun Lin commented on HDDS-1029: - LGTM, +1. Please take care of the following nitpicks while committing,

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756949#comment-16756949 ] Hadoop QA commented on HDDS-1029: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-30 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756913#comment-16756913 ] Bharat Viswanadham commented on HDDS-1029: -- Hi [~linyiqun] Addressed all the review comments.

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-30 Thread Yiqun Lin (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756831#comment-16756831 ] Yiqun Lin commented on HDDS-1029: - I'm +1 for this idea, [~bharatviswa]. Some review comments from me:

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756560#comment-16756560 ] Hadoop QA commented on HDDS-1029: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756496#comment-16756496 ] Hadoop QA commented on HDDS-1029: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-30 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756404#comment-16756404 ] Bharat Viswanadham commented on HDDS-1029: -- Updated the patch to add some test cases in

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-29 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755654#comment-16755654 ] Bharat Viswanadham commented on HDDS-1029: -- Hi [~sdeka] This change is being done so that SCM

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755603#comment-16755603 ] Hadoop QA commented on HDDS-1029: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-1029) Allow option for force in DeleteContainerCommand

2019-01-29 Thread Supratim Deka (JIRA)
[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755594#comment-16755594 ] Supratim Deka commented on HDDS-1029: - dumb question: instead of overloading the delete container