[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556281#comment-16556281
]
Tsz Wo Nicholas Sze commented on HDDS-203:
--
I have filed HDDS-293 for some improvement on the
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555380#comment-16555380
]
Mukul Kumar Singh commented on HDDS-203:
Thanks for the contribution [~shashikant] and [~szetszwo]
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555411#comment-16555411
]
Hudson commented on HDDS-203:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14634 (See
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555310#comment-16555310
]
Mukul Kumar Singh commented on HDDS-203:
Thanks for updating the patch [~shashikant].
+1, the v6
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555303#comment-16555303
]
genericqa commented on HDDS-203:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555138#comment-16555138
]
Shashikant Banerjee commented on HDDS-203:
--
Thanks [~msingh], [~szetszwo] for the review comments.
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554712#comment-16554712
]
Tsz Wo Nicholas Sze commented on HDDS-203:
--
- In KeyManagerImpl, it should be
{code}
+ return
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554316#comment-16554316
]
genericqa commented on HDDS-203:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554284#comment-16554284
]
Mukul Kumar Singh commented on HDDS-203:
Thanks for the updated patch [~shashikant].
+1, the v5
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554134#comment-16554134
]
Shashikant Banerjee commented on HDDS-203:
--
Thanks [~msingh], [~szetszwo], for the review. Patch
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553818#comment-16553818
]
Mukul Kumar Singh commented on HDDS-203:
Thanks for the updated patch [~shashikant]. Apart from
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553385#comment-16553385
]
Tsz Wo Nicholas Sze commented on HDDS-203:
--
Thanks Shash for the new patch. Some thoughts:
- It
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551613#comment-16551613
]
Shashikant Banerjee commented on HDDS-203:
--
Test failures are not related.
> Add
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551594#comment-16551594
]
genericqa commented on HDDS-203:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551565#comment-16551565
]
Shashikant Banerjee commented on HDDS-203:
--
Thanks [~hanishakoneru], for the review comments.
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551369#comment-16551369
]
Hanisha Koneru commented on HDDS-203:
-
Thanks for working on this [~shashikant].
Patch LGTM overall.
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549198#comment-16549198
]
genericqa commented on HDDS-203:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549073#comment-16549073
]
Shashikant Banerjee commented on HDDS-203:
--
Patch v3 is rebased to the latest trunk. It also fixe
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538468#comment-16538468
]
genericqa commented on HDDS-203:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531437#comment-16531437
]
Shashikant Banerjee commented on HDDS-203:
--
Patch v1 is dependent on HDDS-48. Will be submitting
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526810#comment-16526810
]
genericqa commented on HDDS-203:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526807#comment-16526807
]
genericqa commented on HDDS-203:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
22 matches
Mail list logo
