[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281592#comment-15281592
]
Kihwal Lee commented on HDFS-10220:
---
The throughput is pathetic, but it seems in the ballpark of what I
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281276#comment-15281276
]
Nicolas Fraison commented on HDFS-10220:
[~kihwal] It takes around 20s to release 100K path so for
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278334#comment-15278334
]
Kihwal Lee commented on HDFS-10220:
---
Sorry for being late in the party. 200ms of write locking is an
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275875#comment-15275875
]
Walter Su commented on HDFS-10220:
--
The last patch looks pretty good. +1 once the test nits get
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274993#comment-15274993
]
Hadoop QA commented on HDFS-10220:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274763#comment-15274763
]
Nicolas Fraison commented on HDFS-10220:
[~liuml07], tanks for the notification. The hadoop
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274736#comment-15274736
]
Mingliang Liu commented on HDFS-10220:
--
Hi [~nfraison.criteo], you don't have to change the jira
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274723#comment-15274723
]
Nicolas Fraison commented on HDFS-10220:
[~raviprak], As I said in my previous comment I really
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274649#comment-15274649
]
Hadoop QA commented on HDFS-10220:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274546#comment-15274546
]
Ravi Prakash commented on HDFS-10220:
-
Wait, I take that back. Mingliang's comment about swapping the
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274529#comment-15274529
]
Ravi Prakash commented on HDFS-10220:
-
Thanks for the patches Nicolas and the reviews Mingliang Liu
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274310#comment-15274310
]
Hadoop QA commented on HDFS-10220:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270026#comment-15270026
]
Mingliang Liu commented on HDFS-10220:
--
I also think changing from {{Lease leaseToCheck =
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269921#comment-15269921
]
Ravi Prakash commented on HDFS-10220:
-
Thanks Nicolas! You're amazing :-)
I think I would like to hear
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265770#comment-15265770
]
Nicolas Fraison commented on HDFS-10220:
[~raviprak] in fact changing from *Lease leaseToCheck =
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262383#comment-15262383
]
Ravi Prakash commented on HDFS-10220:
-
Is there a need to renew the lease? That would prevent it from
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261064#comment-15261064
]
Nicolas Fraison commented on HDFS-10220:
Thanks [~walter.k.su] for the catch.
We can update the
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260674#comment-15260674
]
Ravi Prakash commented on HDFS-10220:
-
Good catch Walter! That seems broken prior to this patch too,
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259384#comment-15259384
]
Walter Su commented on HDFS-10220:
--
bq. I think it add some readability and also because it is used
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258779#comment-15258779
]
Ravi Prakash commented on HDFS-10220:
-
Thanks Nicolas! One nit: In
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257915#comment-15257915
]
Nicolas Fraison commented on HDFS-10220:
[~walter.k.su] will also repeat my feedback :) on this
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257898#comment-15257898
]
Walter Su commented on HDFS-10220:
--
Thanks [~ashangit] for the update.
repeat one of my previous
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257846#comment-15257846
]
Hadoop QA commented on HDFS-10220:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257661#comment-15257661
]
Nicolas Fraison commented on HDFS-10220:
Here is a new release of the patch taking in account
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257227#comment-15257227
]
Ravi Prakash commented on HDFS-10220:
-
Thanks Walter! I too would favor a timeout, (maybe checking
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253523#comment-15253523
]
Walter Su commented on HDFS-10220:
--
I mean, saving administrators the trouble to tune this.
> Namenode
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253354#comment-15253354
]
Walter Su commented on HDFS-10220:
--
You are right. The only question I have is I have no idea if the
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252521#comment-15252521
]
Ravi Prakash commented on HDFS-10220:
-
Anyway! I am not going to be a stickler on this. In the
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252517#comment-15252517
]
Ravi Prakash commented on HDFS-10220:
-
bq. It's about implemention detail
I've heard that argument
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252179#comment-15252179
]
Nicolas Fraison commented on HDFS-10220:
[~walter.k.su]
1. I think that it simplify the code
2. Ok
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251150#comment-15251150
]
Walter Su commented on HDFS-10220:
--
1. isMaxFilesCheckedToReleaseLease is not requirted to be a function.
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250841#comment-15250841
]
Nicolas Fraison commented on HDFS-10220:
[~vinayrpet], there is one checkstyle issue remaining but
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243338#comment-15243338
]
Hadoop QA commented on HDFS-10220:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235511#comment-15235511
]
Vinayakumar B commented on HDFS-10220:
--
Thanks @Nicolas Fraison for the patch.
Looks almost good.
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234903#comment-15234903
]
Hadoop QA commented on HDFS-10220:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219677#comment-15219677
]
Vinayakumar B commented on HDFS-10220:
--
{code}
+ public static final String
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219581#comment-15219581
]
Nicolas Fraison commented on HDFS-10220:
[~raviprak] this issue seems to only happens when we have
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218247#comment-15218247
]
Nicolas Fraison commented on HDFS-10220:
[~vinayrpet] the day we face this kind of failover we
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218106#comment-15218106
]
Ravi Prakash commented on HDFS-10220:
-
Also lets rename {{maxPathReleaseExpiredLease}} to
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218097#comment-15218097
]
Ravi Prakash commented on HDFS-10220:
-
{code}import static
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218036#comment-15218036
]
Ravi Prakash commented on HDFS-10220:
-
Oh! I'm sorry in that case. Thank you for re-opening the JIRA.
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217284#comment-15217284
]
Vinayakumar B commented on HDFS-10220:
--
[~nfraison.criteo], Did you see the similar messages ( might
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215594#comment-15215594
]
Nicolas Fraison commented on HDFS-10220:
On hadoop 2.6.0 from the cdh 5.5.0 package.
> Namenode
[
https://issues.apache.org/jira/browse/HDFS-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214934#comment-15214934
]
Ravi Prakash commented on HDFS-10220:
-
Thank you for the report Nicolas! Which version of Hadoop did
44 matches
Mail list logo
